Re: [PATCH] pci: show dma_mask bits in /sys
Grant Grundler <grundler@parisc-linux.org> writes:
[color=blue]
> On Wed, Oct 22, 2008 at 09:28:33PM -0600, Matthew Wilcox wrote:[color=green]
>> On Wed, Oct 22, 2008 at 06:45:10PM -0700, Yinghai Lu wrote:[color=darkred]
>> > Grant prefer to add it /sys instead of showing in bootlog
>> >
>> > so could catch if the driver set the correct dma_mask.[/color]
>>
>> I still don't think this is useful information to be exposing.[/color]
>
> It's useful for anyone involved with device drivers - we agree that's
> a very limited subset of users. I certainly get fed up with trying
> to figure out which dma_mask each driver is using since in some[/color]
One simple way that doesn't need any kernel changes is to use
crash on the running kernel. I personally just stuck in printks
when I needed that, but it doesn't strike me as something that
is generally useful in standard kernels (agreeing with Willy)
-Andi
--
[email]ak@linux.intel.com[/email]
--
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to [email]majordomo@vger.kernel.org[/email]
More majordomo info at [url]http://vger.kernel.org/majordomo-info.html[/url]
Please read the FAQ at [url]http://www.tux.org/lkml/[/url]
Re: [PATCH] pci: show dma_mask bits in /sys
On Fri, Oct 24, 2008 at 12:50:12PM +0200, Andi Kleen wrote:[color=blue]
> Grant Grundler <grundler@parisc-linux.org> writes:
>[color=green]
> > On Wed, Oct 22, 2008 at 09:28:33PM -0600, Matthew Wilcox wrote:[color=darkred]
> >> On Wed, Oct 22, 2008 at 06:45:10PM -0700, Yinghai Lu wrote:
> >> > Grant prefer to add it /sys instead of showing in bootlog
> >> >
> >> > so could catch if the driver set the correct dma_mask.
> >>
> >> I still don't think this is useful information to be exposing.[/color]
> >
> > It's useful for anyone involved with device drivers - we agree that's
> > a very limited subset of users. I certainly get fed up with trying
> > to figure out which dma_mask each driver is using since in some[/color]
>
> One simple way that doesn't need any kernel changes is to use
> crash on the running kernel.[/color]
I would agree if someone can show me how to script crash to dump
all the struct pci_dev DMA masks and associate that output with
a driver and device instance.
[color=blue]
> I personally just stuck in printks
> when I needed that, but it doesn't strike me as something that
> is generally useful in standard kernels (agreeing with Willy)[/color]
Ok.
thanks,
grant
--
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to [email]majordomo@vger.kernel.org[/email]
More majordomo info at [url]http://vger.kernel.org/majordomo-info.html[/url]
Please read the FAQ at [url]http://www.tux.org/lkml/[/url]