[PATCH 4/5] W1: Export w1_read_8 function - Kernel

This is a discussion on [PATCH 4/5] W1: Export w1_read_8 function - Kernel ; From: Madhusudhan Chikkature This patch exports the w1_read_8 function for use of drivers. Signed-off-by: Madhusudhan Chikkature Acked-by: Evgeniy Polyakov --- drivers/w1/w1.h | 1 + drivers/w1/w1_io.c | 3 ++- 2 files changed, 3 insertions(+), 1 deletion(-) Index: linux-2.6/drivers/w1/w1_io.c ================================================== ================= --- ...

+ Reply to Thread
Results 1 to 2 of 2

Thread: [PATCH 4/5] W1: Export w1_read_8 function

  1. [PATCH 4/5] W1: Export w1_read_8 function

    From: Madhusudhan Chikkature

    This patch exports the w1_read_8 function for use of drivers.

    Signed-off-by: Madhusudhan Chikkature
    Acked-by: Evgeniy Polyakov
    ---
    drivers/w1/w1.h | 1 +
    drivers/w1/w1_io.c | 3 ++-
    2 files changed, 3 insertions(+), 1 deletion(-)

    Index: linux-2.6/drivers/w1/w1_io.c
    ================================================== =================
    --- linux-2.6.orig/drivers/w1/w1_io.c 2008-09-19 13:39:41.000000000 +0530
    +++ linux-2.6/drivers/w1/w1_io.c 2008-09-26 16:39:31.000000000 +0530
    @@ -177,7 +177,7 @@ u8 w1_triplet(struct w1_master *dev, int
    * @param dev the master device
    * @return the byte read
    */
    -static u8 w1_read_8(struct w1_master * dev)
    +u8 w1_read_8(struct w1_master * dev)
    {
    int i;
    u8 res = 0;
    @@ -190,6 +190,7 @@ static u8 w1_read_8(struct w1_master * d

    return res;
    }
    +EXPORT_SYMBOL_GPL(w1_read_8);

    /**
    * Writes a series of bytes.
    Index: linux-2.6/drivers/w1/w1.h
    ================================================== =================
    --- linux-2.6.orig/drivers/w1/w1.h 2008-09-19 13:39:41.000000000 +0530
    +++ linux-2.6/drivers/w1/w1.h 2008-09-26 16:42:45.000000000 +0530
    @@ -189,6 +189,7 @@ struct w1_master *w1_search_master_id(u3

    u8 w1_triplet(struct w1_master *dev, int bdir);
    void w1_write_8(struct w1_master *, u8);
    +u8 w1_read_8(struct w1_master *);
    int w1_reset_bus(struct w1_master *);
    u8 w1_calc_crc8(u8 *, int);
    void w1_write_block(struct w1_master *, const u8 *, int);--
    To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
    the body of a message to majordomo@vger.kernel.org
    More majordomo info at http://vger.kernel.org/majordomo-info.html
    Please read the FAQ at http://www.tux.org/lkml/

  2. Re: [PATCH 4/5] W1: Export w1_read_8 function

    On Wed, 8 Oct 2008 12:55:25 +0530
    "Gadiyar, Anand" wrote:

    > From: Madhusudhan Chikkature
    >
    > This patch exports the w1_read_8 function for use of drivers.
    >


    The changelog should explain why the export is needed (eg: "used by the
    foobar driver").

    If, as I assume, this symbol is used by the HDQ driver then this patch
    should be staged _ahead_ of those patches to avoid breaking
    bisectability, and because that's generally a saner ordering.


    --
    To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
    the body of a message to majordomo@vger.kernel.org
    More majordomo info at http://vger.kernel.org/majordomo-info.html
    Please read the FAQ at http://www.tux.org/lkml/

+ Reply to Thread