[PATCH 3/5] HDQ: OMAP: Add HDQ Device - Kernel

This is a discussion on [PATCH 3/5] HDQ: OMAP: Add HDQ Device - Kernel ; From: Madhusudhan Chikkature Device registeration for the TI OMAP2430/3430 HDQ driver. Signed-off-by: Madhusudhan Chikkature Acked-by: Felipe Balbi Acked-by: Evgeniy Polyakov --- arch/arm/mach-omap2/devices.c | 33 +++++++++++++++++++++++++++++++++ arch/arm/plat-omap/include/mach/irqs.h | 1 + 2 files changed, 34 insertions(+) Index: linux-2.6/arch/arm/mach-omap2/devices.c ================================================== ================= --- linux-2.6.orig/arch/arm/mach-omap2/devices.c ...

+ Reply to Thread
Results 1 to 2 of 2

Thread: [PATCH 3/5] HDQ: OMAP: Add HDQ Device

  1. [PATCH 3/5] HDQ: OMAP: Add HDQ Device

    From: Madhusudhan Chikkature

    Device registeration for the TI OMAP2430/3430 HDQ driver.

    Signed-off-by: Madhusudhan Chikkature
    Acked-by: Felipe Balbi
    Acked-by: Evgeniy Polyakov
    ---
    arch/arm/mach-omap2/devices.c | 33 +++++++++++++++++++++++++++++++++
    arch/arm/plat-omap/include/mach/irqs.h | 1 +
    2 files changed, 34 insertions(+)

    Index: linux-2.6/arch/arm/mach-omap2/devices.c
    ================================================== =================
    --- linux-2.6.orig/arch/arm/mach-omap2/devices.c 2008-09-19 13:39:38.000000000 +0530
    +++ linux-2.6/arch/arm/mach-omap2/devices.c 2008-09-30 10:07:51.000000000 +0530
    @@ -201,6 +201,38 @@ static void omap_init_mcspi(void)
    static inline void omap_init_mcspi(void) {}
    #endif

    +#if defined(CONFIG_HDQ_MASTER_OMAP) || defined(CONFIG_HDQ_MASTER_OMAP_MODULE)
    +#if defined(CONFIG_ARCH_OMAP2430) || defined(CONFIG_ARCH_OMAP3430)
    +#define OMAP_HDQ_BASE 0x480B2000
    +#endif
    +static struct resource omap_hdq_resources[] = {
    + {
    + .start = OMAP_HDQ_BASE,
    + .end = OMAP_HDQ_BASE + 0x1C,
    + .flags = IORESOURCE_MEM,
    + },
    + {
    + .start = INT_24XX_HDQ_IRQ,
    + .flags = IORESOURCE_IRQ,
    + },
    +};
    +static struct platform_device omap_hdq_dev = {
    + .name = "omap_hdq",
    + .id = 0,
    + .dev = {
    + .platform_data = NULL,
    + },
    + .num_resources = ARRAY_SIZE(omap_hdq_resources),
    + .resource = omap_hdq_resources,
    +};
    +static inline void omap_hdq_init(void)
    +{
    + (void) platform_device_register(&omap_hdq_dev);
    +}
    +#else
    +static inline void omap_hdq_init(void) {}
    +#endif
    +
    /*-------------------------------------------------------------------------*/

    static int __init omap2_init_devices(void)
    @@ -212,6 +244,7 @@ static int __init omap2_init_devices(voi
    omap_init_mbox();
    omap_init_mcspi();
    omap_init_sti();
    + omap_hdq_init();

    return 0;
    }
    Index: linux-2.6/arch/arm/plat-omap/include/mach/irqs.h
    ================================================== =================
    --- linux-2.6.orig/arch/arm/plat-omap/include/mach/irqs.h 2008-09-26 14:34:25.000000000 +0530
    +++ linux-2.6/arch/arm/plat-omap/include/mach/irqs.h 2008-09-26 14:55:19.000000000 +0530
    @@ -265,6 +265,7 @@
    #define INT_24XX_GPTIMER12 48
    #define INT_24XX_I2C1_IRQ 56
    #define INT_24XX_I2C2_IRQ 57
    +#define INT_24XX_HDQ_IRQ 58
    #define INT_24XX_MCBSP1_IRQ_TX 59
    #define INT_24XX_MCBSP1_IRQ_RX 60
    #define INT_24XX_MCBSP2_IRQ_TX 62--
    To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
    the body of a message to majordomo@vger.kernel.org
    More majordomo info at http://vger.kernel.org/majordomo-info.html
    Please read the FAQ at http://www.tux.org/lkml/

  2. Re: [PATCH 3/5] HDQ: OMAP: Add HDQ Device

    On Wed, 8 Oct 2008 12:53:57 +0530
    "Gadiyar, Anand" wrote:

    > From: Madhusudhan Chikkature
    >
    > Device registeration for the TI OMAP2430/3430 HDQ driver.
    >
    > Signed-off-by: Madhusudhan Chikkature
    > Acked-by: Felipe Balbi
    > Acked-by: Evgeniy Polyakov
    > ---
    > arch/arm/mach-omap2/devices.c | 33 +++++++++++++++++++++++++++++++++
    > arch/arm/plat-omap/include/mach/irqs.h | 1 +
    > 2 files changed, 34 insertions(+)
    >
    > Index: linux-2.6/arch/arm/mach-omap2/devices.c
    > ================================================== =================
    > --- linux-2.6.orig/arch/arm/mach-omap2/devices.c 2008-09-19 13:39:38.000000000 +0530
    > +++ linux-2.6/arch/arm/mach-omap2/devices.c 2008-09-30 10:07:51.000000000 +0530
    > @@ -201,6 +201,38 @@ static void omap_init_mcspi(void)
    > static inline void omap_init_mcspi(void) {}
    > #endif
    >
    > +#if defined(CONFIG_HDQ_MASTER_OMAP) || defined(CONFIG_HDQ_MASTER_OMAP_MODULE)
    > +#if defined(CONFIG_ARCH_OMAP2430) || defined(CONFIG_ARCH_OMAP3430)


    gad.

    > +#define OMAP_HDQ_BASE 0x480B2000
    > +#endif
    > +static struct resource omap_hdq_resources[] = {
    > + {
    > + .start = OMAP_HDQ_BASE,
    > + .end = OMAP_HDQ_BASE + 0x1C,
    > + .flags = IORESOURCE_MEM,
    > + },
    > + {
    > + .start = INT_24XX_HDQ_IRQ,
    > + .flags = IORESOURCE_IRQ,
    > + },
    > +};
    > +static struct platform_device omap_hdq_dev = {
    > + .name = "omap_hdq",
    > + .id = 0,
    > + .dev = {
    > + .platform_data = NULL,
    > + },
    > + .num_resources = ARRAY_SIZE(omap_hdq_resources),
    > + .resource = omap_hdq_resources,
    > +};
    > +static inline void omap_hdq_init(void)
    > +{
    > + (void) platform_device_register(&omap_hdq_dev);
    > +}


    The (void) thing is frowned upon.

    Failing to check the return value from registration functions is also
    frowned upon!


    --
    To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
    the body of a message to majordomo@vger.kernel.org
    More majordomo info at http://vger.kernel.org/majordomo-info.html
    Please read the FAQ at http://www.tux.org/lkml/

+ Reply to Thread