[PATCH] x86, Fix broken LDT access in VMI - Kernel

This is a discussion on [PATCH] x86, Fix broken LDT access in VMI - Kernel ; This one took a long time to rear up because LDT usage is not very common, but the bug is quite serious. It got introduced along with another bug, already fixed, by 75b8bb3e56ca09a467fbbe5229bc68627f7445be Please apply. Fix should also be headed ...

+ Reply to Thread
Results 1 to 3 of 3

Thread: [PATCH] x86, Fix broken LDT access in VMI

  1. [PATCH] x86, Fix broken LDT access in VMI

    This one took a long time to rear up because LDT usage is not very
    common, but the bug is quite serious. It got introduced along with
    another bug, already fixed, by 75b8bb3e56ca09a467fbbe5229bc68627f7445be

    Please apply. Fix should also be headed for stable tree and backported,
    it is really sadly trivial. Glauber, Ingo, sorry for the offlist
    posting, somehow the original missed LKML.

    Zach


  2. Re: [PATCH] x86, Fix broken LDT access in VMI


    * Zachary Amsden wrote:

    > This one took a long time to rear up because LDT usage is not very
    > common, but the bug is quite serious. It got introduced along with
    > another bug, already fixed, by 75b8bb3e56ca09a467fbbe5229bc68627f7445be
    >
    > Please apply. Fix should also be headed for stable tree and backported,
    > it is really sadly trivial. Glauber, Ingo, sorry for the offlist
    > posting, somehow the original missed LKML.


    > - vmi_ops.write_idt_entry(dt, entry, ldt_entry[0], ldt_entry[1]);
    > + vmi_ops.write_ldt_entry(dt, entry, ldt_entry[0], ldt_entry[1]);


    oops. Applied to tip/x86/urgent, thanks Zachary!

    Ingo
    --
    To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
    the body of a message to majordomo@vger.kernel.org
    More majordomo info at http://vger.kernel.org/majordomo-info.html
    Please read the FAQ at http://www.tux.org/lkml/

  3. Re: [PATCH] x86, Fix broken LDT access in VMI

    On Tue, Sep 30, 2008 at 3:13 PM, Ingo Molnar wrote:
    >> - vmi_ops.write_idt_entry(dt, entry, ldt_entry[0], ldt_entry[1]);
    >> + vmi_ops.write_ldt_entry(dt, entry, ldt_entry[0], ldt_entry[1]);


    For a few seconds I thought it was diff going mad diff'ing exactly
    similar lines.

    This one could actually use some capitalization to reduce the
    possibility of similar problems in future - rename to write_IDT_entry
    and write_LDT_entry perhaps?

    Parag
    --
    To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
    the body of a message to majordomo@vger.kernel.org
    More majordomo info at http://vger.kernel.org/majordomo-info.html
    Please read the FAQ at http://www.tux.org/lkml/

+ Reply to Thread