This is a discussion on Re: [PATCH] x86: enable CPUID on Cyrix cpus with CPUID disabled - Kernel ; > > * Krzysztof Helt wrote: > > > From: Krzysztof Helt > > > > The macros setCx86_old() and getCx86_old() do not > > work as a comment says in the processor-cyrix.h. > > > > Use working inline ...
> * Krzysztof Helt
> > From: Krzysztof Helt
> > The macros setCx86_old() and getCx86_old() do not
> > work as a comment says in the processor-cyrix.h.
> > Use working inline functions instead to enable
> > the CPUID instriction on Cyrix cpus.
> > Tested on IBM 6x86MX cpu with disabled the
> > CPUID instruction.
> > Signed-off-by: Krzysztof Helt
> > ---
> > This patch is against the linux-next tree (20080819)
> > as it contains the following patch:
> > x86, cyrix: debug
> > Signed-off-by: Ingo Molnar
> > The linux-2.6-tip tree has not the Ingo's patch so it
> > does not require my patch.
> > I am confused. Is the x86 detection code for Cyrix
> > cpus is right in the linux-next or in the linux-2.6-tip?
> > Should I prepare patches against the linux-2.6-tip
> > or linux-next?
> now that the bug is correctly understood and fixed, could you please
> send a patch that cleans it all up and gets rid of the setCx86_old() /
> setCx86() API distinction? I.e. revert commit 026e2c0 ("x86, cyrix:
> debug"). Against tip/master please.
> note that this was all done in connection to:
> commit c6744955d0ec0cb485c28c51eeb7185e260f6172
> Author: Samuel Sieb
> Date: Wed Aug 6 22:06:29 2008 -0700
> x86: fix "kernel won't boot on a Cyrix MediaGXm (Geode)"
I know that it was connected with the Geode booting, but I read the cyrix.c file and most paths are Geode specific and I won't be able to test them. I tested that reverting the commit 026e2c0 ("x86, cyrix: debug") does not break anything on 6x86MX cpu.
If the tip/master is a correct tree, please revert the commit 026e2c0 in the linux-next and drop this patch. This way everything is correct.
Dzwon taniej na zagraniczne komorki!
Sprawdz >> http://link.interia.pl/f1f26
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to email@example.com
More majordomo info at http://vger.kernel.org/majordomo-info.html
Please read the FAQ at http://www.tux.org/lkml/