BUG: Commit 1b7fc5aae8867046f8d3d45808309d5b7f2e036a makes special keys on my T21 unusable after resume - Kernel

This is a discussion on BUG: Commit 1b7fc5aae8867046f8d3d45808309d5b7f2e036a makes special keys on my T21 unusable after resume - Kernel ; Commit 1b7fc5aae8867046f8d3d45808309d5b7f2e036a causes my Thinkpad T21 to no longer generate any hotkey events (e.g. suspend fn-f4, switch-output fn-f7, etc.) after resume. It's regression from 2.6.25. 2.6.26 and 2.6.27-rc7 are broken, reverting that commit on 2.6.27-rc7 makes keys work again. Thanks. ...

+ Reply to Thread
Results 1 to 5 of 5

Thread: BUG: Commit 1b7fc5aae8867046f8d3d45808309d5b7f2e036a makes special keys on my T21 unusable after resume

  1. BUG: Commit 1b7fc5aae8867046f8d3d45808309d5b7f2e036a makes special keys on my T21 unusable after resume

    Commit 1b7fc5aae8867046f8d3d45808309d5b7f2e036a causes my Thinkpad T21
    to no longer generate any hotkey events (e.g. suspend fn-f4, switch-output
    fn-f7, etc.) after resume.

    It's regression from 2.6.25. 2.6.26 and 2.6.27-rc7 are broken,
    reverting that commit on 2.6.27-rc7 makes keys work again.

    Thanks.

    [Rafael added for regression tracking ;]


    commit 1b7fc5aae8867046f8d3d45808309d5b7f2e036a
    Author: Alexey Starikovskiy
    Date: Fri Jun 6 11:49:33 2008 -0400

    ACPI: EC: Use msleep instead of udelay while waiting for event.

    http://bugzilla.kernel.org/show_bug.cgi?id=10724

    Signed-off-by: Alexey Starikovskiy
    Signed-off-by: Len Brown

    diff --git a/drivers/acpi/ec.c b/drivers/acpi/ec.c
    index 0924992..5622aee 100644
    --- a/drivers/acpi/ec.c
    +++ b/drivers/acpi/ec.c
    @@ -194,7 +194,7 @@ static int acpi_ec_wait(struct acpi_ec *ec, enum ec_event event, int force_poll)
    while (time_before(jiffies, delay)) {
    if (acpi_ec_check_status(ec, event))
    return 0;
    - udelay(ACPI_EC_UDELAY);
    + msleep(1);
    }
    }
    pr_err(PREFIX "acpi_ec_wait timeout, status = 0x%2.2x, event = %s\n",


    --
    To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
    the body of a message to majordomo@vger.kernel.org
    More majordomo info at http://vger.kernel.org/majordomo-info.html
    Please read the FAQ at http://www.tux.org/lkml/

  2. Re: BUG: Commit 1b7fc5aae8867046f8d3d45808309d5b7f2e036a makes special keys on my T21 unusable after resume

    On Tuesday, 30 of September 2008, Karol Lewandowski wrote:
    > Commit 1b7fc5aae8867046f8d3d45808309d5b7f2e036a causes my Thinkpad T21
    > to no longer generate any hotkey events (e.g. suspend fn-f4, switch-output
    > fn-f7, etc.) after resume.
    >
    > It's regression from 2.6.25. 2.6.26 and 2.6.27-rc7 are broken,
    > reverting that commit on 2.6.27-rc7 makes keys work again.
    >
    > Thanks.
    >
    > [Rafael added for regression tracking ;]
    >
    >
    > commit 1b7fc5aae8867046f8d3d45808309d5b7f2e036a
    > Author: Alexey Starikovskiy
    > Date: Fri Jun 6 11:49:33 2008 -0400
    >
    > ACPI: EC: Use msleep instead of udelay while waiting for event.
    >
    > http://bugzilla.kernel.org/show_bug.cgi?id=10724
    >
    > Signed-off-by: Alexey Starikovskiy
    > Signed-off-by: Len Brown
    >
    > diff --git a/drivers/acpi/ec.c b/drivers/acpi/ec.c
    > index 0924992..5622aee 100644
    > --- a/drivers/acpi/ec.c
    > +++ b/drivers/acpi/ec.c
    > @@ -194,7 +194,7 @@ static int acpi_ec_wait(struct acpi_ec *ec, enum ec_event event, int force_poll)
    > while (time_before(jiffies, delay)) {
    > if (acpi_ec_check_status(ec, event))
    > return 0;
    > - udelay(ACPI_EC_UDELAY);
    > + msleep(1);
    > }
    > }
    > pr_err(PREFIX "acpi_ec_wait timeout, status = 0x%2.2x, event = %s\n",


    Can you see if the patch at
    http://bugzilla.kernel.org/attachmen...44&action=view
    (against current -git) helps?

    Thanks,
    Rafael
    --
    To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
    the body of a message to majordomo@vger.kernel.org
    More majordomo info at http://vger.kernel.org/majordomo-info.html
    Please read the FAQ at http://www.tux.org/lkml/

  3. Re: BUG: Commit 1b7fc5aae8867046f8d3d45808309d5b7f2e036a makes special keys on my T21 unusable after resume

    On Tue, Sep 30, 2008 at 12:25:52AM +0200, Rafael J. Wysocki wrote:

    > Can you see if the patch at
    > http://bugzilla.kernel.org/attachmen...44&action=view
    > (against current -git) helps?


    It doesn't help (and -rc8 doesn't help either).

    Thanks.
    --
    To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
    the body of a message to majordomo@vger.kernel.org
    More majordomo info at http://vger.kernel.org/majordomo-info.html
    Please read the FAQ at http://www.tux.org/lkml/

  4. Re: BUG: Commit 1b7fc5aae8867046f8d3d45808309d5b7f2e036a makes special keys on my T21 unusable after resume

    Karol Lewandowski wrote:
    > On Tue, Sep 30, 2008 at 12:25:52AM +0200, Rafael J. Wysocki wrote:
    >
    >> Can you see if the patch at
    >> http://bugzilla.kernel.org/attachmen...44&action=view
    >> (against current -git) helps?

    this patch is not in -rc8, and might even be postponed to 2.6.28-rc1.
    >
    > It doesn't help (and -rc8 doesn't help either).

    could you please uncomment "#define DEBUG" in the beginning of drivers/acpi/ec.c?
    please also open bug report in bugzilla.kernel.org against ACPI and
    attach dmesg from working and broken kernel with enabled DEBUG.
    Let me know the number of bug report.
    Thanks,
    Alex.
    --
    To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
    the body of a message to majordomo@vger.kernel.org
    More majordomo info at http://vger.kernel.org/majordomo-info.html
    Please read the FAQ at http://www.tux.org/lkml/

  5. Re: BUG: Commit 1b7fc5aae8867046f8d3d45808309d5b7f2e036a makes special keys on my T21 unusable after resume

    On Tue, Sep 30, 2008 at 08:46:07AM +0400, Alexey Starikovskiy wrote:
    > Karol Lewandowski wrote:
    > >On Tue, Sep 30, 2008 at 12:25:52AM +0200, Rafael J. Wysocki wrote:
    > >
    > >>Can you see if the patch at
    > >>http://bugzilla.kernel.org/attachmen...44&action=view
    > >>(against current -git) helps?

    > this patch is not in -rc8, and might even be postponed to 2.6.28-rc1.
    > >
    > >It doesn't help (and -rc8 doesn't help either).

    > could you please uncomment "#define DEBUG" in the beginning of
    > drivers/acpi/ec.c?
    > please also open bug report in bugzilla.kernel.org against ACPI and
    > attach dmesg from working and broken kernel with enabled DEBUG.
    > Let me know the number of bug report.


    It's http://bugzilla.kernel.org/show_bug.cgi?id=11674

    Thanks.
    --
    To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
    the body of a message to majordomo@vger.kernel.org
    More majordomo info at http://vger.kernel.org/majordomo-info.html
    Please read the FAQ at http://www.tux.org/lkml/

+ Reply to Thread