[PATCH] x86: IOMMU setup failures should not be KERN_ERR - Kernel

This is a discussion on [PATCH] x86: IOMMU setup failures should not be KERN_ERR - Kernel ; The number of BIOSes that have an option to enable the IOMMU, or fix anything about its configuration, is vanishingly small. There's no good reason to punish quiet boot for this. Signed-off-by: Adam Jackson --- arch/x86/kernel/aperture_64.c | 6 +++--- include/asm-x86/gart.h ...

+ Reply to Thread
Results 1 to 2 of 2

Thread: [PATCH] x86: IOMMU setup failures should not be KERN_ERR

  1. [PATCH] x86: IOMMU setup failures should not be KERN_ERR

    The number of BIOSes that have an option to enable the IOMMU, or fix
    anything about its configuration, is vanishingly small. There's no good
    reason to punish quiet boot for this.

    Signed-off-by: Adam Jackson
    ---
    arch/x86/kernel/aperture_64.c | 6 +++---
    include/asm-x86/gart.h | 6 +++---
    2 files changed, 6 insertions(+), 6 deletions(-)

    diff --git a/arch/x86/kernel/aperture_64.c b/arch/x86/kernel/aperture_64.c
    index 44e2182..9a32b37 100644
    --- a/arch/x86/kernel/aperture_64.c
    +++ b/arch/x86/kernel/aperture_64.c
    @@ -455,11 +455,11 @@ out:
    force_iommu ||
    valid_agp ||
    fallback_aper_force) {
    - printk(KERN_ERR
    + printk(KERN_INFO
    "Your BIOS doesn't leave a aperture memory hole\n");
    - printk(KERN_ERR
    + printk(KERN_INFO
    "Please enable the IOMMU option in the BIOS setup\n");
    - printk(KERN_ERR
    + printk(KERN_INFO
    "This costs you %d MB of RAM\n",
    32 << fallback_aper_order);

    diff --git a/include/asm-x86/gart.h b/include/asm-x86/gart.h
    index 3f62a83..583031c 100644
    --- a/include/asm-x86/gart.h
    +++ b/include/asm-x86/gart.h
    @@ -52,15 +52,15 @@ static inline int aperture_valid(u64 aper_base, u32 aper_size, u32 min_size)
    return 0;

    if (aper_base + aper_size > 0x100000000ULL) {
    - printk(KERN_ERR "Aperture beyond 4GB. Ignoring.\n");
    + printk(KERN_INFO "Aperture beyond 4GB. Ignoring.\n");
    return 0;
    }
    if (e820_any_mapped(aper_base, aper_base + aper_size, E820_RAM)) {
    - printk(KERN_ERR "Aperture pointing to e820 RAM. Ignoring.\n");
    + printk(KERN_INFO "Aperture pointing to e820 RAM. Ignoring.\n");
    return 0;
    }
    if (aper_size < min_size) {
    - printk(KERN_ERR "Aperture too small (%d MB) than (%d MB)\n",
    + printk(KERN_INFO "Aperture too small (%d MB) than (%d MB)\n",
    aper_size>>20, min_size>>20);
    return 0;
    }
    --
    1.6.0.1

    --
    To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
    the body of a message to majordomo@vger.kernel.org
    More majordomo info at http://vger.kernel.org/majordomo-info.html
    Please read the FAQ at http://www.tux.org/lkml/

  2. Re: [PATCH] x86: IOMMU setup failures should not be KERN_ERR


    * Adam Jackson wrote:

    > The number of BIOSes that have an option to enable the IOMMU, or fix
    > anything about its configuration, is vanishingly small. There's no good
    > reason to punish quiet boot for this.
    >
    > Signed-off-by: Adam Jackson
    > ---
    > arch/x86/kernel/aperture_64.c | 6 +++---
    > include/asm-x86/gart.h | 6 +++---
    > 2 files changed, 6 insertions(+), 6 deletions(-)


    applied to tip/x86/debug, thanks Adam!

    Ingo
    --
    To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
    the body of a message to majordomo@vger.kernel.org
    More majordomo info at http://vger.kernel.org/majordomo-info.html
    Please read the FAQ at http://www.tux.org/lkml/

+ Reply to Thread