This is a discussion on [patch 06/42] USB: cdc-acm: dont unlock acm->mutex on error path - Kernel ; 2.6.26-stable review patch. If anyone has any objections, please let us know. ------------------ From: Alexey Dobriyan commit 74573ee7096a4ffc2f098108d21c85801b9c7434 upstream On Wed, Jul 23, 2008 at 03:52:36PM +0300, Andrei Popa wrote: > I installed gnokii-0.6.22-r2 and gave the command "gnokii --identify" ...
2.6.26-stable review patch. If anyone has any objections, please let us know.
------------------
From: Alexey Dobriyan
commit 74573ee7096a4ffc2f098108d21c85801b9c7434 upstream
On Wed, Jul 23, 2008 at 03:52:36PM +0300, Andrei Popa wrote:
> I installed gnokii-0.6.22-r2 and gave the command "gnokii --identify"
> and the kernel oopsed:
>
> BUG: unable to handle kernel NULL pointer dereference at 00000458
> IP: [] mutex_unlock+0x0/0xb
> [] acm_tty_open+0x4c/0x214
Signed-off-by: Alexey Dobriyan
Tested-by: Andrei Popa
Signed-off-by: Andrew Morton
Signed-off-by: Greg Kroah-Hartman
---
drivers/usb/class/cdc-acm.c | 2 +-
1 file changed, 1 insertion(+), 1 deletion(-)
--- a/drivers/usb/class/cdc-acm.c
+++ b/drivers/usb/class/cdc-acm.c
@@ -525,8 +525,8 @@ static int acm_tty_open(struct tty_struc
tasklet_schedule(&acm->urb_task);
done:
-err_out:
mutex_unlock(&acm->mutex);
+err_out:
mutex_unlock(&open_mutex);
return rv;
--
--
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@vger.kernel.org
More majordomo info at http://vger.kernel.org/majordomo-info.html
Please read the FAQ at http://www.tux.org/lkml/