[PATCH] hotplug/rpaphp: remove unused error path code

#1 08-18-2008, 09:50 PM

Commit f46753c5e354b857b20ab8e0fe7b2579831dc369 ("PCI: introduce pci_slot") removed the need for this error path. Eliminate this warning:

drivers/pci/hotplug/rpaphp_slot.c: In function 'rpaphp_register_slot':
drivers/pci/hotplug/rpaphp_slot.c:151: warning: label 'sysfs_fail' defined but not used

Signed-off-by: Stephen Rothwell
---
drivers/pci/hotplug/rpaphp_slot.c | 4 ----
1 files changed, 0 insertions(+), 4 deletions(-)

diff --git a/drivers/pci/hotplug/rpaphp_slot.c b/drivers/pci/hotplug/rpaphp_slot.c
index 9b714ea..5088450 100644
--- a/drivers/pci/hotplug/rpaphp_slot.c
+++ b/drivers/pci/hotplug/rpaphp_slot.c
@@ -147,9 +147,5 @@ int rpaphp_register_slot(struct slot *slot)
list_add(&slot->rpaphp_slot_list, &rpaphp_slot_head);
info("Slot [%s] registered\n", slot->name);
return 0;
-
-sysfs_fail:
- pci_hp_deregister(php_slot);
- return retval;
}

--
1.5.6.3

--
Cheers,
Stephen Rothwell sfr@canb.auug.org.au
http://www.canb.auug.org.au/~sfr/
--
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@vger.kernel.org
More majordomo info at http://vger.kernel.org/majordomo-info.html
Please read the FAQ at http://www.tux.org/lkml/

#2 08-27-2008, 07:40 PM

On Monday, August 18, 2008 6:45 pm Stephen Rothwell wrote:
> Commit f46753c5e354b857b20ab8e0fe7b2579831dc369 ("PCI: introduce pci_slot")
> removed the need for this error path. Eliminate this warning:
>
> drivers/pci/hotplug/rpaphp_slot.c: In function 'rpaphp_register_slot':
> drivers/pci/hotplug/rpaphp_slot.c:151: warning: label 'sysfs_fail' defined
> but not used
>
> Signed-off-by: Stephen Rothwell

Applied to linux-next, thanks.

Jesse
--
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@vger.kernel.org
More majordomo info at http://vger.kernel.org/majordomo-info.html
Please read the FAQ at http://www.tux.org/lkml/

#3 08-27-2008, 11:20 PM

Hi Jesse,

On Wed, 27 Aug 2008 16:34:03 -0700 Jesse Barnes wrote:
>
> On Monday, August 18, 2008 6:45 pm Stephen Rothwell wrote:
> > Commit f46753c5e354b857b20ab8e0fe7b2579831dc369 ("PCI: introduce pci_slot")
> > removed the need for this error path. Eliminate this warning:
> >
> > drivers/pci/hotplug/rpaphp_slot.c: In function 'rpaphp_register_slot':
> > drivers/pci/hotplug/rpaphp_slot.c:151: warning: label 'sysfs_fail' defined
> > but not used
> >
> > Signed-off-by: Stephen Rothwell
>
> Applied to linux-next, thanks.

I has also been applied to the powerpc next tree, but that is ok.

--
Cheers,
Stephen Rothwell sfr@canb.auug.org.au
http://www.canb.auug.org.au/~sfr/

-----BEGIN PGP SIGNATURE-----
Version: GnuPG v1.4.9 (GNU/Linux)

iEYEARECAAYFAki2GI0ACgkQjjKRsyhoI8xHkwCgn3/0Tz3qTuigMOMLoV9+XMn8
JXsAoLbMnd2n3FnParu2hTTOAFb3qjGv
=ltml
-----END PGP SIGNATURE-----