[2.6 patch make struct scsi_dh_devlist's static - Kernel

This is a discussion on [2.6 patch make struct scsi_dh_devlist's static - Kernel ; This patch makes several needlessly global struct scsi_dh_devlist's static. Signed-off-by: Adrian Bunk Acked-by: Chandra Seetharaman --- drivers/scsi/device_handler/scsi_dh_alua.c | 2 +- drivers/scsi/device_handler/scsi_dh_emc.c | 2 +- drivers/scsi/device_handler/scsi_dh_hp_sw.c | 2 +- drivers/scsi/device_handler/scsi_dh_rdac.c | 2 +- 4 files changed, 4 insertions(+), 4 deletions(-) ae6ee914615e415cc4b22ee1c0545bb088889b6a ...

+ Reply to Thread
Results 1 to 2 of 2

Thread: [2.6 patch make struct scsi_dh_devlist's static

  1. [2.6 patch make struct scsi_dh_devlist's static

    This patch makes several needlessly global struct scsi_dh_devlist's
    static.

    Signed-off-by: Adrian Bunk
    Acked-by: Chandra Seetharaman

    ---

    drivers/scsi/device_handler/scsi_dh_alua.c | 2 +-
    drivers/scsi/device_handler/scsi_dh_emc.c | 2 +-
    drivers/scsi/device_handler/scsi_dh_hp_sw.c | 2 +-
    drivers/scsi/device_handler/scsi_dh_rdac.c | 2 +-
    4 files changed, 4 insertions(+), 4 deletions(-)

    ae6ee914615e415cc4b22ee1c0545bb088889b6a
    diff --git a/drivers/scsi/device_handler/scsi_dh_alua.c b/drivers/scsi/device_handler/scsi_dh_alua.c
    index fcdd73f..994da56 100644
    --- a/drivers/scsi/device_handler/scsi_dh_alua.c
    +++ b/drivers/scsi/device_handler/scsi_dh_alua.c
    @@ -680,7 +680,7 @@ static int alua_prep_fn(struct scsi_device *sdev, struct request *req)

    }

    -const struct scsi_dh_devlist alua_dev_list[] = {
    +static const struct scsi_dh_devlist alua_dev_list[] = {
    {"HP", "MSA VOLUME" },
    {"HP", "HSV101" },
    {"HP", "HSV111" },
    diff --git a/drivers/scsi/device_handler/scsi_dh_emc.c b/drivers/scsi/device_handler/scsi_dh_emc.c
    index aa46b13..b9d23e9 100644
    --- a/drivers/scsi/device_handler/scsi_dh_emc.c
    +++ b/drivers/scsi/device_handler/scsi_dh_emc.c
    @@ -562,7 +562,7 @@ done:
    return result;
    }

    -const struct scsi_dh_devlist clariion_dev_list[] = {
    +static const struct scsi_dh_devlist clariion_dev_list[] = {
    {"DGC", "RAID"},
    {"DGC", "DISK"},
    {"DGC", "VRAID"},
    diff --git a/drivers/scsi/device_handler/scsi_dh_hp_sw.c b/drivers/scsi/device_handler/scsi_dh_hp_sw.c
    index 9c7a1f8..a6a4ef3 100644
    --- a/drivers/scsi/device_handler/scsi_dh_hp_sw.c
    +++ b/drivers/scsi/device_handler/scsi_dh_hp_sw.c
    @@ -282,7 +282,7 @@ static int hp_sw_activate(struct scsi_device *sdev)
    return ret;
    }

    -const struct scsi_dh_devlist hp_sw_dh_data_list[] = {
    +static const struct scsi_dh_devlist hp_sw_dh_data_list[] = {
    {"COMPAQ", "MSA1000 VOLUME"},
    {"COMPAQ", "HSV110"},
    {"HP", "HSV100"},
    diff --git a/drivers/scsi/device_handler/scsi_dh_rdac.c b/drivers/scsi/device_handler/scsi_dh_rdac.c
    index b093a50..e7c7b4e 100644
    --- a/drivers/scsi/device_handler/scsi_dh_rdac.c
    +++ b/drivers/scsi/device_handler/scsi_dh_rdac.c
    @@ -574,7 +574,7 @@ static int rdac_check_sense(struct scsi_device *sdev,
    return SCSI_RETURN_NOT_HANDLED;
    }

    -const struct scsi_dh_devlist rdac_dev_list[] = {
    +static const struct scsi_dh_devlist rdac_dev_list[] = {
    {"IBM", "1722"},
    {"IBM", "1724"},
    {"IBM", "1726"},


    --
    To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
    the body of a message to majordomo@vger.kernel.org
    More majordomo info at http://vger.kernel.org/majordomo-info.html
    Please read the FAQ at http://www.tux.org/lkml/

  2. Re: [2.6 patch make struct scsi_dh_devlist's static



    On Mon, 11 Aug 2008, Chandra Seetharaman wrote:
    >
    > This patch makes several needlessly global struct scsi_dh_devlist's
    > static.
    >
    > Signed-off-by: Adrian Bunk
    > Acked-by: Chandra Seetharaman


    This is not a valid sign-off chain.

    Was the patch originally done by Adrian? If so, where is the

    From: Adrian Bunk

    at the top?

    And since you're forwarding it, you should be signing off on it, not just
    acking it. Otherwise, the next person in the chain can't sign off on it
    and take it.

    Linus
    --
    To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
    the body of a message to majordomo@vger.kernel.org
    More majordomo info at http://vger.kernel.org/majordomo-info.html
    Please read the FAQ at http://www.tux.org/lkml/

+ Reply to Thread