[PATCH] net/rxrpc: Use an IS_ERR test rather than a NULL test - Kernel

This is a discussion on [PATCH] net/rxrpc: Use an IS_ERR test rather than a NULL test - Kernel ; From: Julien Brunel In case of error, the function rxrpc_get_transport returns an ERR pointer, but never returns a NULL pointer. So after a call to this function, a NULL test should be replaced by an IS_ERR test. A simplified version ...

+ Reply to Thread
Results 1 to 2 of 2

Thread: [PATCH] net/rxrpc: Use an IS_ERR test rather than a NULL test

  1. [PATCH] net/rxrpc: Use an IS_ERR test rather than a NULL test

    From: Julien Brunel

    In case of error, the function rxrpc_get_transport returns an ERR
    pointer, but never returns a NULL pointer. So after a call to this
    function, a NULL test should be replaced by an IS_ERR test.

    A simplified version of the semantic patch that makes this change is
    as follows:
    (http://www.emn.fr/x-info/coccinelle/)

    //
    @correct_null_test@
    expression x,E;
    statement S1, S2;
    @@
    x = rxrpc_get_transport(...)
    <... when != x = E
    if (
    (
    - x@p2 != NULL
    + ! IS_ERR ( x )
    |
    - x@p2 == NULL
    + IS_ERR( x )
    )
    )
    S1
    else S2
    ....>
    ? x = E;
    //


    Signed-off-by: Julien Brunel
    Signed-off-by: Julia Lawall

    ---
    net/rxrpc/ar-accept.c | 2 +-
    1 file changed, 1 insertion(+), 1 deletion(-)

    diff -u -p a/net/rxrpc/ar-accept.c b/net/rxrpc/ar-accept.c
    --- a/net/rxrpc/ar-accept.c
    +++ b/net/rxrpc/ar-accept.c
    @@ -100,7 +100,7 @@ static int rxrpc_accept_incoming_call(st

    trans = rxrpc_get_transport(local, peer, GFP_NOIO);
    rxrpc_put_peer(peer);
    - if (!trans) {
    + if (IS_ERR(trans)) {
    _debug("no trans");
    ret = -EBUSY;
    goto error;
    --
    To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
    the body of a message to majordomo@vger.kernel.org
    More majordomo info at http://vger.kernel.org/majordomo-info.html
    Please read the FAQ at http://www.tux.org/lkml/

  2. Re: [PATCH] net/rxrpc: Use an IS_ERR test rather than a NULL test

    From: Julien Brunel
    Date: Fri, 8 Aug 2008 13:55:21 +0200

    > In case of error, the function rxrpc_get_transport returns an ERR
    > pointer, but never returns a NULL pointer. So after a call to this
    > function, a NULL test should be replaced by an IS_ERR test.
    >
    > A simplified version of the semantic patch that makes this change is
    > as follows:
    > (http://www.emn.fr/x-info/coccinelle/)

    ...
    > Signed-off-by: Julien Brunel
    > Signed-off-by: Julia Lawall


    Applied, thank you.
    --
    To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
    the body of a message to majordomo@vger.kernel.org
    More majordomo info at http://vger.kernel.org/majordomo-info.html
    Please read the FAQ at http://www.tux.org/lkml/

+ Reply to Thread