[RFC, 2.6.26.2-rc1] exec: remove some includes - Kernel

This is a discussion on [RFC, 2.6.26.2-rc1] exec: remove some includes - Kernel ; From ba92a43dbaee339cf5915ef766d3d3ffbaaf103c Mon Sep 17 00:00:00 2001 From: Hugh Dickins Date: Fri, 25 Jul 2008 01:45:43 -0700 Subject: [PATCH] exec: remove some includes [ Upstream commit ba92a43dbaee339cf5915ef766d3d3ffbaaf103c ] fs/exec.c used to need mman.h pagemap.h swap.h and rmap.h when it did ...

+ Reply to Thread
Results 1 to 5 of 5

Thread: [RFC, 2.6.26.2-rc1] exec: remove some includes

  1. [RFC, 2.6.26.2-rc1] exec: remove some includes

    From ba92a43dbaee339cf5915ef766d3d3ffbaaf103c Mon Sep 17 00:00:00 2001
    From: Hugh Dickins
    Date: Fri, 25 Jul 2008 01:45:43 -0700
    Subject: [PATCH] exec: remove some includes

    [ Upstream commit ba92a43dbaee339cf5915ef766d3d3ffbaaf103c ]

    fs/exec.c used to need mman.h pagemap.h swap.h and rmap.h when it did
    mm-ish stuff in install_arg_page(); but no need for them after 2.6.22.

    [akpm@linux-foundation.org: unbreak arm]
    Signed-off-by: Hugh Dickins
    Signed-off-by: Andrew Morton
    Signed-off-by: Linus Torvalds
    CC: Oliver Pinter

    diff --git a/fs/exec.c b/fs/exec.c
    index 190ed1f..e41aef0 100644
    --- a/fs/exec.c
    +++ b/fs/exec.c
    @@ -25,19 +25,18 @@
    #include
    #include
    #include
    -#include
    +#include
    #include
    #include
    #include
    +#include
    #include
    #include
    -#include
    #include
    #include
    #include
    #include
    #include
    -#include
    #include
    #include
    #include
    @@ -47,7 +46,6 @@
    #include
    #include
    #include
    -#include
    #include
    #include
    #include
    --
    To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
    the body of a message to majordomo@vger.kernel.org
    More majordomo info at http://vger.kernel.org/majordomo-info.html
    Please read the FAQ at http://www.tux.org/lkml/

  2. Re: [RFC, 2.6.26.2-rc1] exec: remove some includes



    On Sat, 2 Aug 2008, Oliver Pinter wrote:
    >
    > [ Upstream commit ba92a43dbaee339cf5915ef766d3d3ffbaaf103c ]
    >
    > fs/exec.c used to need mman.h pagemap.h swap.h and rmap.h when it did
    > mm-ish stuff in install_arg_page(); but no need for them after 2.6.22.


    Why on earth would this be -stable material?

    Linus
    --
    To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
    the body of a message to majordomo@vger.kernel.org
    More majordomo info at http://vger.kernel.org/majordomo-info.html
    Please read the FAQ at http://www.tux.org/lkml/

  3. Re: [RFC, 2.6.26.2-rc1] exec: remove some includes

    On Sat, Aug 02, 2008 at 09:45:17PM +0200, Oliver Pinter wrote:
    > >From ba92a43dbaee339cf5915ef766d3d3ffbaaf103c Mon Sep 17 00:00:00 2001

    > From: Hugh Dickins
    > Date: Fri, 25 Jul 2008 01:45:43 -0700
    > Subject: [PATCH] exec: remove some includes
    >
    > [ Upstream commit ba92a43dbaee339cf5915ef766d3d3ffbaaf103c ]
    >
    > fs/exec.c used to need mman.h pagemap.h swap.h and rmap.h when it did
    > mm-ish stuff in install_arg_page(); but no need for them after 2.6.22.

    ^^^^^^^
    Oliver, this patch apparently fixes nothing, and playing with includes
    always causes a risk of regression. Please ensure that only fixes for
    real problems are submitted to stable and check stable_kernel_rules.txt
    when in doubt.

    Willy

    --
    To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
    the body of a message to majordomo@vger.kernel.org
    More majordomo info at http://vger.kernel.org/majordomo-info.html
    Please read the FAQ at http://www.tux.org/lkml/

  4. Re: [RFC, 2.6.26.2-rc1] exec: remove some includes

    On Sat, 2 Aug 2008, Linus Torvalds wrote:
    > On Sat, 2 Aug 2008, Oliver Pinter wrote:
    > >
    > > [ Upstream commit ba92a43dbaee339cf5915ef766d3d3ffbaaf103c ]
    > >
    > > fs/exec.c used to need mman.h pagemap.h swap.h and rmap.h when it did
    > > mm-ish stuff in install_arg_page(); but no need for them after 2.6.22.

    >
    > Why on earth would this be -stable material?


    Of course it isn't -stable material, I don't know what Oliver's on.

    Maybe he noticed akpm's "unbreak arm" comment and thought it was
    fixing some pre-existing breakage: no, akpm restored swap.h to
    fix the arm build. Then after this commit, we had to restore
    pagemap.h to fix avr32 and !CONFIG_SWAP builds.

    Prime material for -unstable, I'm ashamed to say.

    Hugh
    --
    To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
    the body of a message to majordomo@vger.kernel.org
    More majordomo info at http://vger.kernel.org/majordomo-info.html
    Please read the FAQ at http://www.tux.org/lkml/

  5. Re: [RFC, 2.6.26.2-rc1] exec: remove some includes

    I understood, I do not send patches with a character like this in the
    future then, but I send it because of this in RFC

    On 8/2/08, Willy Tarreau wrote:
    > On Sat, Aug 02, 2008 at 09:45:17PM +0200, Oliver Pinter wrote:
    >> >From ba92a43dbaee339cf5915ef766d3d3ffbaaf103c Mon Sep 17 00:00:00 2001

    >> From: Hugh Dickins
    >> Date: Fri, 25 Jul 2008 01:45:43 -0700
    >> Subject: [PATCH] exec: remove some includes
    >>
    >> [ Upstream commit ba92a43dbaee339cf5915ef766d3d3ffbaaf103c ]
    >>
    >> fs/exec.c used to need mman.h pagemap.h swap.h and rmap.h when it did
    >> mm-ish stuff in install_arg_page(); but no need for them after 2.6.22.

    > ^^^^^^^
    > Oliver, this patch apparently fixes nothing, and playing with includes
    > always causes a risk of regression. Please ensure that only fixes for
    > real problems are submitted to stable and check stable_kernel_rules.txt
    > when in doubt.
    >
    > Willy
    >
    >



    --
    Thanks,
    Oliver
    --
    To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
    the body of a message to majordomo@vger.kernel.org
    More majordomo info at http://vger.kernel.org/majordomo-info.html
    Please read the FAQ at http://www.tux.org/lkml/

+ Reply to Thread