[PATCH] usb: don't hide bios bug warning - Kernel

This is a discussion on [PATCH] usb: don't hide bios bug warning - Kernel ; quirk_usb_disable_handoff will wait a while if there is BIOS bug. let the end user know the reason for that. Signed-off-by: Yinghai Lu --- drivers/usb/host/pci-quirks.c | 9 ++++++--- 1 file changed, 6 insertions(+), 3 deletions(-) Index: linux-2.6/drivers/usb/host/pci-quirks.c ================================================== ================= --- linux-2.6.orig/drivers/usb/host/pci-quirks.c ...

+ Reply to Thread
Results 1 to 5 of 5

Thread: [PATCH] usb: don't hide bios bug warning

  1. [PATCH] usb: don't hide bios bug warning


    quirk_usb_disable_handoff will wait a while if there is BIOS bug.
    let the end user know the reason for that.

    Signed-off-by: Yinghai Lu

    ---
    drivers/usb/host/pci-quirks.c | 9 ++++++---
    1 file changed, 6 insertions(+), 3 deletions(-)

    Index: linux-2.6/drivers/usb/host/pci-quirks.c
    ================================================== =================
    --- linux-2.6.orig/drivers/usb/host/pci-quirks.c
    +++ linux-2.6/drivers/usb/host/pci-quirks.c
    @@ -190,7 +190,8 @@ static void __devinit quirk_usb_handoff_
    msleep(10);
    }
    if (wait_time <= 0)
    - dev_warn(&pdev->dev, "OHCI: BIOS handoff failed"
    + dev_printk(KERN_WARNING, &pdev->dev,
    + "OHCI: BIOS handoff failed"
    " (BIOS bug?) %08x\n",
    readl(base + OHCI_CONTROL));

    @@ -242,7 +243,8 @@ static void __devinit quirk_usb_disable_
    switch (cap & 0xff) {
    case 1: /* BIOS/SMM/... handoff support */
    if ((cap & EHCI_USBLEGSUP_BIOS)) {
    - dev_dbg(&pdev->dev, "EHCI: BIOS handoff\n");
    + dev_printk(KERN_DEBUG, &pdev->dev,
    + "EHCI: BIOS handoff\n");

    #if 0
    /* aleksey_gorelov@phoenix.com reports that some systems need SMI forced on,
    @@ -283,7 +285,8 @@ static void __devinit quirk_usb_disable_
    /* well, possibly buggy BIOS... try to shut
    * it down, and hope nothing goes too wrong
    */
    - dev_warn(&pdev->dev, "EHCI: BIOS handoff failed"
    + dev_printk(KERN_WARNING, &pdev->dev,
    + "EHCI: BIOS handoff failed"
    " (BIOS bug?) %08x\n", cap);
    pci_write_config_byte(pdev, offset + 2, 0);
    }
    --
    To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
    the body of a message to majordomo@vger.kernel.org
    More majordomo info at http://vger.kernel.org/majordomo-info.html
    Please read the FAQ at http://www.tux.org/lkml/

  2. Re: [PATCH] usb: don't hide bios bug warning

    On Sat, Jul 26, 2008 at 06:12:15PM -0700, Yinghai Lu wrote:
    >
    > quirk_usb_disable_handoff will wait a while if there is BIOS bug.
    > let the end user know the reason for that.
    >
    > Signed-off-by: Yinghai Lu
    >
    > ---
    > drivers/usb/host/pci-quirks.c | 9 ++++++---
    > 1 file changed, 6 insertions(+), 3 deletions(-)
    >
    > Index: linux-2.6/drivers/usb/host/pci-quirks.c
    > ================================================== =================
    > --- linux-2.6.orig/drivers/usb/host/pci-quirks.c
    > +++ linux-2.6/drivers/usb/host/pci-quirks.c
    > @@ -190,7 +190,8 @@ static void __devinit quirk_usb_handoff_
    > msleep(10);
    > }
    > if (wait_time <= 0)
    > - dev_warn(&pdev->dev, "OHCI: BIOS handoff failed"
    > + dev_printk(KERN_WARNING, &pdev->dev,
    > + "OHCI: BIOS handoff failed"


    This is the exact same thing here, no change.

    > @@ -242,7 +243,8 @@ static void __devinit quirk_usb_disable_
    > switch (cap & 0xff) {
    > case 1: /* BIOS/SMM/... handoff support */
    > if ((cap & EHCI_USBLEGSUP_BIOS)) {
    > - dev_dbg(&pdev->dev, "EHCI: BIOS handoff\n");
    > + dev_printk(KERN_DEBUG, &pdev->dev,
    > + "EHCI: BIOS handoff\n");


    Is this what you really want to see? But you just made things noiser.

    > @@ -283,7 +285,8 @@ static void __devinit quirk_usb_disable_
    > /* well, possibly buggy BIOS... try to shut
    > * it down, and hope nothing goes too wrong
    > */
    > - dev_warn(&pdev->dev, "EHCI: BIOS handoff failed"
    > + dev_printk(KERN_WARNING, &pdev->dev,
    > + "EHCI: BIOS handoff failed"


    This is the exact same thing, no change.

    confused,

    greg k-h
    --
    To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
    the body of a message to majordomo@vger.kernel.org
    More majordomo info at http://vger.kernel.org/majordomo-info.html
    Please read the FAQ at http://www.tux.org/lkml/

  3. Re: [PATCH] usb: don't hide bios bug warning

    On Sat, Jul 26, 2008 at 6:24 PM, Greg KH wrote:
    > On Sat, Jul 26, 2008 at 06:12:15PM -0700, Yinghai Lu wrote:
    >>
    >> quirk_usb_disable_handoff will wait a while if there is BIOS bug.
    >> let the end user know the reason for that.
    >>
    >> Signed-off-by: Yinghai Lu
    >>
    >> ---
    >> drivers/usb/host/pci-quirks.c | 9 ++++++---
    >> 1 file changed, 6 insertions(+), 3 deletions(-)
    >>
    >> Index: linux-2.6/drivers/usb/host/pci-quirks.c
    >> ================================================== =================
    >> --- linux-2.6.orig/drivers/usb/host/pci-quirks.c
    >> +++ linux-2.6/drivers/usb/host/pci-quirks.c
    >> @@ -190,7 +190,8 @@ static void __devinit quirk_usb_handoff_
    >> msleep(10);
    >> }
    >> if (wait_time <= 0)
    >> - dev_warn(&pdev->dev, "OHCI: BIOS handoff failed"
    >> + dev_printk(KERN_WARNING, &pdev->dev,
    >> + "OHCI: BIOS handoff failed"

    >
    > This is the exact same thing here, no change.
    >
    >> @@ -242,7 +243,8 @@ static void __devinit quirk_usb_disable_
    >> switch (cap & 0xff) {
    >> case 1: /* BIOS/SMM/... handoff support */
    >> if ((cap & EHCI_USBLEGSUP_BIOS)) {
    >> - dev_dbg(&pdev->dev, "EHCI: BIOS handoff\n");
    >> + dev_printk(KERN_DEBUG, &pdev->dev,
    >> + "EHCI: BIOS handoff\n");

    >
    > Is this what you really want to see? But you just made things noiser.
    >
    >> @@ -283,7 +285,8 @@ static void __devinit quirk_usb_disable_
    >> /* well, possibly buggy BIOS... try to shut
    >> * it down, and hope nothing goes too wrong
    >> */
    >> - dev_warn(&pdev->dev, "EHCI: BIOS handoff failed"
    >> + dev_printk(KERN_WARNING, &pdev->dev,
    >> + "EHCI: BIOS handoff failed"

    >
    > This is the exact same thing, no change.
    >
    > confused,


    end user will not set CONFIG_USB_DEBUG, so that dev_warn will do nothing.

    YH
    --
    To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
    the body of a message to majordomo@vger.kernel.org
    More majordomo info at http://vger.kernel.org/majordomo-info.html
    Please read the FAQ at http://www.tux.org/lkml/

  4. Re: [PATCH] usb: don't hide bios bug warning

    > >> - dev_warn(&pdev->dev, "EHCI: BIOS handoff failed"
    > >> + dev_printk(KERN_WARNING, &pdev->dev,
    > >> + "EHCI: BIOS handoff failed"

    > >
    > > This is the exact same thing, no change.
    > >
    > > confused,

    >
    > end user will not set CONFIG_USB_DEBUG, so that dev_warn will do nothing.


    Yes it does ... KERN_WARNING != KERN_DEBUG, and it's the latter
    which is toggled (via DEBUG) by CONFIG_USB_DEBUG...
    --
    To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
    the body of a message to majordomo@vger.kernel.org
    More majordomo info at http://vger.kernel.org/majordomo-info.html
    Please read the FAQ at http://www.tux.org/lkml/

  5. Re: [PATCH] usb: don't hide bios bug warning

    On Sat, Jul 26, 2008 at 6:56 PM, David Brownell wrote:
    >> >> - dev_warn(&pdev->dev, "EHCI: BIOS handoff failed"
    >> >> + dev_printk(KERN_WARNING, &pdev->dev,
    >> >> + "EHCI: BIOS handoff failed"
    >> >
    >> > This is the exact same thing, no change.
    >> >
    >> > confused,

    >>
    >> end user will not set CONFIG_USB_DEBUG, so that dev_warn will do nothing.

    >
    > Yes it does ... KERN_WARNING != KERN_DEBUG, and it's the latter
    > which is toggled (via DEBUG) by CONFIG_USB_DEBUG...


    you are right,

    please forget about the patch.

    YH
    --
    To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
    the body of a message to majordomo@vger.kernel.org
    More majordomo info at http://vger.kernel.org/majordomo-info.html
    Please read the FAQ at http://www.tux.org/lkml/

+ Reply to Thread