[PATCH] netns: fix ip_rt_frag_needed rt_is_expired - Kernel

This is a discussion on [PATCH] netns: fix ip_rt_frag_needed rt_is_expired - Kernel ; Running recent kernels, and using a particular vpn gateway, I've been having to edit my mails down to get them accepted by the smtp server. Git bisect led to commit e84f84f276473dcc673f360e8ff3203148bdf0e2 - netns: place rt_genid into struct net. The conversion ...

+ Reply to Thread
Results 1 to 5 of 5

Thread: [PATCH] netns: fix ip_rt_frag_needed rt_is_expired

  1. [PATCH] netns: fix ip_rt_frag_needed rt_is_expired

    Running recent kernels, and using a particular vpn gateway, I've been
    having to edit my mails down to get them accepted by the smtp server.

    Git bisect led to commit e84f84f276473dcc673f360e8ff3203148bdf0e2 -
    netns: place rt_genid into struct net. The conversion from a != test
    to rt_is_expired() put one negative too many: and now my mail works.

    Signed-off-by: Hugh Dickins
    ---
    Ingo was having strange distcc problems, might this help him too?

    net/ipv4/route.c | 2 +-
    1 file changed, 1 insertion(+), 1 deletion(-)

    --- 2.6.26-git/net/ipv4/route.c 2008-07-26 12:31:50.000000000 +0100
    +++ linux/net/ipv4/route.c 2008-07-26 13:10:04.000000000 +0100
    @@ -1502,7 +1502,7 @@ unsigned short ip_rt_frag_needed(struct
    rth->fl.iif != 0 ||
    dst_metric_locked(&rth->u.dst, RTAX_MTU) ||
    !net_eq(dev_net(rth->u.dst.dev), net) ||
    - !rt_is_expired(rth))
    + rt_is_expired(rth))
    continue;

    if (new_mtu < 68 || new_mtu >= old_mtu) {
    --
    To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
    the body of a message to majordomo@vger.kernel.org
    More majordomo info at http://vger.kernel.org/majordomo-info.html
    Please read the FAQ at http://www.tux.org/lkml/

  2. Re: [PATCH] netns: fix ip_rt_frag_needed rt_is_expired

    Acked-by: Denis V. Lunev

    Thanks for founding this issue...

    On Sat, 2008-07-26 at 13:48 +0100, Hugh Dickins wrote:
    > Running recent kernels, and using a particular vpn gateway, I've been
    > having to edit my mails down to get them accepted by the smtp server.
    >
    > Git bisect led to commit e84f84f276473dcc673f360e8ff3203148bdf0e2 -
    > netns: place rt_genid into struct net. The conversion from a != test
    > to rt_is_expired() put one negative too many: and now my mail works.
    >
    > Signed-off-by: Hugh Dickins
    > ---
    > Ingo was having strange distcc problems, might this help him too?
    >
    > net/ipv4/route.c | 2 +-
    > 1 file changed, 1 insertion(+), 1 deletion(-)
    >
    > --- 2.6.26-git/net/ipv4/route.c 2008-07-26 12:31:50.000000000 +0100
    > +++ linux/net/ipv4/route.c 2008-07-26 13:10:04.000000000 +0100
    > @@ -1502,7 +1502,7 @@ unsigned short ip_rt_frag_needed(struct
    > rth->fl.iif != 0 ||
    > dst_metric_locked(&rth->u.dst, RTAX_MTU) ||
    > !net_eq(dev_net(rth->u.dst.dev), net) ||
    > - !rt_is_expired(rth))
    > + rt_is_expired(rth))
    > continue;
    >
    > if (new_mtu < 68 || new_mtu >= old_mtu) {


    --
    To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
    the body of a message to majordomo@vger.kernel.org
    More majordomo info at http://vger.kernel.org/majordomo-info.html
    Please read the FAQ at http://www.tux.org/lkml/

  3. Re: [PATCH] netns: fix ip_rt_frag_needed rt_is_expired

    On Sat, 2008-07-26 at 20:40 +0400, Denis V. Lunev wrote:
    > Acked-by: Denis V. Lunev
    >
    > Thanks for founding this issue...


    oops... I mean finding and fixing... my fault again

    --
    To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
    the body of a message to majordomo@vger.kernel.org
    More majordomo info at http://vger.kernel.org/majordomo-info.html
    Please read the FAQ at http://www.tux.org/lkml/

  4. Re: [PATCH] netns: fix ip_rt_frag_needed rt_is_expired

    On Sat, 26 Jul 2008, Denis V. Lunev wrote:
    > On Sat, 2008-07-26 at 20:40 +0400, Denis V. Lunev wrote:
    > > Acked-by: Denis V. Lunev
    > >
    > > Thanks for founding this issue...

    >
    > oops... I mean finding and fixing... my fault again


    No problem - and both errors were quite understandable!

    Hugh
    --
    To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
    the body of a message to majordomo@vger.kernel.org
    More majordomo info at http://vger.kernel.org/majordomo-info.html
    Please read the FAQ at http://www.tux.org/lkml/

  5. Re: [PATCH] netns: fix ip_rt_frag_needed rt_is_expired

    From: "Denis V. Lunev"
    Date: Sat, 26 Jul 2008 20:37:32 +0400

    > Acked-by: Denis V. Lunev


    Applied, thanks a lot everyone.
    --
    To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
    the body of a message to majordomo@vger.kernel.org
    More majordomo info at http://vger.kernel.org/majordomo-info.html
    Please read the FAQ at http://www.tux.org/lkml/

+ Reply to Thread