sfx.c driver build failure - Kernel

This is a discussion on sfx.c driver build failure - Kernel ; Hi Michael ! The sfx driver (which happens to be part of some of our test configs) fails to build in current Linus tree on powerpc with this error: /home/benh/kernels/linux-powerpc/drivers/net/sfc/efx.c: In function ‘efx_probe_interrupts’: /home/benh/kernels/linux-powerpc/drivers/net/sfc/efx.c:845: error: lvalue required as unary ‘&’ ...

+ Reply to Thread
Results 1 to 5 of 5

Thread: sfx.c driver build failure

  1. sfx.c driver build failure

    Hi Michael !

    The sfx driver (which happens to be part of some of our test configs)
    fails to build in current Linus tree on powerpc with this error:

    /home/benh/kernels/linux-powerpc/drivers/net/sfc/efx.c: In function ‘efx_probe_interrupts’:
    /home/benh/kernels/linux-powerpc/drivers/net/sfc/efx.c:845: error: lvalue required as unary ‘&’ oper
    and

    Cheers,
    Ben.


    --
    To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
    the body of a message to majordomo@vger.kernel.org
    More majordomo info at http://vger.kernel.org/majordomo-info.html
    Please read the FAQ at http://www.tux.org/lkml/

  2. Re: sfx.c driver build failure

    On Fri, 25 Jul 2008 16:15:59 +1000 Benjamin Herrenschmidt wrote:
    >
    > The sfx driver (which happens to be part of some of our test configs)
    > fails to build in current Linus tree on powerpc with this error:
    >
    > /home/benh/kernels/linux-powerpc/drivers/net/sfc/efx.c: In function ‘efx_probe_interrupts’:
    > /home/benh/kernels/linux-powerpc/drivers/net/sfc/efx.c:845: error: lvaluerequired as unary ‘&’ operand


    Commit 695a6b456307455a10059512208e8ed0d376ecd3 "topology: work around
    topology_core_siblings() breakage" in linux-next (from the cpus4096 tree)
    comments out the offending lines ... With the comment "the topology API
    is a mess right now".

    --
    Cheers,
    Stephen Rothwell sfr@canb.auug.org.au
    http://www.canb.auug.org.au/~sfr/

    -----BEGIN PGP SIGNATURE-----
    Version: GnuPG v1.4.9 (GNU/Linux)

    iEYEARECAAYFAkiJffsACgkQjjKRsyhoI8zX6ACeP7LvkzHL3u jlfcXok1av2KZu
    z58AoKXXaEI0I5Yy4gWJDtRC5e7SHszi
    =o3CA
    -----END PGP SIGNATURE-----


  3. Re: sfx.c driver build failure


    * Stephen Rothwell wrote:

    > On Fri, 25 Jul 2008 16:15:59 +1000 Benjamin Herrenschmidt wrote:
    > >
    > > The sfx driver (which happens to be part of some of our test configs)
    > > fails to build in current Linus tree on powerpc with this error:
    > >
    > > /home/benh/kernels/linux-powerpc/drivers/net/sfc/efx.c: In function ‘efx_probe_interrupts’:
    > > /home/benh/kernels/linux-powerpc/drivers/net/sfc/efx.c:845: error: lvalue required as unary ‘&’ operand

    >
    > Commit 695a6b456307455a10059512208e8ed0d376ecd3 "topology: work around
    > topology_core_siblings() breakage" in linux-next (from the cpus4096
    > tree) comments out the offending lines ... With the comment "the
    > topology API is a mess right now".


    there's a patch from Mike Travis that solves it all from grounds up and
    which approach has the ack of Rusty as well, but it's not fully tested
    through yet - i will get to it later today.

    Ingo
    --
    To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
    the body of a message to majordomo@vger.kernel.org
    More majordomo info at http://vger.kernel.org/majordomo-info.html
    Please read the FAQ at http://www.tux.org/lkml/

  4. Re: sfx.c driver build failure

    On Fri, 2008-07-25 at 08:35 +0100, Michael Brown wrote:
    > On Fri, 25 Jul 2008, Benjamin Herrenschmidt wrote:
    > > The sfx driver (which happens to be part of some of our test configs)
    > > fails to build in current Linus tree on powerpc with this error:
    > >
    > > /home/benh/kernels/linux-powerpc/drivers/net/sfc/efx.c: In function ÿÿefx_probe_interruptsÿÿ:
    > > /home/benh/kernels/linux-powerpc/drivers/net/sfc/efx.c:845: error: lvalue required as unary ÿÿ&ÿÿ oper
    > > and

    >
    > I'm not the maintainer of that code; I wrote the original version, but
    > it's now maintained by Solarflare.
    >
    > I don't see anything on that line that ought to be architecture-specific.
    > Could you send me the preprocessed efx.c from your powerpc build?


    Apparently, it's a know generic breakage of the topology stuff,
    it's beeing sorted out.

    Cheers,
    Ben.


    --
    To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
    the body of a message to majordomo@vger.kernel.org
    More majordomo info at http://vger.kernel.org/majordomo-info.html
    Please read the FAQ at http://www.tux.org/lkml/

  5. Re: sfx.c driver build failure

    On Fri, 25 Jul 2008, Benjamin Herrenschmidt wrote:
    > The sfx driver (which happens to be part of some of our test configs)
    > fails to build in current Linus tree on powerpc with this error:
    >
    > /home/benh/kernels/linux-powerpc/drivers/net/sfc/efx.c: In function efx_probe_interrupts:
    > /home/benh/kernels/linux-powerpc/drivers/net/sfc/efx.c:845: error: lvaluerequired as unary & oper
    > and


    I'm not the maintainer of that code; I wrote the original version, but
    it's now maintained by Solarflare.

    I don't see anything on that line that ought to be architecture-specific.
    Could you send me the preprocessed efx.c from your powerpc build?

    Michael

+ Reply to Thread