parser: add const to parser token table (resend) - Kernel

This is a discussion on parser: add const to parser token table (resend) - Kernel ; This patch adds a "const" to the parser token table. I've done an allmodconfig build to see if this produces any warnings/failures and the patch includes a fix for the only warning that was produced. Signed-off-by: Steven Whitehouse Acked-by: Alexander ...

+ Reply to Thread
Results 1 to 4 of 4

Thread: parser: add const to parser token table (resend)

  1. parser: add const to parser token table (resend)

    This patch adds a "const" to the parser token table. I've done an
    allmodconfig build to see if this produces any warnings/failures and the
    patch includes a fix for the only warning that was produced.

    Signed-off-by: Steven Whitehouse
    Acked-by: Alexander Viro
    Acked-by: Evgeniy Dushistov

    diff --git a/fs/ufs/super.c b/fs/ufs/super.c
    index 85b22b5..506f724 100644
    --- a/fs/ufs/super.c
    +++ b/fs/ufs/super.c
    @@ -1232,7 +1232,7 @@ static int ufs_show_options(struct seq_file *seq, struct vfsmount *vfs)
    {
    struct ufs_sb_info *sbi = UFS_SB(vfs->mnt_sb);
    unsigned mval = sbi->s_mount_opt & UFS_MOUNT_UFSTYPE;
    - struct match_token *tp = tokens;
    + const struct match_token *tp = tokens;

    while (tp->token != Opt_onerror_panic && tp->token != mval)
    ++tp;
    diff --git a/include/linux/parser.h b/include/linux/parser.h
    index 7dcd050..cc554ca 100644
    --- a/include/linux/parser.h
    +++ b/include/linux/parser.h
    @@ -14,7 +14,7 @@ struct match_token {
    const char *pattern;
    };

    -typedef struct match_token match_table_t[];
    +typedef const struct match_token match_table_t[];

    /* Maximum number of arguments that match_token will find in a pattern */
    enum {MAX_OPT_ARGS = 3};


    --
    To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
    the body of a message to majordomo@vger.kernel.org
    More majordomo info at http://vger.kernel.org/majordomo-info.html
    Please read the FAQ at http://www.tux.org/lkml/

  2. Re: parser: add const to parser token table (resend)


    Btw, the reason I didn't even look at this at first is that there is no
    such thing as a "parser" in the kernel, so I just dismissed the patch as
    being to somebody else (ie a sparse thing).

    Now, if the subject had been something like

    UFS: add const to parser token table

    I would have realized that it was relevant to my interests

    What I'm trying to say is that subject lines matter

    Linus
    --
    To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
    the body of a message to majordomo@vger.kernel.org
    More majordomo info at http://vger.kernel.org/majordomo-info.html
    Please read the FAQ at http://www.tux.org/lkml/

  3. Re: parser: add const to parser token table (resend)



    On Thu, 24 Jul 2008, Linus Torvalds wrote:
    >
    > Btw, the reason I didn't even look at this at first is that there is no
    > such thing as a "parser" in the kernel, so I just dismissed the patch as
    > being to somebody else (ie a sparse thing).


    Just to clarify: there obviously _is_ a "parser", but it's at such a low
    level that tagging by it doesn't much help my mental picture, when there
    are other projects I'm involved with where the "parser" is a much more
    integral and major deal.

    Linus
    --
    To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
    the body of a message to majordomo@vger.kernel.org
    More majordomo info at http://vger.kernel.org/majordomo-info.html
    Please read the FAQ at http://www.tux.org/lkml/

  4. Re: parser: add const to parser token table (resend)

    On Thu, Jul 24, 2008 at 11:48:55AM -0700, Linus Torvalds wrote:
    >
    > Btw, the reason I didn't even look at this at first is that there is no
    > such thing as a "parser" in the kernel,


    Well, there's lib/parser.c and include/linux/parser.h..

    --
    To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
    the body of a message to majordomo@vger.kernel.org
    More majordomo info at http://vger.kernel.org/majordomo-info.html
    Please read the FAQ at http://www.tux.org/lkml/

+ Reply to Thread