latest tree build failure -- cpm uart & gpio - Kernel

This is a discussion on latest tree build failure -- cpm uart & gpio - Kernel ; can someone look at the following compile failure in linus's tree. I'm guessing part of this has to do with Alan's tty changes (and might already be addressed?). include/asm-generic/gpio.h:131: error: implicit declaration of function 'gpio_get_value' include/asm-generic/gpio.h:137: error: implicit declaration of ...

+ Reply to Thread
Results 1 to 7 of 7

Thread: latest tree build failure -- cpm uart & gpio

  1. latest tree build failure -- cpm uart & gpio

    can someone look at the following compile failure in linus's tree.
    I'm guessing part of this has to do with Alan's tty changes (and might
    already be addressed?).

    include/asm-generic/gpio.h:131: error: implicit declaration of
    function 'gpio_get_value'
    include/asm-generic/gpio.h:137: error: implicit declaration of
    function 'gpio_set_value'
    make[4]: *** [drivers/net/fs_enet/fs_enet-main.o] Error 1
    drivers/serial/cpm_uart/cpm_uart_core.c:212: error: 'struct uart_info'
    has no member named 'tty'
    make[4]: *** [drivers/serial/cpm_uart/cpm_uart_core.o] Error 1
    make[3]: *** [drivers/serial/cpm_uart] Error 2
    make[3]: *** [drivers/net/fs_enet] Error 2
    make[2]: *** [drivers/net] Error 2
    make[2]: *** [drivers/serial] Error 2
    make[1]: *** [drivers] Error 2
    make: *** [sub-make] Error 2

    - k
    --
    To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
    the body of a message to majordomo@vger.kernel.org
    More majordomo info at http://vger.kernel.org/majordomo-info.html
    Please read the FAQ at http://www.tux.org/lkml/

  2. Re: latest tree build failure -- cpm uart & gpio

    On Tue, 22 Jul 2008 08:54:16 -0500
    Kumar Gala wrote:

    > can someone look at the following compile failure in linus's tree.
    > I'm guessing part of this has to do with Alan's tty changes (and might
    > already be addressed?).
    >
    > include/asm-generic/gpio.h:131: error: implicit declaration of
    > function 'gpio_get_value'
    > include/asm-generic/gpio.h:137: error: implicit declaration of
    > function 'gpio_set_value'


    These are not

    > make[4]: *** [drivers/net/fs_enet/fs_enet-main.o] Error 1
    > drivers/serial/cpm_uart/cpm_uart_core.c:212: error: 'struct uart_info'
    > has no member named 'tty'


    That one is and hasn't been addressed so I wil do it right now.

    --
    To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
    the body of a message to majordomo@vger.kernel.org
    More majordomo info at http://vger.kernel.org/majordomo-info.html
    Please read the FAQ at http://www.tux.org/lkml/

  3. Re: latest tree build failure -- cpm uart & gpio

    On Tue, Jul 22, 2008 at 08:54:16AM -0500, Kumar Gala wrote:
    > can someone look at the following compile failure in linus's tree. I'm
    > guessing part of this has to do with Alan's tty changes (and might
    > already be addressed?).
    >
    > include/asm-generic/gpio.h:131: error: implicit declaration of function
    > 'gpio_get_value'
    > include/asm-generic/gpio.h:137: error: implicit declaration of function
    > 'gpio_set_value'


    I think this patch should help:

    [OF] of_gpio: should use new header
    http://patchwork.ozlabs.org/linuxppc/patch?id=18750

    David, can you please Ack it? See Benjamin's mail:
    http://ozlabs.org/pipermail/linuxppc...ly/060109.html

    --
    Anton Vorontsov
    email: cbouatmailru@gmail.com
    irc://irc.freenode.net/bd2
    --
    To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
    the body of a message to majordomo@vger.kernel.org
    More majordomo info at http://vger.kernel.org/majordomo-info.html
    Please read the FAQ at http://www.tux.org/lkml/

  4. Re: latest tree build failure -- cpm uart & gpio

    On Tuesday 22 July 2008, Anton Vorontsov wrote:
    > On Tue, Jul 22, 2008 at 08:54:16AM -0500, Kumar Gala wrote:
    > > can someone look at the following compile failure in linus's tree. I'm
    > > guessing part of this has to do with Alan's tty changes (and might
    > > already be addressed?).
    > >
    > > include/asm-generic/gpio.h:131: error: implicit declaration of function
    > > 'gpio_get_value'
    > > include/asm-generic/gpio.h:137: error: implicit declaration of function
    > > 'gpio_set_value'

    >
    > I think this patch should help:
    >
    > [OF] of_gpio: should use new header
    > http://patchwork.ozlabs.org/linuxppc/patch?id=18750


    Is that confirmed as fixing this, vs just being the Right Thing To Do?


    > David, can you please Ack it? See Benjamin's mail:
    > http://ozlabs.org/pipermail/linuxppc...ly/060109.html


    If you like ... but this is an OF-specific change, making
    it conform with the interface spec, so I wouldn't expect
    this to need more approvals than it's already got.

    Acked-by: David Brownell


    >
    > --
    > Anton Vorontsov
    > email: cbouatmailru@gmail.com
    > irc://irc.freenode.net/bd2
    >



    --
    To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
    the body of a message to majordomo@vger.kernel.org
    More majordomo info at http://vger.kernel.org/majordomo-info.html
    Please read the FAQ at http://www.tux.org/lkml/

  5. Re: latest tree build failure -- cpm uart & gpio

    On Tue, Jul 22, 2008 at 12:33:16PM -0700, David Brownell wrote:
    > On Tuesday 22 July 2008, Anton Vorontsov wrote:
    > > On Tue, Jul 22, 2008 at 08:54:16AM -0500, Kumar Gala wrote:
    > > > can someone look at the following compile failure in linus's tree. I'm
    > > > guessing part of this has to do with Alan's tty changes (and might
    > > > already be addressed?).
    > > >
    > > > include/asm-generic/gpio.h:131: error: implicit declaration of function
    > > > 'gpio_get_value'
    > > > include/asm-generic/gpio.h:137: error: implicit declaration of function
    > > > 'gpio_set_value'

    > >
    > > I think this patch should help:
    > >
    > > [OF] of_gpio: should use new header
    > > http://patchwork.ozlabs.org/linuxppc/patch?id=18750

    >
    > Is that confirmed as fixing this, vs just being the Right Thing To Do?


    Just applied the patch locally and the issue is not reproducible
    anymore.

    > > David, can you please Ack it? See Benjamin's mail:
    > > http://ozlabs.org/pipermail/linuxppc...ly/060109.html

    >
    > If you like ... but this is an OF-specific change, making
    > it conform with the interface spec, so I wouldn't expect
    > this to need more approvals than it's already got.
    >
    > Acked-by: David Brownell


    Thanks.

    --
    Anton Vorontsov
    email: cbouatmailru@gmail.com
    irc://irc.freenode.net/bd2
    --
    To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
    the body of a message to majordomo@vger.kernel.org
    More majordomo info at http://vger.kernel.org/majordomo-info.html
    Please read the FAQ at http://www.tux.org/lkml/

  6. Re: latest tree build failure -- cpm uart & gpio

    On Tue, 2008-07-22 at 18:53 +0400, Anton Vorontsov wrote:
    > On Tue, Jul 22, 2008 at 08:54:16AM -0500, Kumar Gala wrote:
    > > can someone look at the following compile failure in linus's tree. I'm
    > > guessing part of this has to do with Alan's tty changes (and might
    > > already be addressed?).
    > >
    > > include/asm-generic/gpio.h:131: error: implicit declaration of function
    > > 'gpio_get_value'
    > > include/asm-generic/gpio.h:137: error: implicit declaration of function
    > > 'gpio_set_value'

    >
    > I think this patch should help:
    >
    > [OF] of_gpio: should use new header
    > http://patchwork.ozlabs.org/linuxppc/patch?id=18750
    >
    > David, can you please Ack it? See Benjamin's mail:
    > http://ozlabs.org/pipermail/linuxppc...ly/060109.html
    >


    Hrm.. I though I had that one in my latest batch. In fact, I just
    checked and it got merged.

    Ben.


    --
    To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
    the body of a message to majordomo@vger.kernel.org
    More majordomo info at http://vger.kernel.org/majordomo-info.html
    Please read the FAQ at http://www.tux.org/lkml/

  7. Re: latest tree build failure -- cpm uart & gpio

    On Wed, Jul 23, 2008 at 08:05:09AM +1000, Benjamin Herrenschmidt wrote:
    > On Tue, 2008-07-22 at 18:53 +0400, Anton Vorontsov wrote:
    > > On Tue, Jul 22, 2008 at 08:54:16AM -0500, Kumar Gala wrote:
    > > > can someone look at the following compile failure in linus's tree. I'm
    > > > guessing part of this has to do with Alan's tty changes (and might
    > > > already be addressed?).
    > > >
    > > > include/asm-generic/gpio.h:131: error: implicit declaration of function
    > > > 'gpio_get_value'
    > > > include/asm-generic/gpio.h:137: error: implicit declaration of function
    > > > 'gpio_set_value'

    > >
    > > I think this patch should help:
    > >
    > > [OF] of_gpio: should use new header
    > > http://patchwork.ozlabs.org/linuxppc/patch?id=18750
    > >
    > > David, can you please Ack it? See Benjamin's mail:
    > > http://ozlabs.org/pipermail/linuxppc...ly/060109.html
    > >

    >
    > Hrm.. I though I had that one in my latest batch. In fact, I just
    > checked and it got merged.


    Ah, great. So the issue should be fixed already... I just pulled the
    Linus' tree, and it is there indeed.

    Thanks,

    --
    Anton Vorontsov
    email: cbouatmailru@gmail.com
    irc://irc.freenode.net/bd2
    --
    To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
    the body of a message to majordomo@vger.kernel.org
    More majordomo info at http://vger.kernel.org/majordomo-info.html
    Please read the FAQ at http://www.tux.org/lkml/

+ Reply to Thread