[Patch] um: fix a build error - Kernel

This is a discussion on [Patch] um: fix a build error - Kernel ; Fixed this build error: /home/wangcong/Projects/linux-2.6/arch/um/drivers/line.c: In function ‘line_write_interrupt’: /home/wangcong/Projects/linux-2.6/arch/um/drivers/line.c:366: error: ‘struct tty_ldisc’ has no member named ‘write_wakeup’ /home/wangcong/Projects/linux-2.6/arch/um/drivers/line.c:367: error: ‘struct tty_ldisc’ has no member named ‘write_wakeup’ make[2]: *** [arch/um/drivers/line.o] Error 1 make[1]: *** [arch/um/drivers] Error 2 make: *** [sub-make] Error ...

+ Reply to Thread
Results 1 to 2 of 2

Thread: [Patch] um: fix a build error

  1. [Patch] um: fix a build error


    Fixed this build error:

    /home/wangcong/Projects/linux-2.6/arch/um/drivers/line.c: In function
    ‘line_write_interrupt’:
    /home/wangcong/Projects/linux-2.6/arch/um/drivers/line.c:366: error:
    ‘struct tty_ldisc’ has no member named ‘write_wakeup’
    /home/wangcong/Projects/linux-2.6/arch/um/drivers/line.c:367: error:
    ‘struct tty_ldisc’ has no member named ‘write_wakeup’
    make[2]: *** [arch/um/drivers/line.o] Error 1
    make[1]: *** [arch/um/drivers] Error 2
    make: *** [sub-make] Error 2

    Sigend-off-by: WANG Cong
    Cc: jdike@addtoit.com

    ---
    diff --git a/arch/um/drivers/line.c b/arch/um/drivers/line.c
    index 5047490..c872dad 100644
    --- a/arch/um/drivers/line.c
    +++ b/arch/um/drivers/line.c
    @@ -363,8 +363,8 @@ static irqreturn_t line_write_interrupt(int irq, void *data)
    return IRQ_NONE;

    if (test_bit(TTY_DO_WRITE_WAKEUP, &tty->flags) &&
    - (tty->ldisc.write_wakeup != NULL))
    - (tty->ldisc.write_wakeup)(tty);
    + (tty->ldisc.ops->write_wakeup != NULL))
    + (tty->ldisc.ops->write_wakeup)(tty);

    /*
    * BLOCKING mode
    --
    To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
    the body of a message to majordomo@vger.kernel.org
    More majordomo info at http://vger.kernel.org/majordomo-info.html
    Please read the FAQ at http://www.tux.org/lkml/

  2. Re: [Patch] um: fix a build error

    On Mon, 21 Jul 2008 17:54:09 +0100
    WANG Cong wrote:

    >
    > Fixed this build error:
    >
    > /home/wangcong/Projects/linux-2.6/arch/um/drivers/line.c: In function
    > ‘line_write_interrupt’:
    > /home/wangcong/Projects/linux-2.6/arch/um/drivers/line.c:366: error:
    > ‘struct tty_ldisc’ has no member named ‘write_wakeup’
    > /home/wangcong/Projects/linux-2.6/arch/um/drivers/line.c:367: error:
    > ‘struct tty_ldisc’ has no member named ‘write_wakeup’
    > make[2]: *** [arch/um/drivers/line.o] Error 1
    > make[1]: *** [arch/um/drivers] Error 2
    > make: *** [sub-make] Error 2
    >
    > Sigend-off-by: WANG Cong


    NAK - drivers shouldn't be poking around in tty innards in the first
    place then this wouldn't break. Use tty_wakeup(tty); insteaad

    Alan
    --
    To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
    the body of a message to majordomo@vger.kernel.org
    More majordomo info at http://vger.kernel.org/majordomo-info.html
    Please read the FAQ at http://www.tux.org/lkml/

+ Reply to Thread