[PATCH] x86,pci: dmi check for mackpro 2.2 mmconf - Kernel

This is a discussion on [PATCH] x86,pci: dmi check for mackpro 2.2 mmconf - Kernel ; On Fri, Jul 18, 2008 at 10:12 PM, Jack Howarth wrote: > Would that imply that this might be more fallout of the BIOS bug in the > MacBook Pro where insufficient address space is reserved for the number of ...

+ Reply to Thread
Page 2 of 2 FirstFirst 1 2
Results 21 to 31 of 31

Thread: [PATCH] x86,pci: dmi check for mackpro 2.2 mmconf

  1. Re: [PATCH] x86,pci: dmi check for mackpro 2.2 mmconf

    On Fri, Jul 18, 2008 at 10:12 PM, Jack Howarth
    wrote:
    > Would that imply that this might be more fallout of the BIOS bug in the
    > MacBook Pro where insufficient address space is reserved for the number of
    > buses claimed?


    that is good enough with 64 buses like laptop.

    > Is there some point in the PCIEASPM based code where you
    > could duplicate the same sort of fix? I would be happy to test any debug
    > patches that might help pinpoint where such a fix is needed.


    Jesse, who is maintainer for ASPM code?

    YH
    --
    To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
    the body of a message to majordomo@vger.kernel.org
    More majordomo info at http://vger.kernel.org/majordomo-info.html
    Please read the FAQ at http://www.tux.org/lkml/

  2. [PATCH] x86,pci: detect end_bus_number according to acpi/e820 reserved - fix


    Signed-off-by: Yinghai Lu

    diff --git a/arch/x86/pci/mmconfig-shared.c b/arch/x86/pci/mmconfig-shared.c
    index 9297882..429c701 100644
    --- a/arch/x86/pci/mmconfig-shared.c
    +++ b/arch/x86/pci/mmconfig-shared.c
    @@ -364,6 +364,7 @@ static void __init pci_mmcfg_reject_broken(int early)
    cfg = &pci_mmcfg_config[i];
    addr = cfg->start_bus_number;
    addr <<= 20;
    + addr += cfg->address;
    size = cfg->end_bus_number + 1 - cfg->start_bus_number;
    size <<= 20;
    printk(KERN_NOTICE "PCI: MCFG configuration %d: base %lx "
    --
    To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
    the body of a message to majordomo@vger.kernel.org
    More majordomo info at http://vger.kernel.org/majordomo-info.html
    Please read the FAQ at http://www.tux.org/lkml/

  3. Re: [PATCH] x86,pci: dmi check for mackpro 2.2 mmconf

    On Friday, July 18, 2008 10:28 pm Yinghai Lu wrote:
    > On Fri, Jul 18, 2008 at 10:12 PM, Jack Howarth
    >
    > wrote:
    > > Would that imply that this might be more fallout of the BIOS bug in the
    > > MacBook Pro where insufficient address space is reserved for the number
    > > of buses claimed?

    >
    > that is good enough with 64 buses like laptop.
    >
    > > Is there some point in the PCIEASPM based code where you
    > > could duplicate the same sort of fix? I would be happy to test any debug
    > > patches that might help pinpoint where such a fix is needed.

    >
    > Jesse, who is maintainer for ASPM code?


    I've been looking to Shaohua (cc'd) for ASPM stuff.

    Jesse
    --
    To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
    the body of a message to majordomo@vger.kernel.org
    More majordomo info at http://vger.kernel.org/majordomo-info.html
    Please read the FAQ at http://www.tux.org/lkml/

  4. Re: [PATCH] x86,pci: dmi check for mackpro 2.2 mmconf

    On Sat, Jul 19, 2008 at 10:26:02AM -0700, Jesse Barnes wrote:
    > On Friday, July 18, 2008 10:28 pm Yinghai Lu wrote:
    > > On Fri, Jul 18, 2008 at 10:12 PM, Jack Howarth
    > >
    > > wrote:
    > > > Would that imply that this might be more fallout of the BIOS bug in the
    > > > MacBook Pro where insufficient address space is reserved for the number
    > > > of buses claimed?

    > >
    > > that is good enough with 64 buses like laptop.
    > >
    > > > Is there some point in the PCIEASPM based code where you
    > > > could duplicate the same sort of fix? I would be happy to test any debug
    > > > patches that might help pinpoint where such a fix is needed.

    > >
    > > Jesse, who is maintainer for ASPM code?

    >
    > I've been looking to Shaohua (cc'd) for ASPM stuff.
    >
    > Jesse


    Jesse,
    I have just tried tip with CONFIG_PCIEASPM and I get the same hang as always.
    I am currently using 'debug initcall_debug' as I can only see a limited number of
    lines on my screen. These show...

    PCI: 0000:00:1d.7 reg 10 32bit mmio: [d840500, d84057ff]
    pci: 0000:00:1d.7 PME# supported from D0 D3hot D3cold
    pci: 0000:00:1d.7 PME# disabled
    pci: 0000:00:1f.0 quirk: region 0400-047f claimed by ICH6 ACPI/GPIO/TCO
    pci: 0000:00:1f.0 quirk: region 0500-053f claimed by ICH6 GPIO
    PCI: 0000:00:1f.1 reg 10 io port: [40d8,40df]
    PCI: 0000:00:1f.1 reg 14 io port: [40ec,40ef]
    PCI: 0000:00:1f.1 reg 18 io port: [40d0,40d7]
    PCI: 0000:00:1f.1 reg 1c io port: [40e8,40eb]
    PCI: 0000:00:1f.1 reg 20 io port: [40b0,40bf]
    PCI: 0000:00:1f.2 reg 10 io port: [40c8,40cf]
    PCI: 0000:00:1f.2 reg 14 io port: [40e4,40e7]
    PCI: 0000:00:1f.2 reg 18 io port: [40c0,40c7]
    PCI: 0000:00:1f.2 reg 1c io port: [40e0,40e3]
    PCI: 0000:00:1f.2 reg 20 io port: [40a0,40af]
    PCI: 0000:00:1f.2 reg 24 32bit mmio: [d8405000,d84053ff]
    pci: 0000:00:1f.2 PME# supported from D3hot
    pci: 0000:00:1f.2 PME# disabled
    PCI: 0000:00:1f.3 reg 20 io port [efa0,efbf]
    PCI: 0000:01:00.0 reg 10 32bit mmio: [c0000000,cfffffff]
    PCI: 0000:01:00.0 reg 14 io port: [3000,30ff]
    PCI: 0000:01:00.0 reg 18 32bit mmio: [d8300000,d830ffff]
    pci: 0000:01:00.0 : supports D1
    pci: 0000:01:00.0 : supports D2

    ....at which point the machine freezes. If I boot tip with quiet, I happen to
    see the message...

    ACPI: EC: GPE Storm detected, disabling EC GPE

    which I never haven't seen with 2.6.26 built without PCIEASPM. I also
    have CONFIG_PCIEASPM_DEBUG set. What options to have have to pass to the
    kernel when booting to cause that feature to spew useful info?
    Jack
    --
    To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
    the body of a message to majordomo@vger.kernel.org
    More majordomo info at http://vger.kernel.org/majordomo-info.html
    Please read the FAQ at http://www.tux.org/lkml/

  5. Re: [PATCH] x86,pci: dmi check for mackpro 2.2 mmconf

    Jesse,
    It seems that MacBook Pro users aren't the only ones suffering from
    PCIE_ASPM...

    http://groups.google.com/group/linux...de7f0?lnk=raot

    I also discovered the pcie_noaspm kernel option from that thread which
    allows me to boot the kernels built with PCIE_ASPM support by disabling
    that feature.
    Jack
    --
    To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
    the body of a message to majordomo@vger.kernel.org
    More majordomo info at http://vger.kernel.org/majordomo-info.html
    Please read the FAQ at http://www.tux.org/lkml/

  6. Re: [PATCH] x86,pci: dmi check for mackpro 2.2 mmconf

    On Saturday, July 19, 2008 11:40 am Jack Howarth wrote:
    > Jesse,
    > It seems that MacBook Pro users aren't the only ones suffering from
    > PCIE_ASPM...
    >
    > http://groups.google.com/group/linux...ead/cc1b8b3ef6
    >4e3257/dd4e427510bde7f0?lnk=raot
    >
    > I also discovered the pcie_noaspm kernel option from that thread which
    > allows me to boot the kernels built with PCIE_ASPM support by disabling
    > that feature.


    Yeah, that's a good data point. Thanks. Sounds like there may also be some
    ACPI interaction going on...

    Jesse
    --
    To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
    the body of a message to majordomo@vger.kernel.org
    More majordomo info at http://vger.kernel.org/majordomo-info.html
    Please read the FAQ at http://www.tux.org/lkml/

  7. Re: [PATCH] x86,pci: dmi check for mackpro 2.2 mmconf

    On Sat, Jul 19, 2008 at 12:04:48PM -0700, Jesse Barnes wrote:
    > On Saturday, July 19, 2008 11:40 am Jack Howarth wrote:
    > > Jesse,
    > > It seems that MacBook Pro users aren't the only ones suffering from
    > > PCIE_ASPM...
    > >
    > > http://groups.google.com/group/linux...ead/cc1b8b3ef6
    > >4e3257/dd4e427510bde7f0?lnk=raot
    > >
    > > I also discovered the pcie_noaspm kernel option from that thread which
    > > allows me to boot the kernels built with PCIE_ASPM support by disabling
    > > that feature.

    >
    > Yeah, that's a good data point. Thanks. Sounds like there may also be some
    > ACPI interaction going on...
    >
    > Jesse


    Jesse,
    For what its worth, acpi=off alone is insufficent to inhibit the
    kernel freezes when PCIE aspm is in use.
    Jack
    --
    To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
    the body of a message to majordomo@vger.kernel.org
    More majordomo info at http://vger.kernel.org/majordomo-info.html
    Please read the FAQ at http://www.tux.org/lkml/

  8. Re: [PATCH] x86,pci: detect end_bus_number according to acpi/e820 reserved - fix


    * Yinghai Lu wrote:

    > Signed-off-by: Yinghai Lu


    applied to tip/pci-for-jesse and folded into "x86, pci: detect
    end_bus_number according to acpi/e820 reserved", thanks Yinghai.

    Ingo
    --
    To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
    the body of a message to majordomo@vger.kernel.org
    More majordomo info at http://vger.kernel.org/majordomo-info.html
    Please read the FAQ at http://www.tux.org/lkml/

  9. Re: [PATCH] x86,pci: detect end_bus_number according to acpi/e820 reserved


    * Jesse Barnes wrote:

    > On Friday, July 18, 2008 3:27 pm Yinghai Lu wrote:
    > > On Fri, Jul 18, 2008 at 2:48 PM, Jack Howarth

    > wrote:
    > > > YH,
    > > > I'll test the new patch shortly. When I do, I'll put back in
    > > > your debug patches to try to get a complete log with pci=verbose
    > > > and initcall_debug with PCIEASPM disabled.

    > >
    > > tip tree has the two debug patches.
    > >
    > > > Hopefully the probing
    > > > is done in the same general fashion with and without PCIEASPM so
    > > > we can deduce what exactly is being probed when my MacBook Pro
    > > > freezes during boot with PCIEASPM enabled. I consider the fact
    > > > that booting 2.6.26 always freezes the kernel when PCIEASPM
    > > > is enabled to be the more serious bug (since once Fedora ships
    > > > 2.6.26 kernels I'll be stuck always building my own).

    > >
    > > another laptop : Acer ... suffer this problem too with ASPM...

    >
    > Yeah, looks like we'll have to be more conservative about enabling
    > ASPM. Maybe a whitelist approach would be better...


    all my testsystems boot fine with it. Maybe a blacklist?

    Ingo
    --
    To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
    the body of a message to majordomo@vger.kernel.org
    More majordomo info at http://vger.kernel.org/majordomo-info.html
    Please read the FAQ at http://www.tux.org/lkml/

  10. Re: [PATCH] x86,pci: dmi check for mackpro 2.2 mmconf

    On Sat, 2008-07-19 at 15:14 -0400, Jack Howarth wrote:
    > On Sat, Jul 19, 2008 at 12:04:48PM -0700, Jesse Barnes wrote:
    > > On Saturday, July 19, 2008 11:40 am Jack Howarth wrote:
    > > > Jesse,
    > > > It seems that MacBook Pro users aren't the only ones suffering from
    > > > PCIE_ASPM...
    > > >
    > > > http://groups.google.com/group/linux...ead/cc1b8b3ef6
    > > >4e3257/dd4e427510bde7f0?lnk=raot
    > > >
    > > > I also discovered the pcie_noaspm kernel option from that thread which
    > > > allows me to boot the kernels built with PCIE_ASPM support by disabling
    > > > that feature.

    > >
    > > Yeah, that's a good data point. Thanks. Sounds like there may also be some
    > > ACPI interaction going on...
    > >
    > > Jesse

    >
    > Jesse,
    > For what its worth, acpi=off alone is insufficent to inhibit the
    > kernel freezes when PCIE aspm is in use.

    As Jesse suggested, maybe we should blacklist all pcie pre-1.1 devices.
    please try.

    Thanks,
    Shaohua
    ---
    drivers/pci/pcie/aspm.c | 10 ++++++++++
    include/linux/pci_regs.h | 1 +
    2 files changed, 11 insertions(+)

    Index: linux/drivers/pci/pcie/aspm.c
    ================================================== =================
    --- linux.orig/drivers/pci/pcie/aspm.c 2008-07-21 14:12:16.000000000 +0800
    +++ linux/drivers/pci/pcie/aspm.c 2008-07-21 14:46:24.000000000 +0800
    @@ -510,6 +510,7 @@ static int pcie_aspm_sanity_check(struct
    {
    struct pci_dev *child_dev;
    int child_pos;
    + u32 reg32;

    /*
    * Some functions in a slot might not all be PCIE functions, very
    @@ -519,6 +520,15 @@ static int pcie_aspm_sanity_check(struct
    child_pos = pci_find_capability(child_dev, PCI_CAP_ID_EXP);
    if (!child_pos)
    return -EINVAL;
    +
    + /*
    + * Disable ASPM for pre-1.1 PCIe device, we follow MS to use
    + * RBER bit to determine if a function is 1.1 version device
    + */
    + pci_read_config_dword(child_dev, child_pos + PCI_EXP_DEVCAP,
    + &reg32);
    + if (!(reg32 & PCI_EXP_DEVCAP_RBER))
    + return -EINVAL;
    }
    return 0;
    }
    Index: linux/include/linux/pci_regs.h
    ================================================== =================
    --- linux.orig/include/linux/pci_regs.h 2008-07-21 14:25:05.000000000 +0800
    +++ linux/include/linux/pci_regs.h 2008-07-21 14:27:00.000000000 +0800
    @@ -374,6 +374,7 @@
    #define PCI_EXP_DEVCAP_ATN_BUT 0x1000 /* Attention Button Present */
    #define PCI_EXP_DEVCAP_ATN_IND 0x2000 /* Attention Indicator Present */
    #define PCI_EXP_DEVCAP_PWR_IND 0x4000 /* Power Indicator Present */
    +#define PCI_EXP_DEVCAP_RBER 0x8000 /* Role-Based Error Reporting */
    #define PCI_EXP_DEVCAP_PWR_VAL 0x3fc0000 /* Slot Power Limit Value */
    #define PCI_EXP_DEVCAP_PWR_SCL 0xc000000 /* Slot Power Limit Scale */
    #define PCI_EXP_DEVCTL 8 /* Device Control */


    --
    To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
    the body of a message to majordomo@vger.kernel.org
    More majordomo info at http://vger.kernel.org/majordomo-info.html
    Please read the FAQ at http://www.tux.org/lkml/

  11. Re: [PATCH] x86,pci: dmi check for mackpro 2.2 mmconf

    On Sunday, July 20, 2008 11:49 pm Shaohua Li wrote:
    > On Sat, 2008-07-19 at 15:14 -0400, Jack Howarth wrote:
    > > On Sat, Jul 19, 2008 at 12:04:48PM -0700, Jesse Barnes wrote:
    > > > On Saturday, July 19, 2008 11:40 am Jack Howarth wrote:
    > > > > Jesse,
    > > > > It seems that MacBook Pro users aren't the only ones suffering
    > > > > from PCIE_ASPM...
    > > > >
    > > > > http://groups.google.com/group/linux...ad/thread/cc1b
    > > > >8b3ef6 4e3257/dd4e427510bde7f0?lnk=raot
    > > > >
    > > > > I also discovered the pcie_noaspm kernel option from that thread
    > > > > which allows me to boot the kernels built with PCIE_ASPM support by
    > > > > disabling that feature.
    > > >
    > > > Yeah, that's a good data point. Thanks. Sounds like there may also be
    > > > some ACPI interaction going on...
    > > >
    > > > Jesse

    > >
    > > Jesse,
    > > For what its worth, acpi=off alone is insufficent to inhibit the
    > > kernel freezes when PCIE aspm is in use.

    >
    > As Jesse suggested, maybe we should blacklist all pcie pre-1.1 devices.
    > please try.


    Jack, did this work for you? I'm thinking of pushing this but want to make
    sure it actually solves your problem first.

    Thanks,
    Jesse
    --
    To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
    the body of a message to majordomo@vger.kernel.org
    More majordomo info at http://vger.kernel.org/majordomo-info.html
    Please read the FAQ at http://www.tux.org/lkml/

+ Reply to Thread
Page 2 of 2 FirstFirst 1 2