[PATCH] nf_nat_snmp_basic: fix compiler warning on 64-bit arch-s - Kernel

This is a discussion on [PATCH] nf_nat_snmp_basic: fix compiler warning on 64-bit arch-s - Kernel ; Signed-off-by: Jan Beulich --- net/ipv4/netfilter/nf_nat_snmp_basic.c | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) --- linux-2.6.26/net/ipv4/netfilter/nf_nat_snmp_basic.c 2008-07-13 23:51:29.000000000 +0200 +++ 2.6.26-netfilter-warning/net/ipv4/netfilter/nf_nat_snmp_basic.c 2008-07-15 14:51:28.000000000 +0200 @@ -445,7 +445,7 @@ static unsigned char asn1_oid_decode(str size = eoc - ctx->pointer + 1; ...

+ Reply to Thread
Results 1 to 2 of 2

Thread: [PATCH] nf_nat_snmp_basic: fix compiler warning on 64-bit arch-s

  1. [PATCH] nf_nat_snmp_basic: fix compiler warning on 64-bit arch-s

    Signed-off-by: Jan Beulich

    ---
    net/ipv4/netfilter/nf_nat_snmp_basic.c | 2 +-
    1 file changed, 1 insertion(+), 1 deletion(-)

    --- linux-2.6.26/net/ipv4/netfilter/nf_nat_snmp_basic.c 2008-07-13 23:51:29.000000000 +0200
    +++ 2.6.26-netfilter-warning/net/ipv4/netfilter/nf_nat_snmp_basic.c 2008-07-15 14:51:28.000000000 +0200
    @@ -445,7 +445,7 @@ static unsigned char asn1_oid_decode(str
    size = eoc - ctx->pointer + 1;

    /* first subid actually encodes first two subids */
    - if (size < 2 || size > ULONG_MAX/sizeof(unsigned long))
    + if (size < 2 || size > UINT_MAX/sizeof(unsigned long))
    return 0;

    *oid = kmalloc(size * sizeof(unsigned long), GFP_ATOMIC);



    --
    To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
    the body of a message to majordomo@vger.kernel.org
    More majordomo info at http://vger.kernel.org/majordomo-info.html
    Please read the FAQ at http://www.tux.org/lkml/

  2. Re: [PATCH] nf_nat_snmp_basic: fix compiler warning on 64-bit arch-s

    Jan Beulich wrote:
    > Signed-off-by: Jan Beulich
    >
    > ---
    > net/ipv4/netfilter/nf_nat_snmp_basic.c | 2 +-
    > 1 file changed, 1 insertion(+), 1 deletion(-)
    >
    > --- linux-2.6.26/net/ipv4/netfilter/nf_nat_snmp_basic.c 2008-07-13 23:51:29.000000000 +0200
    > +++ 2.6.26-netfilter-warning/net/ipv4/netfilter/nf_nat_snmp_basic.c 2008-07-15 14:51:28.000000000 +0200
    > @@ -445,7 +445,7 @@ static unsigned char asn1_oid_decode(str
    > size = eoc - ctx->pointer + 1;
    >
    > /* first subid actually encodes first two subids */
    > - if (size < 2 || size > ULONG_MAX/sizeof(unsigned long))
    > + if (size < 2 || size > UINT_MAX/sizeof(unsigned long))


    Thanks, I already have a similar fix queued.
    --
    To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
    the body of a message to majordomo@vger.kernel.org
    More majordomo info at http://vger.kernel.org/majordomo-info.html
    Please read the FAQ at http://www.tux.org/lkml/

+ Reply to Thread