[PATCH] x86: APIC: Remove apic_write_around(); use alternatives - Kernel

This is a discussion on [PATCH] x86: APIC: Remove apic_write_around(); use alternatives - Kernel ; * Ingo Molnar wrote: > i've merged tip/x86/x2apic into tip/master, and it seems to be working > fine. One UP build fix was needed for Xen, see below. and a similar one for UP lguest. Ingo ----------------> commit 7be42004065ce4df193aeef5befd26805267d0d9 Author: ...

+ Reply to Thread
Page 2 of 2 FirstFirst 1 2
Results 21 to 24 of 24

Thread: [PATCH] x86: APIC: Remove apic_write_around(); use alternatives

  1. Re: [PATCH] x86: APIC: Remove apic_write_around(); use alternatives


    * Ingo Molnar wrote:

    > i've merged tip/x86/x2apic into tip/master, and it seems to be working
    > fine. One UP build fix was needed for Xen, see below.


    and a similar one for UP lguest.

    Ingo

    ---------------->
    commit 7be42004065ce4df193aeef5befd26805267d0d9
    Author: Ingo Molnar
    Date: Sun Jul 20 17:04:57 2008 +0200

    x86, lguest: fix apic_ops build on UP

    fix:

    arch/x86/lguest/boot.c:816: error: variable ‘lguest_basic_apic_ops’ has initializer but incomplete type
    arch/x86/lguest/boot.c:817: error: unknown field ‘read’ specified in initializer
    [...]

    Signed-off-by: Ingo Molnar
    ---
    arch/x86/lguest/boot.c | 1 +
    1 files changed, 1 insertions(+), 0 deletions(-)

    diff --git a/arch/x86/lguest/boot.c b/arch/x86/lguest/boot.c
    index 35c4349..756fc48 100644
    --- a/arch/x86/lguest/boot.c
    +++ b/arch/x86/lguest/boot.c
    @@ -55,6 +55,7 @@
    #include
    #include
    #include
    +#include
    #include
    #include
    #include
    --
    To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
    the body of a message to majordomo@vger.kernel.org
    More majordomo info at http://vger.kernel.org/majordomo-info.html
    Please read the FAQ at http://www.tux.org/lkml/

  2. Re: [PATCH] x86: APIC: Remove apic_write_around(); use alternatives

    On Sun, Jul 20, 2008 at 05:08:11AM -0700, Ingo Molnar wrote:
    >
    > i've merged tip/x86/x2apic into tip/master, and it seems to be working
    > fine. One UP build fix was needed for Xen, see below.


    Thanks Ingo. I tested tip/master and found an issue (patch attached)
    for x2apic support. This is not because of the recent merges we had, but
    because of something(where we still access memory based interface after
    enabling x2apic mode) that slipped through my earlier tests.

    Probably it is a good idea to unmap the memory mapped interface, once we switch
    to x2apic mode. That will catch the issues much earlier. I will
    post another patch for this.

    Meanwhile, I will do more testing of tip/master along with addressing
    open issues.
    ---

    [patch] x64, apic: use generic apic_write() for ack_APIC_irq()

    ack_APIC_irq() is used at too many generic places (and not just during
    irq_chip handling!) to use the native_apic_mem_write(). For ex, this will
    break x2apic based systems.

    Fix ack_APIC_irq() to use the generic apic_write() even for 64-bit.

    Signed-off-by: Suresh Siddha
    ---

    diff --git a/include/asm-x86/apic.h b/include/asm-x86/apic.h
    index 300b65e..1df955f 100644
    --- a/include/asm-x86/apic.h
    +++ b/include/asm-x86/apic.h
    @@ -138,11 +138,7 @@ static inline void ack_APIC_irq(void)
    */

    /* Docs say use 0 for future compatibility */
    -#ifdef CONFIG_X86_32
    apic_write(APIC_EOI, 0);
    -#else
    - native_apic_mem_write(APIC_EOI, 0);
    -#endif
    }

    extern int lapic_get_maxlvt(void);
    --
    To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
    the body of a message to majordomo@vger.kernel.org
    More majordomo info at http://vger.kernel.org/majordomo-info.html
    Please read the FAQ at http://www.tux.org/lkml/

  3. Re: [PATCH] x86: APIC: Remove apic_write_around(); use alternatives

    On Mon, Jul 21, 2008 at 10:59:41AM -0700, Suresh Siddha wrote:
    > Thanks Ingo. I tested tip/master and found an issue (patch attached)
    > for x2apic support. This is not because of the recent merges we had, but
    > because of something(where we still access memory based interface after
    > enabling x2apic mode) that slipped through my earlier tests.
    >
    > Probably it is a good idea to unmap the memory mapped interface, once we switch
    > to x2apic mode. That will catch the issues much earlier. I will
    > post another patch for this.
    >
    > Meanwhile, I will do more testing of tip/master along with addressing
    > open issues.
    > ---
    >
    > [patch] x64, apic: use generic apic_write() for ack_APIC_irq()
    >
    > ack_APIC_irq() is used at too many generic places (and not just during
    > irq_chip handling!) to use the native_apic_mem_write(). For ex, this will
    > break x2apic based systems.
    >
    > Fix ack_APIC_irq() to use the generic apic_write() even for 64-bit.
    >
    > Signed-off-by: Suresh Siddha
    > ---
    >
    > diff --git a/include/asm-x86/apic.h b/include/asm-x86/apic.h
    > index 300b65e..1df955f 100644
    > --- a/include/asm-x86/apic.h
    > +++ b/include/asm-x86/apic.h
    > @@ -138,11 +138,7 @@ static inline void ack_APIC_irq(void)
    > */
    >
    > /* Docs say use 0 for future compatibility */
    > -#ifdef CONFIG_X86_32
    > apic_write(APIC_EOI, 0);
    > -#else
    > - native_apic_mem_write(APIC_EOI, 0);
    > -#endif
    > }
    >


    ACK. I tested this patch on my x2apic capable box and it works well. Without this patch, kernel built from tip/x86/x2apic cannot boot in x2apic mode and all APs got stuck in smp_callin->calibrate_delay and failed to boot. After applying this patch, system boots well and all processors got up and running successfully.
    --
    To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
    the body of a message to majordomo@vger.kernel.org
    More majordomo info at http://vger.kernel.org/majordomo-info.html
    Please read the FAQ at http://www.tux.org/lkml/

  4. Re: [PATCH] x86: APIC: Remove apic_write_around(); use alternatives


    * Yong Wang wrote:

    > On Mon, Jul 21, 2008 at 10:59:41AM -0700, Suresh Siddha wrote:
    > > Thanks Ingo. I tested tip/master and found an issue (patch attached)
    > > for x2apic support. This is not because of the recent merges we had, but
    > > because of something(where we still access memory based interface after
    > > enabling x2apic mode) that slipped through my earlier tests.
    > >
    > > Probably it is a good idea to unmap the memory mapped interface, once we switch
    > > to x2apic mode. That will catch the issues much earlier. I will
    > > post another patch for this.
    > >
    > > Meanwhile, I will do more testing of tip/master along with addressing
    > > open issues.
    > > ---
    > >
    > > [patch] x64, apic: use generic apic_write() for ack_APIC_irq()
    > >
    > > ack_APIC_irq() is used at too many generic places (and not just during
    > > irq_chip handling!) to use the native_apic_mem_write(). For ex, this will
    > > break x2apic based systems.
    > >
    > > Fix ack_APIC_irq() to use the generic apic_write() even for 64-bit.
    > >
    > > Signed-off-by: Suresh Siddha
    > > ---
    > >
    > > diff --git a/include/asm-x86/apic.h b/include/asm-x86/apic.h
    > > index 300b65e..1df955f 100644
    > > --- a/include/asm-x86/apic.h
    > > +++ b/include/asm-x86/apic.h
    > > @@ -138,11 +138,7 @@ static inline void ack_APIC_irq(void)
    > > */
    > >
    > > /* Docs say use 0 for future compatibility */
    > > -#ifdef CONFIG_X86_32
    > > apic_write(APIC_EOI, 0);
    > > -#else
    > > - native_apic_mem_write(APIC_EOI, 0);
    > > -#endif
    > > }
    > >

    >
    > ACK. I tested this patch on my x2apic capable box and it works well.
    > Without this patch, kernel built from tip/x86/x2apic cannot boot in
    > x2apic mode and all APs got stuck in smp_callin->calibrate_delay and
    > failed to boot. After applying this patch, system boots well and all
    > processors got up and running successfully.


    hm, i havent received any email from Suresh since:

    Date: Fri, 18 Jul 2008 16:18:28 -0700

    something's broken in the email path ...

    Could you please bounce Suresh's patch to me? (the quoted one above is
    whitespace damaged due to the reply)

    Ingo

    --
    To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
    the body of a message to majordomo@vger.kernel.org
    More majordomo info at http://vger.kernel.org/majordomo-info.html
    Please read the FAQ at http://www.tux.org/lkml/

+ Reply to Thread
Page 2 of 2 FirstFirst 1 2