[mmotm] relay: fix build error - Kernel

This is a discussion on [mmotm] relay: fix build error - Kernel ; against: mmotm patchname: relay-add-buffer-only-channels-useful-for-early-logging-fix.patch applies after: relay-add-buffer-only-channels-useful-for-early-logging.patch recently, smp_call_function remove retry argument. it cause following build error on mmotm. kernel/relay.c: In function ‘relay_late_setup_files’: kernel/relay.c:754: error: too many arguments to function ‘smp_call_function_single’ make[1]: *** [kernel/relay.o] error 1 Signed-off-by: KOSAKI Motohiro CC: ...

+ Reply to Thread
Results 1 to 2 of 2

Thread: [mmotm] relay: fix build error

  1. [mmotm] relay: fix build error

    against: mmotm
    patchname: relay-add-buffer-only-channels-useful-for-early-logging-fix.patch
    applies after: relay-add-buffer-only-channels-useful-for-early-logging.patch

    recently, smp_call_function remove retry argument.
    it cause following build error on mmotm.

    kernel/relay.c: In function ‘relay_late_setup_files’:
    kernel/relay.c:754: error: too many arguments to function ‘smp_call_function_single’
    make[1]: *** [kernel/relay.o] error 1



    Signed-off-by: KOSAKI Motohiro
    CC: Eduard - Gabriel Munteanu
    Cc: Tom Zanussi
    CC: Andrew Morton

    ---
    kernel/relay.c | 2 +-
    1 file changed, 1 insertion(+), 1 deletion(-)

    Index: b/kernel/relay.c
    ================================================== =================
    --- a/kernel/relay.c
    +++ b/kernel/relay.c
    @@ -751,7 +751,7 @@ int relay_late_setup_files(struct rchan
    /* relay_channels_mutex must be held, so wait. */
    err = smp_call_function_single(i,
    __relay_set_buf_dentry,
    - &disp, 0, 1);
    + &disp, 1);
    }
    if (unlikely(err))
    break;


    --
    To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
    the body of a message to majordomo@vger.kernel.org
    More majordomo info at http://vger.kernel.org/majordomo-info.html
    Please read the FAQ at http://www.tux.org/lkml/

  2. Re: [mmotm] relay: fix build error

    On Sat, 12 Jul 2008 20:14:21 +0900
    KOSAKI Motohiro wrote:

    > against: mmotm
    > patchname:
    > relay-add-buffer-only-channels-useful-for-early-logging-fix.patch
    > applies after:
    > relay-add-buffer-only-channels-useful-for-early-logging.patch
    >
    > recently, smp_call_function remove retry argument.
    > it cause following build error on mmotm.
    >
    > kernel/relay.c: In function relay_late_setup_files:
    > kernel/relay.c:754: error: too many arguments to function
    > smp_call_function_single make[1]: *** [kernel/relay.o] error 1
    >
    >
    >
    > Signed-off-by: KOSAKI Motohiro
    > CC: Eduard - Gabriel Munteanu
    > Cc: Tom Zanussi
    > CC: Andrew Morton


    Thanks.

    If it matters...
    Acked-by: Eduard - Gabriel Munteanu

    > ---
    > kernel/relay.c | 2 +-
    > 1 file changed, 1 insertion(+), 1 deletion(-)
    >
    > Index: b/kernel/relay.c
    > ================================================== =================
    > --- a/kernel/relay.c
    > +++ b/kernel/relay.c
    > @@ -751,7 +751,7 @@ int relay_late_setup_files(struct rchan
    > /* relay_channels_mutex must be held, so
    > wait. */ err = smp_call_function_single(i,
    > __relay_set_buf_dentry,
    > - &disp, 0, 1);
    > + &disp, 1);
    > }
    > if (unlikely(err))
    > break;
    >

    --
    To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
    the body of a message to majordomo@vger.kernel.org
    More majordomo info at http://vger.kernel.org/majordomo-info.html
    Please read the FAQ at http://www.tux.org/lkml/

+ Reply to Thread