[PATCH -next] firmware: fix memmap printk format warnings - Kernel

This is a discussion on [PATCH -next] firmware: fix memmap printk format warnings - Kernel ; From: Randy Dunlap cc: Bernhard Walle Fix firmware/memmap printk format warnings: linux-next-20080711/drivers/firmware/memmap.c:156: warning: format '%llx' expects type 'long long unsigned int', but argument 4 has type 'resource_size_t' linux-next-20080711/drivers/firmware/memmap.c:161: warning: format '%llx' expects type 'long long unsigned int', but argument 4 ...

+ Reply to Thread
Results 1 to 2 of 2

Thread: [PATCH -next] firmware: fix memmap printk format warnings

  1. [PATCH -next] firmware: fix memmap printk format warnings

    From: Randy Dunlap
    cc: Bernhard Walle

    Fix firmware/memmap printk format warnings:

    linux-next-20080711/drivers/firmware/memmap.c:156: warning: format '%llx' expects type 'long long unsigned int', but argument 4 has type 'resource_size_t'
    linux-next-20080711/drivers/firmware/memmap.c:161: warning: format '%llx' expects type 'long long unsigned int', but argument 4 has type 'resource_size_t'

    Signed-off-by: Randy Dunlap
    ---
    drivers/firmware/memmap.c | 6 ++++--
    1 file changed, 4 insertions(+), 2 deletions(-)

    --- linux-next-20080711.orig/drivers/firmware/memmap.c
    +++ linux-next-20080711/drivers/firmware/memmap.c
    @@ -153,12 +153,14 @@ int __init firmware_map_add_early(resour

    static ssize_t start_show(struct firmware_map_entry *entry, char *buf)
    {
    - return snprintf(buf, PAGE_SIZE, "0x%llx\n", entry->start);
    + return snprintf(buf, PAGE_SIZE, "0x%llx\n",
    + (unsigned long long)entry->start);
    }

    static ssize_t end_show(struct firmware_map_entry *entry, char *buf)
    {
    - return snprintf(buf, PAGE_SIZE, "0x%llx\n", entry->end);
    + return snprintf(buf, PAGE_SIZE, "0x%llx\n",
    + (unsigned long long)entry->end);
    }

    static ssize_t type_show(struct firmware_map_entry *entry, char *buf)


    ---
    ~Randy
    Linux Plumbers Conference, 17-19 September 2008, Portland, Oregon USA
    http://linuxplumbersconf.org/
    --
    To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
    the body of a message to majordomo@vger.kernel.org
    More majordomo info at http://vger.kernel.org/majordomo-info.html
    Please read the FAQ at http://www.tux.org/lkml/

  2. Re: [PATCH -next] firmware: fix memmap printk format warnings

    * Randy Dunlap [2008-07-11 12:58]:
    >
    > From: Randy Dunlap
    > cc: Bernhard Walle
    >
    > Fix firmware/memmap printk format warnings:
    >
    > linux-next-20080711/drivers/firmware/memmap.c:156: warning: format '%llx' expects type 'long long unsigned int', but argument 4 has type 'resource_size_t'
    > linux-next-20080711/drivers/firmware/memmap.c:161: warning: format '%llx' expects type 'long long unsigned int', but argument 4 has type 'resource_size_t'


    Thanks for the patch. I did not include that change in my cleanup sent
    to Andrew to not conflict with that patch.


    Bernhard
    --
    Bernhard Walle, SUSE LINUX Products GmbH, Architecture Development
    --
    To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
    the body of a message to majordomo@vger.kernel.org
    More majordomo info at http://vger.kernel.org/majordomo-info.html
    Please read the FAQ at http://www.tux.org/lkml/

+ Reply to Thread