Re: [tpmdd-devel] Patch for Broadcom TPM TIS device HID - Kernel

This is a discussion on Re: [tpmdd-devel] Patch for Broadcom TPM TIS device HID - Kernel ; This depends on patch posted with "[PATCH] tpm: add Intel TPM TIS device HID" subject. From: LE DISEZ Erwan Subject: add Broadcom TPM TIS device HID Signed-off-by: Rajiv Andrade --- drivers/char/tpm/tpm_tis.c | 1 + 1 files changed, 1 insertions(+), 0 ...

+ Reply to Thread
Results 1 to 3 of 3

Thread: Re: [tpmdd-devel] Patch for Broadcom TPM TIS device HID

  1. Re: [tpmdd-devel] Patch for Broadcom TPM TIS device HID

    This depends on patch posted with "[PATCH] tpm: add Intel TPM TIS device HID" subject.

    From: LE DISEZ Erwan
    Subject: add Broadcom TPM TIS device HID

    Signed-off-by: Rajiv Andrade
    ---
    drivers/char/tpm/tpm_tis.c | 1 +
    1 files changed, 1 insertions(+), 0 deletions(-)

    diff --git a/drivers/char/tpm/tpm_tis.c b/drivers/char/tpm/tpm_tis.c
    index c7a977b..ed1879c 100644
    --- a/drivers/char/tpm/tpm_tis.c
    +++ b/drivers/char/tpm/tpm_tis.c
    @@ -622,6 +622,7 @@ static struct pnp_device_id tpm_pnp_tbl[] __devinitdata = {
    {"ATM1200", 0}, /* Atmel */
    {"IFX0102", 0}, /* Infineon */
    {"BCM0101", 0}, /* Broadcom */
    + {"BCM0102", 0}, /* Broadcom */
    {"NSC1200", 0}, /* National */
    {"ICO0102", 0}, /* Intel */
    /* Add new here */
    --

    On Thu, 2008-07-10 at 01:03 +0200, eledisez wrote:
    > Hi,
    >
    > all right, for the next time.
    >
    > Thanks.
    > Erwan.
    >
    > On Wed, 09 Jul 2008 18:49:51 -0300, Rajiv Andrade
    > wrote:
    > > Please add the Signed-off-by and whenever possible submit the patch in
    > > `patch -p1' form.
    > >
    > > Thanks,
    > > Rajiv
    > >
    > > On Sat, 2008-07-05 at 12:12 +0200, Erwan LE DISEZ wrote:
    > >> This patch adds Broadcom TPM TIS device HID : BCM0102.
    > >>
    > >> Tested with by DELL D630 Laptop computer.
    > >> Best regards. LE DISEZ Erwan.
    > >>

    > > -------------------------------------------------------------------------
    > >> Sponsored by: SourceForge.net Community Choice Awards: VOTE NOW!
    > >> Studies have shown that voting for your favorite open source project,
    > >> along with a healthy diet, reduces your potential for chronic lameness
    > >> and boredom. Vote Now at http://www.sourceforge.net/community/cca08
    > >> _______________________________________________ tpmdd-devel mailing list

    > > tpmdd-devel@lists.sourceforge.net
    > > https://lists.sourceforge.net/lists/...fo/tpmdd-devel


    --
    To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
    the body of a message to majordomo@vger.kernel.org
    More majordomo info at http://vger.kernel.org/majordomo-info.html
    Please read the FAQ at http://www.tux.org/lkml/

  2. Re: [tpmdd-devel] Patch for Broadcom TPM TIS device HID

    On Wed, 09 Jul 2008 21:34:23 -0300 Rajiv Andrade wrote:

    > This depends on patch posted with "[PATCH] tpm: add Intel TPM TIS device HID" subject.
    >
    > From: LE DISEZ Erwan
    > Subject: add Broadcom TPM TIS device HID
    >
    > Signed-off-by: Rajiv Andrade
    > ---
    > drivers/char/tpm/tpm_tis.c | 1 +
    > 1 files changed, 1 insertions(+), 0 deletions(-)
    >
    > diff --git a/drivers/char/tpm/tpm_tis.c b/drivers/char/tpm/tpm_tis.c
    > index c7a977b..ed1879c 100644
    > --- a/drivers/char/tpm/tpm_tis.c
    > +++ b/drivers/char/tpm/tpm_tis.c
    > @@ -622,6 +622,7 @@ static struct pnp_device_id tpm_pnp_tbl[] __devinitdata = {
    > {"ATM1200", 0}, /* Atmel */
    > {"IFX0102", 0}, /* Infineon */
    > {"BCM0101", 0}, /* Broadcom */
    > + {"BCM0102", 0}, /* Broadcom */
    > {"NSC1200", 0}, /* National */
    > {"ICO0102", 0}, /* Intel */
    > /* Add new here */


    Thanks. I'll see if we can squeeze this into 2.6.26.

    I'm a bit confused over who wrote the patch? Your changelog implies it
    was LE DISEZ Erwan . Is that correct?

    Also: Debora and Rajiv, could we please get your email addresses
    into ./MAINTAINERS? At present all we have is

    TPM DEVICE DRIVER
    P: Debora Velarde
    P: Rajiv Andrade
    M: tpmdd-devel@lists.sourceforge.net
    W: http://tpmdd.sourceforge.net
    P: Marcel Selhorst
    M: tpm@selhorst.net
    W: http://www.prosec.rub.de/tpm/
    L: tpmdd-devel@lists.sourceforge.net
    S: Maintained

    (pls fix the whitespace there too!)
    --
    To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
    the body of a message to majordomo@vger.kernel.org
    More majordomo info at http://vger.kernel.org/majordomo-info.html
    Please read the FAQ at http://www.tux.org/lkml/

  3. Re: [tpmdd-devel] Patch for Broadcom TPM TIS device HID


    On Fri, 2008-07-11 at 12:16 -0700, Andrew Morton wrote:
    > On Wed, 09 Jul 2008 21:34:23 -0300 Rajiv Andrade wrote:
    >
    > > This depends on patch posted with "[PATCH] tpm: add Intel TPM TIS device HID" subject.
    > >
    > > From: LE DISEZ Erwan
    > > Subject: add Broadcom TPM TIS device HID
    > >
    > > Signed-off-by: Rajiv Andrade
    > > ---
    > > drivers/char/tpm/tpm_tis.c | 1 +
    > > 1 files changed, 1 insertions(+), 0 deletions(-)
    > >
    > > diff --git a/drivers/char/tpm/tpm_tis.c b/drivers/char/tpm/tpm_tis.c
    > > index c7a977b..ed1879c 100644
    > > --- a/drivers/char/tpm/tpm_tis.c
    > > +++ b/drivers/char/tpm/tpm_tis.c
    > > @@ -622,6 +622,7 @@ static struct pnp_device_id tpm_pnp_tbl[] __devinitdata = {
    > > {"ATM1200", 0}, /* Atmel */
    > > {"IFX0102", 0}, /* Infineon */
    > > {"BCM0101", 0}, /* Broadcom */
    > > + {"BCM0102", 0}, /* Broadcom */
    > > {"NSC1200", 0}, /* National */
    > > {"ICO0102", 0}, /* Intel */
    > > /* Add new here */

    >
    > Thanks. I'll see if we can squeeze this into 2.6.26.
    >
    > I'm a bit confused over who wrote the patch? Your changelog implies it
    > was LE DISEZ Erwan . Is that correct?


    ´╗┐Yes, it was him, I just added the Signed-off-by that he didn't and made it apply
    cleanly after "[PATCH] tpm: add Intel TPM TIS device HID".

    >
    > Also: Debora and Rajiv, could we please get your email addresses
    > into ./MAINTAINERS? At present all we have is
    >
    > TPM DEVICE DRIVER
    > P: Debora Velarde
    > P: Rajiv Andrade
    > M: tpmdd-devel@lists.sourceforge.net
    > W: http://tpmdd.sourceforge.net
    > P: Marcel Selhorst
    > M: tpm@selhorst.net
    > W: http://www.prosec.rub.de/tpm/
    > L: tpmdd-devel@lists.sourceforge.net
    > S: Maintained


    Sure!
    >
    > (pls fix the whitespace there too!)


    My fault. I'd already submitted a patch correcting this, but I'm going to submit a new one with both fixes.

    Thanks

    --
    To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
    the body of a message to majordomo@vger.kernel.org
    More majordomo info at http://vger.kernel.org/majordomo-info.html
    Please read the FAQ at http://www.tux.org/lkml/

+ Reply to Thread