[PATCH 1/1] MMC: sido_io.c Fix sparse warnings - Kernel

This is a discussion on [PATCH 1/1] MMC: sido_io.c Fix sparse warnings - Kernel ; Unfold nested macros it creates not readable code and sparse warnings sdio_io.c:190:9: warning: symbol '_min1' shadows an earlier one Signed-off-by: Tomas Winkler --- drivers/mmc/core/sdio_io.c | 9 ++++----- 1 files changed, 4 insertions(+), 5 deletions(-) diff --git a/drivers/mmc/core/sdio_io.c b/drivers/mmc/core/sdio_io.c index 0888df6..f61fc2d ...

+ Reply to Thread
Results 1 to 2 of 2

Thread: [PATCH 1/1] MMC: sido_io.c Fix sparse warnings

  1. [PATCH 1/1] MMC: sido_io.c Fix sparse warnings

    Unfold nested macros it creates not readable code and
    sparse warnings
    sdio_io.c:190:9: warning: symbol '_min1' shadows an earlier one

    Signed-off-by: Tomas Winkler
    ---
    drivers/mmc/core/sdio_io.c | 9 ++++-----
    1 files changed, 4 insertions(+), 5 deletions(-)

    diff --git a/drivers/mmc/core/sdio_io.c b/drivers/mmc/core/sdio_io.c
    index 0888df6..f61fc2d 100755
    --- a/drivers/mmc/core/sdio_io.c
    +++ b/drivers/mmc/core/sdio_io.c
    @@ -187,11 +187,10 @@ EXPORT_SYMBOL_GPL(sdio_set_block_size);
    */
    static inline unsigned int sdio_max_byte_size(struct sdio_func *func)
    {
    - return min(min(min(
    - func->card->host->max_seg_size,
    - func->card->host->max_blk_size),
    - func->max_blksize),
    - 512u); /* maximum size for byte mode */
    + unsigned mval = min(func->card->host->max_seg_size,
    + func->card->host->max_blk_size);
    + mval = min(mval, func->max_blksize);
    + return min(mval, 512u); /* maximum size for byte mode */
    }

    /**
    --
    1.5.4.1

    ---------------------------------------------------------------------
    Intel Israel (74) Limited

    This e-mail and any attachments may contain confidential material for
    the sole use of the intended recipient(s). Any review or distribution
    by others is strictly prohibited. If you are not the intended
    recipient, please contact the sender and delete all copies.

    --
    To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
    the body of a message to majordomo@vger.kernel.org
    More majordomo info at http://vger.kernel.org/majordomo-info.html
    Please read the FAQ at http://www.tux.org/lkml/

  2. Re: [PATCH 1/1] MMC: sido_io.c Fix sparse warnings

    On Thu, 10 Jul 2008 03:01:56 +0300
    Tomas Winkler wrote:

    > Unfold nested macros it creates not readable code and
    > sparse warnings
    > sdio_io.c:190:9: warning: symbol '_min1' shadows an earlier one
    >
    > Signed-off-by: Tomas Winkler
    > ---


    I actually think the original version is more readable, but I've
    applied it for the sake of avoiding sparse noise.

    --
    -- Pierre Ossman

    Linux kernel, MMC maintainer http://www.kernel.org
    rdesktop, core developer http://www.rdesktop.org

    WARNING: This correspondence is being monitored by the
    Swedish government. Make sure your server uses encryption
    for SMTP traffic and consider using PGP for end-to-end
    encryption.

    -----BEGIN PGP SIGNATURE-----
    Version: GnuPG v2.0.9 (GNU/Linux)

    iEYEARECAAYFAkh2ahsACgkQ7b8eESbyJLibKQCfSU8UYDeHHD 7qO3hVl6R3VHWy
    y3YAoK/0fCdDRddlA6+dNmhGLzzitx6A
    =TjUU
    -----END PGP SIGNATURE-----


+ Reply to Thread