[PATCH] Add base_hi BAR for oxsemi_840 - Kernel

This is a discussion on [PATCH] Add base_hi BAR for oxsemi_840 - Kernel ; Use the 2nd BAR for the oxsemi_840 chip as BAR for base_hi. Tested with: Parallel controller [0701]: Oxford Semiconductor Ltd VScom 011H-EP1 1 port parallel adaptor [1415:8403] (prog-if 03 [IEEE1284]) This patch is needed to make 'TRISTATE' working with that ...

+ Reply to Thread
Results 1 to 3 of 3

Thread: [PATCH] Add base_hi BAR for oxsemi_840

  1. [PATCH] Add base_hi BAR for oxsemi_840

    Use the 2nd BAR for the oxsemi_840 chip as BAR for base_hi.
    Tested with:

    Parallel controller [0701]: Oxford Semiconductor Ltd VScom 011H-EP1
    1 port parallel adaptor [1415:8403] (prog-if 03 [IEEE1284])

    This patch is needed to make 'TRISTATE' working with that adaptor.


    Signed-off-by: Bernhard Walle

    ---
    drivers/parport/parport_pc.c | 2 +-
    1 file changed, 1 insertion(+), 1 deletion(-)

    --- a/drivers/parport/parport_pc.c
    +++ b/drivers/parport/parport_pc.c
    @@ -2877,7 +2877,7 @@ static struct parport_pc_pci {
    * and 840 locks up if you write 1 to bit 2! */
    /* oxsemi_952 */ { 1, { { 0, 1 }, } },
    /* oxsemi_954 */ { 1, { { 0, -1 }, } },
    - /* oxsemi_840 */ { 1, { { 0, -1 }, } },
    + /* oxsemi_840 */ { 1, { { 0, 1 }, } },
    /* aks_0100 */ { 1, { { 0, -1 }, } },
    /* mobility_pp */ { 1, { { 0, 1 }, } },
    /* netmos_9705 */ { 1, { { 0, -1 }, } }, /* untested */
    --
    To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
    the body of a message to majordomo@vger.kernel.org
    More majordomo info at http://vger.kernel.org/majordomo-info.html
    Please read the FAQ at http://www.tux.org/lkml/

  2. Re: [PATCH] Add base_hi BAR for oxsemi_840

    On Tue, 1 Jul 2008 23:45:29 +0200
    Bernhard Walle wrote:

    > Subject: [PATCH] Add base_hi BAR for oxsemi_840


    Please add a subsystem identifier to patch titles. In this case,

    parport_pc: add base_hi BAR for oxsemi_840

    is good.

    (IMO this is mainly as a courtesy to people who are browsing the commits
    lists) (and short-form changelogs)

    > Date: Tue, 1 Jul 2008 23:45:29 +0200
    > Organization: SUSE LINUX Products GmbH
    > X-Mailer: Claws Mail 3.5.0 (GTK+ 2.12.10; i686-pc-linux-gnu)
    >
    > Use the 2nd BAR for the oxsemi_840 chip as BAR for base_hi.
    > Tested with:
    >
    > Parallel controller [0701]: Oxford Semiconductor Ltd VScom 011H-EP1
    > 1 port parallel adaptor [1415:8403] (prog-if 03 [IEEE1284])
    >
    > This patch is needed to make 'TRISTATE' working with that adaptor.
    >
    >
    > Signed-off-by: Bernhard Walle
    >
    > ---
    > drivers/parport/parport_pc.c | 2 +-
    > 1 file changed, 1 insertion(+), 1 deletion(-)
    >
    > --- a/drivers/parport/parport_pc.c
    > +++ b/drivers/parport/parport_pc.c
    > @@ -2877,7 +2877,7 @@ static struct parport_pc_pci {
    > * and 840 locks up if you write 1 to bit 2! */
    > /* oxsemi_952 */ { 1, { { 0, 1 }, } },
    > /* oxsemi_954 */ { 1, { { 0, -1 }, } },
    > - /* oxsemi_840 */ { 1, { { 0, -1 }, } },
    > + /* oxsemi_840 */ { 1, { { 0, 1 }, } },
    > /* aks_0100 */ { 1, { { 0, -1 }, } },
    > /* mobility_pp */ { 1, { { 0, 1 }, } },
    > /* netmos_9705 */ { 1, { { 0, -1 }, } }, /* untested */


    My parport knowledge doesn't permit me to understand how serious the
    just-fixed bug was. Non-functional parport?

    If so, this looks like a 2.6.26 and 2.6.25.x fix?

    --
    To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
    the body of a message to majordomo@vger.kernel.org
    More majordomo info at http://vger.kernel.org/majordomo-info.html
    Please read the FAQ at http://www.tux.org/lkml/

  3. Re: [PATCH] Add base_hi BAR for oxsemi_840

    * Andrew Morton [2008-07-01 15:00]:
    > >
    > > --- a/drivers/parport/parport_pc.c
    > > +++ b/drivers/parport/parport_pc.c
    > > @@ -2877,7 +2877,7 @@ static struct parport_pc_pci {
    > > * and 840 locks up if you write 1 to bit 2! */
    > > /* oxsemi_952 */ { 1, { { 0, 1 }, } },
    > > /* oxsemi_954 */ { 1, { { 0, -1 }, } },
    > > - /* oxsemi_840 */ { 1, { { 0, -1 }, } },
    > > + /* oxsemi_840 */ { 1, { { 0, 1 }, } },
    > > /* aks_0100 */ { 1, { { 0, -1 }, } },
    > > /* mobility_pp */ { 1, { { 0, 1 }, } },
    > > /* netmos_9705 */ { 1, { { 0, -1 }, } }, /* untested */

    >
    > My parport knowledge doesn't permit me to understand how serious the
    > just-fixed bug was. Non-functional parport?
    >
    > If so, this looks like a 2.6.26 and 2.6.25.x fix?


    No, for good old printers, everything works. It's just that ECR
    register was not available (the base_hi stuff). Because of that,
    the TRISTATE detection did not work, which meant that for me my
    self-built logic analyzer which uses the parallel port did not work.

    Just merge in 2.6.27 is enough.


    Bernhard
    --
    Bernhard Walle, SUSE LINUX Products GmbH, Architecture Development
    --
    To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
    the body of a message to majordomo@vger.kernel.org
    More majordomo info at http://vger.kernel.org/majordomo-info.html
    Please read the FAQ at http://www.tux.org/lkml/

+ Reply to Thread