[PATCH] POWERPC CPM: Minor cosmetic changes to udbg_putc - Kernel

This is a discussion on [PATCH] POWERPC CPM: Minor cosmetic changes to udbg_putc - Kernel ; From: Nye Liu udbg_putc is a *function pointer* that is initialized during udbg_init_cpm. It might not be initialized properly when called from udbg_putc_cpm(), so (recursively) call udbg_putc_cpm() directly. Printing an "X" on initialization is ugly. How about a "\n" instead? ...

+ Reply to Thread
Results 1 to 3 of 3

Thread: [PATCH] POWERPC CPM: Minor cosmetic changes to udbg_putc

  1. [PATCH] POWERPC CPM: Minor cosmetic changes to udbg_putc

    From: Nye Liu

    udbg_putc is a *function pointer* that is initialized during
    udbg_init_cpm. It might not be initialized properly when called from
    udbg_putc_cpm(), so (recursively) call udbg_putc_cpm() directly.

    Printing an "X" on initialization is ugly. How about a "\n" instead?

    Signed-off-by: Nye Liu

    ---

    diff --git a/arch/powerpc/sysdev/cpm_common.c b/arch/powerpc/sysdev/cpm_common.c
    index cb7df2d..dcde743 100644
    --- a/arch/powerpc/sysdev/cpm_common.c
    +++ b/arch/powerpc/sysdev/cpm_common.c
    @@ -37,7 +37,7 @@ static void udbg_putc_cpm(char c)
    u8 __iomem *txbuf = (u8 __iomem __force *)in_be32(&cpm_udbg_txdesc[1]);

    if (c == '\n')
    - udbg_putc('\r');
    + udbg_putc_cpm('\r');

    while (in_be32(&cpm_udbg_txdesc[0]) & 0x80000000)
    ;
    @@ -53,7 +53,7 @@ void __init udbg_init_cpm(void)
    setbat(1, 0xf0000000, 0xf0000000, 1024*1024, _PAGE_IO);
    #endif
    udbg_putc = udbg_putc_cpm;
    - udbg_putc('X');
    + udbg_putc('\n');
    }
    }
    #endif

    --
    Nye Liu
    nliu@mrv.com
    (818) 772-6235x248
    (818) 772-0576 fax

    "Who would be stupid enough to quote a fictitious character?"
    -- Don Quixote
    --
    To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
    the body of a message to majordomo@vger.kernel.org
    More majordomo info at http://vger.kernel.org/majordomo-info.html
    Please read the FAQ at http://www.tux.org/lkml/

  2. Re: [PATCH] POWERPC CPM: Minor cosmetic changes to udbg_putc

    Nye Liu wrote:
    > udbg_putc is a *function pointer* that is initialized during
    > udbg_init_cpm. It might not be initialized properly when called from
    > udbg_putc_cpm(), so (recursively) call udbg_putc_cpm() directly.


    ACK

    > Printing an "X" on initialization is ugly. How about a "\n" instead?


    D'oh, that was a debugging leftover that I missed when cleaning things
    up. Just remove it.

    -Scott
    --
    To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
    the body of a message to majordomo@vger.kernel.org
    More majordomo info at http://vger.kernel.org/majordomo-info.html
    Please read the FAQ at http://www.tux.org/lkml/

  3. Re: [PATCH] POWERPC CPM: Minor cosmetic changes to udbg_putc


    On Jun 27, 2008, at 3:01 PM, Nye Liu wrote:

    > From: Nye Liu
    >
    > udbg_putc is a *function pointer* that is initialized during
    > udbg_init_cpm. It might not be initialized properly when called from
    > udbg_putc_cpm(), so (recursively) call udbg_putc_cpm() directly.
    >
    > Printing an "X" on initialization is ugly. How about a "\n" instead?
    >
    > Signed-off-by: Nye Liu
    >
    > ---


    Applied. I removed the "\n" per Scott's feedback.

    - k
    --
    To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
    the body of a message to majordomo@vger.kernel.org
    More majordomo info at http://vger.kernel.org/majordomo-info.html
    Please read the FAQ at http://www.tux.org/lkml/

+ Reply to Thread