[GIT PULL] fix kbuild regression - Kernel
This is a discussion on [GIT PULL] fix kbuild regression - Kernel ; Hi Linus. Please pull from: ssh://master.kernel.org/pub/scm/linux/kernel/git/sam/kbuild-fixes.git Sam To get the following fix: Sam Ravnborg (1): kbuild: fix $(src) assignmnet with external modules When we introduced support for KBUILD_EXTRA_SYMBOLS we started to include the externam module's kbuild file when doing the ...
| | LinkBack | Tools |
|
#1
| |||
| |||
| Please pull from: ssh://master.kernel.org/pub/scm/linux/kernel/git/sam/kbuild-fixes.git Sam To get the following fix: Sam Ravnborg (1): kbuild: fix $(src) assignmnet with external modules When we introduced support for KBUILD_EXTRA_SYMBOLS we started to include the externam module's kbuild file when doing the final modpost step. As external modules often do: ccflags-y := -I$(src) We had problems because $(src) was unassinged and gcc then used the next parameter for -I resulting in strange build failures. Fix is to assign $(src) and $(obj) when building external modules. This fixes: http://bugzilla.kernel.org/show_bug.cgi?id=10798 Signed-off-by: Sam Ravnborg Cc: Tvrtko Cc: Andrea Arcangeli Cc: "Rafael J. Wysocki" scripts/Makefile.modpost | 6 ++++++ 1 files changed, 6 insertions(+), 0 deletions(-) diff --git a/scripts/Makefile.modpost b/scripts/Makefile.modpost index a098a04..17092d6 100644 --- a/scripts/Makefile.modpost +++ b/scripts/Makefile.modpost @@ -43,7 +43,13 @@ _modpost: __modpost include include/config/auto.conf include scripts/Kbuild.include +# When building external modules load the Kbuild file to retreive EXTRA_SYMBOLS info ifneq ($(KBUILD_EXTMOD),) + +# set src + obj - they may be used when building the .mod.c file +obj := $(KBUILD_EXTMOD) +src := $(obj) + # Include the module's Makefile to find KBUILD_EXTRA_SYMBOLS include $(if $(wildcard $(KBUILD_EXTMOD)/Kbuild), \ $(KBUILD_EXTMOD)/Kbuild, $(KBUILD_EXTMOD)/Makefile) -- To unsubscribe from this list: send the line "unsubscribe linux-kernel" in the body of a message to majordomo@vger.kernel.org More majordomo info at http://vger.kernel.org/majordomo-info.html Please read the FAQ at http://www.tux.org/lkml/ |
« Previous Thread
|
Next Thread »
| Tools | |
| |
| | ||||
| Thread | Thread Starter | Forum | Replies | Last Post |
| Re: kbuild: modules_install regression ? - depmod | unix | Kernel | 1 | 12-29-2007 04:10 PM |
| Re: kbuild: modules_install regression ? - depmod | unix | Kernel | 2 | 12-29-2007 02:10 PM |
| Re: kbuild: modules_install regression ? - depmod | unix | Kernel | 3 | 12-29-2007 09:50 AM |
| kbuild: possible regression? | unix | Kernel | 6 | 12-11-2007 05:40 PM |
| kbuild: modules_install regression ? - depmod | unix | Kernel | 0 | 11-01-2007 04:20 AM |
All times are GMT. The time now is 09:39 AM.
