[PATCH 0/2]: LMB small bug fix and debugging tidy up. - Kernel

This is a discussion on [PATCH 0/2]: LMB small bug fix and debugging tidy up. - Kernel ; While diagnosing Mikael's bug where half of his RAM disappeared in 2.6.26-rc2 I found one bug (which I don't think fixes his problem, but waiting for an updated set of debugging logs from him) and an improvement to the debugging ...

+ Reply to Thread
Results 1 to 2 of 2

Thread: [PATCH 0/2]: LMB small bug fix and debugging tidy up.

  1. [PATCH 0/2]: LMB small bug fix and debugging tidy up.


    While diagnosing Mikael's bug where half of his RAM disappeared
    in 2.6.26-rc2 I found one bug (which I don't think fixes his
    problem, but waiting for an updated set of debugging logs from
    him) and an improvement to the debugging provided by the current
    LMB code.
    --
    To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
    the body of a message to majordomo@vger.kernel.org
    More majordomo info at http://vger.kernel.org/majordomo-info.html
    Please read the FAQ at http://www.tux.org/lkml/

  2. [rfc patch] memory_hotplug: Check for walk_memory_resource() failure in online_pages()

    Add a check to online_pages() to test for failure of
    walk_memory_resource(). This fixes a condition where a failure
    of walk_memory_resource() can lead to online_pages() returning
    success without the requested pages being onlined.

    Signed-off-by: Geoff Levand
    ---

    I'm not entirely sure this is the proper way to handle this
    condition. Comments welcome.

    mm/memory_hotplug.c | 9 ++++++++-
    1 file changed, 8 insertions(+), 1 deletion(-)

    --- a/mm/memory_hotplug.c
    +++ b/mm/memory_hotplug.c
    @@ -408,8 +408,15 @@ int online_pages(unsigned long pfn, unsi
    if (!populated_zone(zone))
    need_zonelists_rebuild = 1;

    - walk_memory_resource(pfn, nr_pages, &onlined_pages,
    + ret = walk_memory_resource(pfn, nr_pages, &onlined_pages,
    online_pages_range);
    + if (ret) {
    + printk(KERN_DEBUG "online_pages %lx at %lx failed\n",
    + nr_pages, pfn);
    + memory_notify(MEM_CANCEL_ONLINE, &arg);
    + return ret;
    + }
    +
    zone->present_pages += onlined_pages;
    zone->zone_pgdat->node_present_pages += onlined_pages;


    --
    To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
    the body of a message to majordomo@vger.kernel.org
    More majordomo info at http://vger.kernel.org/majordomo-info.html
    Please read the FAQ at http://www.tux.org/lkml/

+ Reply to Thread