[PATCH 1/1] infiniband/hw/nes/: avoid unnecessary memset - Kernel

This is a discussion on [PATCH 1/1] infiniband/hw/nes/: avoid unnecessary memset - Kernel ; From: Christophe Jaillet Hi, here is a patch against linux/drivers/infiniband/hw/nes/nes_cm.c which : 1) Remove an explicit memset(.., 0, ...) to a variable allocated with kzalloc (i.e. 'listener'). Note: this patch is based on 'linux-2.6.25.tar.bz2' Signed-off-by: Christophe Jaillet --- --- linux/drivers/infiniband/hw/nes/nes_cm.c ...

+ Reply to Thread
Results 1 to 5 of 5

Thread: [PATCH 1/1] infiniband/hw/nes/: avoid unnecessary memset

  1. [PATCH 1/1] infiniband/hw/nes/: avoid unnecessary memset

    From: Christophe Jaillet

    Hi, here is a patch against linux/drivers/infiniband/hw/nes/nes_cm.c which :

    1) Remove an explicit memset(.., 0, ...) to a variable allocated with
    kzalloc (i.e. 'listener').


    Note: this patch is based on 'linux-2.6.25.tar.bz2'

    Signed-off-by: Christophe Jaillet

    ---

    --- linux/drivers/infiniband/hw/nes/nes_cm.c 2008-04-17 04:49:44.000000000 +0200
    +++ linux/drivers/infiniband/hw/nes/nes_cm.c.cj 2008-05-12 23:31:24.000000000 +0200
    @@ -1587,7 +1587,6 @@ static struct nes_cm_listener *mini_cm_l
    return NULL;
    }

    - memset(listener, 0, sizeof(struct nes_cm_listener));
    listener->loc_addr = htonl(cm_info->loc_addr);
    listener->loc_port = htons(cm_info->loc_port);
    listener->reused_node = 0;


    --
    To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
    the body of a message to majordomo@vger.kernel.org
    More majordomo info at http://vger.kernel.org/majordomo-info.html
    Please read the FAQ at http://www.tux.org/lkml/

  2. [PATCH] drivers/net/ehea - remove unnecessary memset after kzalloc

    Signed-off-by: Joe Perches

    ---

    drivers/net/ehea/ehea_main.c | 2 --
    1 files changed, 0 insertions(+), 2 deletions(-)

    diff --git a/drivers/net/ehea/ehea_main.c b/drivers/net/ehea/ehea_main.c
    index f9bc21c..fd4be0d 100644
    --- a/drivers/net/ehea/ehea_main.c
    +++ b/drivers/net/ehea/ehea_main.c
    @@ -2207,18 +2207,16 @@ static void ehea_vlan_rx_register(struct net_device *dev,
    port->vgrp = grp;

    cb1 = kzalloc(PAGE_SIZE, GFP_KERNEL);
    if (!cb1) {
    ehea_error("no mem for cb1");
    goto out;
    }

    - memset(cb1->vlan_filter, 0, sizeof(cb1->vlan_filter));
    -
    hret = ehea_h_modify_ehea_port(adapter->handle, port->logical_port_id,
    H_PORT_CB1, H_PORT_CB1_ALL, cb1);
    if (hret != H_SUCCESS)
    ehea_error("modify_ehea_port failed");

    kfree(cb1);
    out:
    return;


    --
    To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
    the body of a message to majordomo@vger.kernel.org
    More majordomo info at http://vger.kernel.org/majordomo-info.html
    Please read the FAQ at http://www.tux.org/lkml/

  3. RE: [PATCH 1/1] infiniband/hw/nes/: avoid unnecessary memset

    Acked-by Faisal Latif

    Thanks
    Faisal


    >
    > From: Christophe Jaillet
    >
    > Hi, here is a patch against linux/drivers/infiniband/hw/nes/nes_cm.c
    > which :
    >
    > 1) Remove an explicit memset(.., 0, ...) to a variable allocated with
    > kzalloc (i.e. 'listener').
    >
    >
    > Note: this patch is based on 'linux-2.6.25.tar.bz2'
    >
    > Signed-off-by: Christophe Jaillet
    >
    > ---
    >
    > --- linux/drivers/infiniband/hw/nes/nes_cm.c 2008-04-17
    > 04:49:44.000000000 +0200
    > +++ linux/drivers/infiniband/hw/nes/nes_cm.c.cj 2008-05-12
    > 23:31:24.000000000 +0200
    > @@ -1587,7 +1587,6 @@ static struct nes_cm_listener *mini_cm_l
    > return NULL;
    > }
    >
    > - memset(listener, 0, sizeof(struct nes_cm_listener));
    > listener->loc_addr = htonl(cm_info->loc_addr);
    > listener->loc_port = htons(cm_info->loc_port);
    > listener->reused_node = 0;
    >


    --
    To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
    the body of a message to majordomo@vger.kernel.org
    More majordomo info at http://vger.kernel.org/majordomo-info.html
    Please read the FAQ at http://www.tux.org/lkml/

  4. Re: [PATCH] drivers/net/ehea - remove unnecessary memset after kzalloc

    On Monday 12 May 2008 23:38, Joe Perches wrote:
    > Signed-off-by: Joe Perches
    >
    > ---
    >
    > drivers/net/ehea/ehea_main.c | 2 --
    > 1 files changed, 0 insertions(+), 2 deletions(-)
    >
    > diff --git a/drivers/net/ehea/ehea_main.c b/drivers/net/ehea/ehea_main.c
    > index f9bc21c..fd4be0d 100644
    > --- a/drivers/net/ehea/ehea_main.c
    > +++ b/drivers/net/ehea/ehea_main.c
    > @@ -2207,18 +2207,16 @@ static void ehea_vlan_rx_register(struct net_device *dev,
    > port->vgrp = grp;
    >
    > cb1 = kzalloc(PAGE_SIZE, GFP_KERNEL);
    > if (!cb1) {
    > ehea_error("no mem for cb1");
    > goto out;
    > }
    >
    > - memset(cb1->vlan_filter, 0, sizeof(cb1->vlan_filter));
    > -
    > hret = ehea_h_modify_ehea_port(adapter->handle, port->logical_port_id,
    > H_PORT_CB1, H_PORT_CB1_ALL, cb1);
    > if (hret != H_SUCCESS)
    > ehea_error("modify_ehea_port failed");
    >
    > kfree(cb1);
    > out:
    > return;
    >

    The patch looks good.

    Acked-by: Jan-Bernd Themann

    Thanks,
    Jan-Bernd
    --
    To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
    the body of a message to majordomo@vger.kernel.org
    More majordomo info at http://vger.kernel.org/majordomo-info.html
    Please read the FAQ at http://www.tux.org/lkml/

  5. Re: [PATCH] drivers/net/ehea - remove unnecessary memset after kzalloc

    Joe Perches wrote:
    > Signed-off-by: Joe Perches


    applied


    --
    To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
    the body of a message to majordomo@vger.kernel.org
    More majordomo info at http://vger.kernel.org/majordomo-info.html
    Please read the FAQ at http://www.tux.org/lkml/

+ Reply to Thread