[PATCH 1/1] avr32/pata: avoid unnecessary memset - Kernel

This is a discussion on [PATCH 1/1] avr32/pata: avoid unnecessary memset - Kernel ; From: Christophe Jaillet Hi, here is a patch against linux/drivers/dma/iop-adma.c which : 1) Remove an explicit memset(.., 0, ...) to a variable allocated with kzalloc (i.e. 'info'). Note: this patch is based on 'linux-2.6.25.tar.bz2' Signed-off-by: Christophe Jaillet --- --- linux/drivers/ata/pata_at32.c ...

+ Reply to Thread
Results 1 to 2 of 2

Thread: [PATCH 1/1] avr32/pata: avoid unnecessary memset

  1. [PATCH 1/1] avr32/pata: avoid unnecessary memset

    From: Christophe Jaillet

    Hi, here is a patch against linux/drivers/dma/iop-adma.c which :

    1) Remove an explicit memset(.., 0, ...) to a variable allocated with
    kzalloc (i.e. 'info').


    Note: this patch is based on 'linux-2.6.25.tar.bz2'

    Signed-off-by: Christophe Jaillet

    ---

    --- linux/drivers/ata/pata_at32.c 2008-04-17 04:49:44.000000000 +0200
    +++ linux/drivers/ata/pata_at32.c.cj 2008-05-12 23:07:10.000000000 +0200
    @@ -329,8 +329,6 @@ static int __init pata_at32_probe(struct
    if (!info)
    return -ENOMEM;

    - memset(info, 0, sizeof(struct at32_ide_info));
    -
    info->irq = irq;
    info->cs = board->cs;



    --
    To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
    the body of a message to majordomo@vger.kernel.org
    More majordomo info at http://vger.kernel.org/majordomo-info.html
    Please read the FAQ at http://www.tux.org/lkml/

  2. Re: [PATCH 1/1] avr32/pata: avoid unnecessary memset

    Christophe Jaillet wrote:
    > From: Christophe Jaillet
    >
    > Hi, here is a patch against linux/drivers/dma/iop-adma.c which :


    Hmm...no, it's for drivers/ata/pata_at32.c.

    > 1) Remove an explicit memset(.., 0, ...) to a variable allocated with
    > kzalloc (i.e. 'info').
    >
    >
    > Note: this patch is based on 'linux-2.6.25.tar.bz2'
    >
    > Signed-off-by: Christophe Jaillet


    Other than that, it looks good to me. Could you please fix the patch
    description, add

    Acked-by: Haavard Skinnemoen

    and send it to Jeff?

    Thanks a lot!

    Haavard

    > ---
    >
    > --- linux/drivers/ata/pata_at32.c 2008-04-17 04:49:44.000000000 +0200
    > +++ linux/drivers/ata/pata_at32.c.cj 2008-05-12 23:07:10.000000000 +0200
    > @@ -329,8 +329,6 @@ static int __init pata_at32_probe(struct
    > if (!info)
    > return -ENOMEM;
    >
    > - memset(info, 0, sizeof(struct at32_ide_info));
    > -
    > info->irq = irq;
    > info->cs = board->cs;
    >
    >
    >


    --
    To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
    the body of a message to majordomo@vger.kernel.org
    More majordomo info at http://vger.kernel.org/majordomo-info.html
    Please read the FAQ at http://www.tux.org/lkml/

+ Reply to Thread