[PATCH] riscom8: remove redundant null pointer test - Kernel

This is a discussion on [PATCH] riscom8: remove redundant null pointer test - Kernel ; tty has already been dereferenced at least twice in these functions, so checking for null here seems a bit unnecessary. Signed-off-by: Chris Malley --- drivers/char/riscom8.c | 4 ++-- 1 files changed, 2 insertions(+), 2 deletions(-) diff --git a/drivers/char/riscom8.c b/drivers/char/riscom8.c index ...

+ Reply to Thread
Results 1 to 2 of 2

Thread: [PATCH] riscom8: remove redundant null pointer test

  1. [PATCH] riscom8: remove redundant null pointer test

    tty has already been dereferenced at least twice in these functions,
    so checking for null here seems a bit unnecessary.

    Signed-off-by: Chris Malley
    ---
    drivers/char/riscom8.c | 4 ++--
    1 files changed, 2 insertions(+), 2 deletions(-)

    diff --git a/drivers/char/riscom8.c b/drivers/char/riscom8.c
    index f073c71..9643a49 100644
    --- a/drivers/char/riscom8.c
    +++ b/drivers/char/riscom8.c
    @@ -1108,7 +1108,7 @@ static int rc_write(struct tty_struct *tty,

    bp = port_Board(port);

    - if (!tty || !port->xmit_buf)
    + if (!port->xmit_buf)
    return 0;

    while (1) {
    @@ -1151,7 +1151,7 @@ static int rc_put_char(struct tty_struct *tty, unsigned char ch)
    if (rc_paranoia_check(port, tty->name, "rc_put_char"))
    return 0;

    - if (!tty || !port->xmit_buf)
    + if (!port->xmit_buf)
    return 0;

    spin_lock_irqsave(&riscom_lock, flags);
    --



    --
    To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
    the body of a message to majordomo@vger.kernel.org
    More majordomo info at http://vger.kernel.org/majordomo-info.html
    Please read the FAQ at http://www.tux.org/lkml/

  2. Re: [PATCH] riscom8: remove redundant null pointer test

    On Mon, 12 May 2008 19:27:10 +0100
    Chris Malley wrote:

    > tty has already been dereferenced at least twice in these functions,
    > so checking for null here seems a bit unnecessary.


    Oh it is - and lots of the other tty checks are bogus too.

    Acked-by: Alan Cox

    Alan
    --
    To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
    the body of a message to majordomo@vger.kernel.org
    More majordomo info at http://vger.kernel.org/majordomo-info.html
    Please read the FAQ at http://www.tux.org/lkml/

+ Reply to Thread