[PATCH] drm/radeon: radeon_enable_vblank should return negative error - Kernel

This is a discussion on [PATCH] drm/radeon: radeon_enable_vblank should return negative error - Kernel ; radeon_enable_vblank and drm_wait_vblank returns negative values on error Signed-off-by: Marcin Slusarz Cc: Dave Airlie Cc: Jesse Barnes --- compile tested only --- drivers/char/drm/radeon_irq.c | 2 +- 1 files changed, 1 insertions(+), 1 deletions(-) diff --git a/drivers/char/drm/radeon_irq.c b/drivers/char/drm/radeon_irq.c --- a/drivers/char/drm/radeon_irq.c +++ ...

+ Reply to Thread
Results 1 to 2 of 2

Thread: [PATCH] drm/radeon: radeon_enable_vblank should return negative error

  1. [PATCH] drm/radeon: radeon_enable_vblank should return negative error

    radeon_enable_vblank <- drm_vblank_get <- drm_wait_vblank
    and drm_wait_vblank returns negative values on error

    Signed-off-by: Marcin Slusarz
    Cc: Dave Airlie
    Cc: Jesse Barnes
    ---
    compile tested only
    ---
    drivers/char/drm/radeon_irq.c | 2 +-
    1 files changed, 1 insertions(+), 1 deletions(-)

    diff --git a/drivers/char/drm/radeon_irq.c b/drivers/char/drm/radeon_irq.c
    --- a/drivers/char/drm/radeon_irq.c
    +++ b/drivers/char/drm/radeon_irq.c
    @@ -59,7 +59,7 @@ int radeon_enable_vblank(struct drm_device *dev, int crtc)
    default:
    DRM_ERROR("tried to enable vblank on non-existent crtc %d\n",
    crtc);
    - return EINVAL;
    + return -EINVAL;
    }

    return 0;
    --
    --
    To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
    the body of a message to majordomo@vger.kernel.org
    More majordomo info at http://vger.kernel.org/majordomo-info.html
    Please read the FAQ at http://www.tux.org/lkml/

  2. Re: [PATCH] drm/radeon: radeon_enable_vblank should return negative error

    On Sunday, May 11, 2008 12:49 pm Marcin Slusarz wrote:
    > radeon_enable_vblank <- drm_vblank_get <- drm_wait_vblank
    > and drm_wait_vblank returns negative values on error
    >
    > Signed-off-by: Marcin Slusarz
    > Cc: Dave Airlie
    > Cc: Jesse Barnes
    > ---
    > compile tested only


    Looks good, Marcin. Andrew should probably just push it upstream.

    Acked-by: Jesse Barnes

    Thanks,
    Jesse
    --
    To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
    the body of a message to majordomo@vger.kernel.org
    More majordomo info at http://vger.kernel.org/majordomo-info.html
    Please read the FAQ at http://www.tux.org/lkml/

+ Reply to Thread