[PATCH] x86: wakeup.lds.S - section ordering fix - Kernel

This is a discussion on [PATCH] x86: wakeup.lds.S - section ordering fix - Kernel ; To allow linker to catch sections overlapping we have to declare them in appropriate order. Signed-off-by: Cyrill Gorcunov --- Please test and review Index: linux-2.6.git/arch/x86/kernel/acpi/realmode/wakeup.lds.S ================================================== ================= --- linux-2.6.git.orig/arch/x86/kernel/acpi/realmode/wakeup.lds.S 2008-05-11 20:21:58.000000000 +0400 +++ linux-2.6.git/arch/x86/kernel/acpi/realmode/wakeup.lds.S 2008-05-11 22:34:42.000000000 +0400 @@ -12,11 +12,6 ...

+ Reply to Thread
Results 1 to 4 of 4

Thread: [PATCH] x86: wakeup.lds.S - section ordering fix

  1. [PATCH] x86: wakeup.lds.S - section ordering fix

    To allow linker to catch sections overlapping we have to declare
    them in appropriate order.

    Signed-off-by: Cyrill Gorcunov
    ---

    Please test and review

    Index: linux-2.6.git/arch/x86/kernel/acpi/realmode/wakeup.lds.S
    ================================================== =================
    --- linux-2.6.git.orig/arch/x86/kernel/acpi/realmode/wakeup.lds.S 2008-05-11 20:21:58.000000000 +0400
    +++ linux-2.6.git/arch/x86/kernel/acpi/realmode/wakeup.lds.S 2008-05-11 22:34:42.000000000 +0400
    @@ -12,11 +12,6 @@ ENTRY(_start)

    SECTIONS
    {
    - . = HEADER_OFFSET;
    - .header : {
    - *(.header)
    - }
    -
    . = 0;
    .text : {
    *(.text*)
    @@ -50,6 +45,11 @@ SECTIONS
    __bss_end = .;
    }

    + . = HEADER_OFFSET;
    + .header : {
    + *(.header)
    + }
    +
    . = ALIGN(16);
    _end = .;

    --
    To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
    the body of a message to majordomo@vger.kernel.org
    More majordomo info at http://vger.kernel.org/majordomo-info.html
    Please read the FAQ at http://www.tux.org/lkml/

  2. Re: [PATCH] x86: wakeup.lds.S - section ordering fix

    On Sun 2008-05-11 22:46:38, Cyrill Gorcunov wrote:
    > To allow linker to catch sections overlapping we have to declare
    > them in appropriate order.
    >
    > Signed-off-by: Cyrill Gorcunov
    > ---
    >
    > Please test and review


    Looks okay to me, but I can't easily test it right now.

    But I think Rafael tested identical patch, you can add my ACK in such
    case.

    Pavel

    > Index: linux-2.6.git/arch/x86/kernel/acpi/realmode/wakeup.lds.S
    > ================================================== =================
    > --- linux-2.6.git.orig/arch/x86/kernel/acpi/realmode/wakeup.lds.S 2008-05-11 20:21:58.000000000 +0400
    > +++ linux-2.6.git/arch/x86/kernel/acpi/realmode/wakeup.lds.S 2008-05-11 22:34:42.000000000 +0400
    > @@ -12,11 +12,6 @@ ENTRY(_start)
    >
    > SECTIONS
    > {
    > - . = HEADER_OFFSET;
    > - .header : {
    > - *(.header)
    > - }
    > -
    > . = 0;
    > .text : {
    > *(.text*)
    > @@ -50,6 +45,11 @@ SECTIONS
    > __bss_end = .;
    > }
    >
    > + . = HEADER_OFFSET;
    > + .header : {
    > + *(.header)
    > + }
    > +
    > . = ALIGN(16);
    > _end = .;
    >


    --
    (english) http://www.livejournal.com/~pavelmachek
    (cesky, pictures) http://atrey.karlin.mff.cuni.cz/~pav...rses/blog.html
    --
    To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
    the body of a message to majordomo@vger.kernel.org
    More majordomo info at http://vger.kernel.org/majordomo-info.html
    Please read the FAQ at http://www.tux.org/lkml/

  3. Re: [PATCH] x86: wakeup.lds.S - section ordering fix

    [Pavel Machek - Mon, May 12, 2008 at 03:53:43PM +0200]
    | On Sun 2008-05-11 22:46:38, Cyrill Gorcunov wrote:
    | > To allow linker to catch sections overlapping we have to declare
    | > them in appropriate order.
    | >
    | > Signed-off-by: Cyrill Gorcunov
    | > ---
    | >
    | > Please test and review
    |
    | Looks okay to me, but I can't easily test it right now.
    |
    | But I think Rafael tested identical patch, you can add my ACK in such
    | case.
    |
    | Pavel
    |

    Yes, Rafael tested the same (in contents) patch. Actually there was
    a bit time-screwed situation - I've proposed a solution, Peter was
    agreed with, I said him that I'll cook a patch, meanwhile I've got an internet
    connection problem, and at moment Rafael tested the same patch he made by own.
    A bit funny situation So I think in this patch should be then:

    Signed-off-by: Rafael J. Wysocki
    Signed-off-by: Cyrill Gorcunov
    Acked-by: Pavel Machek

    Anyway, thanks to all being involved

    - Cyrill -
    --
    To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
    the body of a message to majordomo@vger.kernel.org
    More majordomo info at http://vger.kernel.org/majordomo-info.html
    Please read the FAQ at http://www.tux.org/lkml/

  4. Re: [PATCH] x86: wakeup.lds.S - section ordering fix


    * Cyrill Gorcunov wrote:

    > [Pavel Machek - Mon, May 12, 2008 at 03:53:43PM +0200]
    > | On Sun 2008-05-11 22:46:38, Cyrill Gorcunov wrote:
    > | > To allow linker to catch sections overlapping we have to declare
    > | > them in appropriate order.
    > | >
    > | > Signed-off-by: Cyrill Gorcunov
    > | > ---
    > | >
    > | > Please test and review
    > |
    > | Looks okay to me, but I can't easily test it right now.
    > |
    > | But I think Rafael tested identical patch, you can add my ACK in such
    > | case.
    >
    > Yes, Rafael tested the same (in contents) patch. Actually there was a
    > bit time-screwed situation - I've proposed a solution, Peter was
    > agreed with, I said him that I'll cook a patch, meanwhile I've got an
    > internet connection problem, and at moment Rafael tested the same
    > patch he made by own. A bit funny situation So I think in this
    > patch should be then:


    applied, thanks.

    Ingo
    --
    To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
    the body of a message to majordomo@vger.kernel.org
    More majordomo info at http://vger.kernel.org/majordomo-info.html
    Please read the FAQ at http://www.tux.org/lkml/

+ Reply to Thread