Remove unused variable "cpu" from arch/x86/xen/setup.c - Kernel

This is a discussion on Remove unused variable "cpu" from arch/x86/xen/setup.c - Kernel ; Remove unused variable "cpu" from arch/x86/xen/setup.c Signed-off-by : Manish Katiyar (mkatiyar@gmail.com) diff -Nur a/x86/xen/setup.c b/arch/x86/xen/setup.c --- a/arch/x86/xen/setup.c 2008-04-26 20:36:15.000000000 +0530 +++ b/arch/x86/xen/setup.c 2008-05-11 22:50:35.000000000 +0530 @@ -71,7 +71,6 @@ void xen_enable_sysenter(void) { - int cpu = smp_processor_id(); extern void xen_sysenter_target(void); ...

+ Reply to Thread
Results 1 to 2 of 2

Thread: Remove unused variable "cpu" from arch/x86/xen/setup.c

  1. Remove unused variable "cpu" from arch/x86/xen/setup.c

    Remove unused variable "cpu" from arch/x86/xen/setup.c


    Signed-off-by : Manish Katiyar (mkatiyar@gmail.com)

    diff -Nur a/x86/xen/setup.c b/arch/x86/xen/setup.c
    --- a/arch/x86/xen/setup.c 2008-04-26 20:36:15.000000000 +0530
    +++ b/arch/x86/xen/setup.c 2008-05-11 22:50:35.000000000 +0530
    @@ -71,7 +71,6 @@

    void xen_enable_sysenter(void)
    {
    - int cpu = smp_processor_id();
    extern void xen_sysenter_target(void);
    /* Mask events on entry, even though they get enabled immediately */
    static struct callback_register sysenter = {


    --
    Thanks & Regards,
    ********************************************
    Manish Katiyar ( http://mkatiyar.googlepages.com )
    3rd Floor, Fair Winds Block
    EGL Software Park
    Off Intermediate Ring Road
    Bangalore 560071, India
    ***********************************************
    --
    To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
    the body of a message to majordomo@vger.kernel.org
    More majordomo info at http://vger.kernel.org/majordomo-info.html
    Please read the FAQ at http://www.tux.org/lkml/

  2. Re: Remove unused variable "cpu" from arch/x86/xen/setup.c


    * Manish Katiyar wrote:

    > Remove unused variable "cpu" from arch/x86/xen/setup.c

    it's not unused:

    > void xen_enable_sysenter(void)
    > {
    > - int cpu = smp_processor_id();
    > extern void xen_sysenter_target(void);
    > /* Mask events on entry, even though they get enabled immediately */
    > static struct callback_register sysenter = {

    if (!boot_cpu_has(X86_FEATURE_SEP) ||
    HYPERVISOR_callback_op(CALLBACKOP_register, &sysenter) != 0) {
    clear_cpu_cap(&cpu_data(cpu), X86_FEATURE_SEP);
    ^^^^^^^^^^^^^^
    clear_cpu_cap(&boot_cpu_data, X86_FEATURE_SEP);
    }

    if it generates an unused variable warning on UP then per_cpu() needs to
    be fixed to do a (void)(cpu) to indicate use of that variable.

    Ingo
    --
    To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
    the body of a message to majordomo@vger.kernel.org
    More majordomo info at http://vger.kernel.org/majordomo-info.html
    Please read the FAQ at http://www.tux.org/lkml/
+ Reply to Thread
« Re: [Xen-devel] Re: [PATCH] xen: remove support for non-PAE 32-bit | [PATCH] Make for_each_cpu_mask a bit smaller »