[PATCH] x86 user_regset_view table fix for ia32 on 64-bit - Kernel

This is a discussion on [PATCH] x86 user_regset_view table fix for ia32 on 64-bit - Kernel ; The user_regset_view table for the 32-bit regsets on the 64-bit build had the wrong sizes for the FP regsets. This bug had no user-visible effect (just on kernel modules using the user_regset interfaces and the like). But the fix is ...

+ Reply to Thread
Results 1 to 2 of 2

Thread: [PATCH] x86 user_regset_view table fix for ia32 on 64-bit

  1. [PATCH] x86 user_regset_view table fix for ia32 on 64-bit

    The user_regset_view table for the 32-bit regsets on the 64-bit build had
    the wrong sizes for the FP regsets. This bug had no user-visible effect
    (just on kernel modules using the user_regset interfaces and the like).
    But the fix is trivial and risk-free.

    Signed-off-by: Roland McGrath
    ---
    arch/x86/kernel/ptrace.c | 7 +++++--
    1 files changed, 5 insertions(+), 2 deletions(-)

    diff --git a/arch/x86/kernel/ptrace.c b/arch/x86/kernel/ptrace.c
    index fb03ef3..a7835f2 100644
    --- a/arch/x86/kernel/ptrace.c
    +++ b/arch/x86/kernel/ptrace.c
    @@ -1303,6 +1303,9 @@ static const struct user_regset_view user_x86_64_view = {
    #define genregs32_get genregs_get
    #define genregs32_set genregs_set

    +#define user_i387_ia32_struct user_i387_struct
    +#define user32_fxsr_struct user_fxsr_struct
    +
    #endif /* CONFIG_X86_64 */

    #if defined CONFIG_X86_32 || defined CONFIG_IA32_EMULATION
    @@ -1315,13 +1318,13 @@ static const struct user_regset x86_32_regsets[] = {
    },
    [REGSET_FP] = {
    .core_note_type = NT_PRFPREG,
    - .n = sizeof(struct user_i387_struct) / sizeof(u32),
    + .n = sizeof(struct user_i387_ia32_struct) / sizeof(u32),
    .size = sizeof(u32), .align = sizeof(u32),
    .active = fpregs_active, .get = fpregs_get, .set = fpregs_set
    },
    [REGSET_XFP] = {
    .core_note_type = NT_PRXFPREG,
    - .n = sizeof(struct user_i387_struct) / sizeof(u32),
    + .n = sizeof(struct user32_fxsr_struct) / sizeof(u32),
    .size = sizeof(u32), .align = sizeof(u32),
    .active = xfpregs_active, .get = xfpregs_get, .set = xfpregs_set
    },
    --
    To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
    the body of a message to majordomo@vger.kernel.org
    More majordomo info at http://vger.kernel.org/majordomo-info.html
    Please read the FAQ at http://www.tux.org/lkml/

  2. Re: [PATCH] x86 user_regset_view table fix for ia32 on 64-bit


    * Roland McGrath wrote:

    > The user_regset_view table for the 32-bit regsets on the 64-bit build
    > had the wrong sizes for the FP regsets. This bug had no user-visible
    > effect (just on kernel modules using the user_regset interfaces and
    > the like). But the fix is trivial and risk-free.


    applied, thanks Roland.

    Ingo
    --
    To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
    the body of a message to majordomo@vger.kernel.org
    More majordomo info at http://vger.kernel.org/majordomo-info.html
    Please read the FAQ at http://www.tux.org/lkml/

+ Reply to Thread