On Wed, 30 Apr 2008 15:03:41 -0700
Harvey Harrison wrote:

> drivers/usb/host/ohci-sm501.c:93:24: warning: Using plain integer as NULL pointer
> drivers/usb/gadget/amd5536udc.c:3254:9: warning: Using plain integer as NULL pointer
> drivers/usb/gadget/amd5536udc.c:3267:9: warning: Using plain integer as NULL pointer
> drivers/usb/gadget/amd5536udc.c:3277:9: warning: Using plain integer as NULL pointer
> drivers/usb/gadget/amd5536udc.c:3285:9: warning: Using plain integer as NULL pointer
> drivers/usb/gadget/amd5536udc.c:3293:9: warning: Using plain integer as NULL pointer

I'd suggest that you mention "sparse" in the title and/or changelog.
Otherwise people wonder what's up with their gcc.

--
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@vger.kernel.org
More majordomo info at http://vger.kernel.org/majordomo-info.html
Please read the FAQ at http://www.tux.org/lkml/

On Thu, 2008-05-01 at 16:02 -0700, Andrew Morton wrote:
> On Wed, 30 Apr 2008 15:03:41 -0700
> Harvey Harrison wrote:
>
> > drivers/usb/host/ohci-sm501.c:93:24: warning: Using plain integer as NULL pointer
> > drivers/usb/gadget/amd5536udc.c:3254:9: warning: Using plain integer as NULL pointer
> > drivers/usb/gadget/amd5536udc.c:3267:9: warning: Using plain integer as NULL pointer
> > drivers/usb/gadget/amd5536udc.c:3277:9: warning: Using plain integer as NULL pointer
> > drivers/usb/gadget/amd5536udc.c:3285:9: warning: Using plain integer as NULL pointer
> > drivers/usb/gadget/amd5536udc.c:3293:9: warning: Using plain integer as NULL pointer
>
> I'd suggest that you mention "sparse" in the title and/or changelog.
> Otherwise people wonder what's up with their gcc.
>

Noted, will do so in future.

Harvey

--
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@vger.kernel.org
More majordomo info at http://vger.kernel.org/majordomo-info.html
Please read the FAQ at http://www.tux.org/lkml/

This is a note to let you know that I've just added the patch titled

Subject: usb: fix integer as NULL pointer warnings found by sparse

to my gregkh-2.6 tree. Its filename is

usb-fix-integer-as-null-pointer-warnings-found-by-sparse.patch

This tree can be found at
http://www.kernel.org/pub/linux/kern...h-2.6/patches/


From harvey.harrison@gmail.com Wed Apr 30 15:03:34 2008
From: Harvey Harrison
Date: Wed, 30 Apr 2008 15:03:41 -0700
Subject: usb: fix integer as NULL pointer warnings found by sparse
To: Andrew Morton
Cc: Greg KH , LKML
Message-ID: <1209593021.24729.113.camel@brick>


drivers/usb/host/ohci-sm501.c:93:24: warning: Using plain integer as NULL pointer
drivers/usb/gadget/amd5536udc.c:3254:9: warning: Using plain integer as NULL pointer
drivers/usb/gadget/amd5536udc.c:3267:9: warning: Using plain integer as NULL pointer
drivers/usb/gadget/amd5536udc.c:3277:9: warning: Using plain integer as NULL pointer
drivers/usb/gadget/amd5536udc.c:3285:9: warning: Using plain integer as NULL pointer
drivers/usb/gadget/amd5536udc.c:3293:9: warning: Using plain integer as NULL pointer

Signed-off-by: Harvey Harrison
Signed-off-by: Greg Kroah-Hartman

---
drivers/usb/gadget/amd5536udc.c | 10 +++++-----
drivers/usb/host/ohci-sm501.c | 2 +-
2 files changed, 6 insertions(+), 6 deletions(-)

--- a/drivers/usb/gadget/amd5536udc.c
+++ b/drivers/usb/gadget/amd5536udc.c
@@ -3251,7 +3251,7 @@ static int udc_pci_probe(
/* pci setup */
if (pci_enable_device(pdev) < 0) {
kfree(dev);
- dev = 0;
+ dev = NULL;
retval = -ENODEV;
goto finished;
}
@@ -3264,7 +3264,7 @@ static int udc_pci_probe(
if (!request_mem_region(resource, len, name)) {
dev_dbg(&pdev->dev, "pci device used already\n");
kfree(dev);
- dev = 0;
+ dev = NULL;
retval = -EBUSY;
goto finished;
}
@@ -3274,7 +3274,7 @@ static int udc_pci_probe(
if (dev->virt_addr == NULL) {
dev_dbg(&pdev->dev, "start address cannot be mapped\n");
kfree(dev);
- dev = 0;
+ dev = NULL;
retval = -EFAULT;
goto finished;
}
@@ -3282,7 +3282,7 @@ static int udc_pci_probe(
if (!pdev->irq) {
dev_err(&dev->pdev->dev, "irq not set\n");
kfree(dev);
- dev = 0;
+ dev = NULL;
retval = -ENODEV;
goto finished;
}
@@ -3290,7 +3290,7 @@ static int udc_pci_probe(
if (request_irq(pdev->irq, udc_irq, IRQF_SHARED, name, dev) != 0) {
dev_dbg(&dev->pdev->dev, "request_irq(%d) fail\n", pdev->irq);
kfree(dev);
- dev = 0;
+ dev = NULL;
retval = -EBUSY;
goto finished;
}
--- a/drivers/usb/host/ohci-sm501.c
+++ b/drivers/usb/host/ohci-sm501.c
@@ -90,7 +90,7 @@ static int ohci_hcd_sm501_drv_probe(stru
struct device *dev = &pdev->dev;
struct resource *res, *mem;
int retval, irq;
- struct usb_hcd *hcd = 0;
+ struct usb_hcd *hcd = NULL;

irq = retval = platform_get_irq(pdev, 0);
if (retval < 0)


Patches currently in gregkh-2.6 which might be from harvey.harrison@gmail.com are

usb.next/usb-fix-integer-as-null-pointer-warnings-found-by-sparse.patch
usb.next/usb-use-get_unaligned_-helpers-for-kl5kusb105-driver.patch
--
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@vger.kernel.org
More majordomo info at http://vger.kernel.org/majordomo-info.html
Please read the FAQ at http://www.tux.org/lkml/