[patch] doc: fix an incorrect suggestion to pass NULL for PCI like buses - Kernel

This is a discussion on [patch] doc: fix an incorrect suggestion to pass NULL for PCI like buses - Kernel ; From: Matti Linnanvuori Fix an incorrect suggestion to pass NULL to pci_alloc_consistent for PCI like buses where devices don't have struct pci_dev (like ISA, EISA). Signed-off-by: Matti Linnanvuori --- This patch is to be applied on top of [patch v3] ...

+ Reply to Thread
Results 1 to 3 of 3

Thread: [patch] doc: fix an incorrect suggestion to pass NULL for PCI like buses

  1. [patch] doc: fix an incorrect suggestion to pass NULL for PCI like buses

    From: Matti Linnanvuori

    Fix an incorrect suggestion to pass NULL to pci_alloc_consistent
    for PCI like buses where devices don't have struct pci_dev (like ISA, EISA).

    Signed-off-by: Matti Linnanvuori

    ---

    This patch is to be applied on top of
    [patch v3] doc: DMA-mapping.txt has undeclared variables [Bug 10397]

    --- linux-2.6/Documentation/DMA-mapping.txt 2008-04-28 19:09:36.124693500 +0300
    +++ linux/Documentation/DMA-mapping.txt 2008-04-28 19:17:07.711024500 +0300
    @@ -317,9 +317,9 @@ you should do:

    cpu_addr = pci_alloc_consistent(pdev, size, &dma_handle);

    -where pdev is a struct pci_dev *. You should pass NULL for PCI like buses
    -where devices don't have struct pci_dev (like ISA, EISA). This may be
    -called in interrupt context.
    +where pdev is a struct pci_dev *. This may be called in interrupt context.
    +You should use dma_alloc_coherent (see DMA-API.txt) for buses
    +where devices don't have struct pci_dev (like ISA, EISA).

    This argument is needed because the DMA translations may be bus
    specific (and often is private to the bus which the device is attached


    __________________________________________________ __________________________________
    Be a better friend, newshound, and
    know-it-all with Yahoo! Mobile. Try it now. http://mobile.yahoo.com/;_ylt=Ahu06i...Dypao8Wcj9tAcJ
    --
    To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
    the body of a message to majordomo@vger.kernel.org
    More majordomo info at http://vger.kernel.org/majordomo-info.html
    Please read the FAQ at http://www.tux.org/lkml/

  2. Re: [patch] doc: fix an incorrect suggestion to pass NULL for PCI like buses

    On Mon, Apr 28, 2008 at 09:33:27AM -0700, Matti Linnanvuori wrote:
    > From: Matti Linnanvuori
    >
    > Fix an incorrect suggestion to pass NULL to pci_alloc_consistent
    > for PCI like buses where devices don't have struct pci_dev (like ISA, EISA).
    >
    > Signed-off-by: Matti Linnanvuori


    Acked-by: Matthew Wilcox

    --
    Intel are signing my paycheques ... these opinions are still mine
    "Bill, look, we understand that you're interested in selling us this
    operating system, but compare it to ours. We can't possibly take such
    a retrograde step."
    --
    To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
    the body of a message to majordomo@vger.kernel.org
    More majordomo info at http://vger.kernel.org/majordomo-info.html
    Please read the FAQ at http://www.tux.org/lkml/

  3. Re: [patch] doc: fix an incorrect suggestion to pass NULL for PCI like buses

    On Monday, April 28, 2008 9:33 am Matti Linnanvuori wrote:
    > From: Matti Linnanvuori
    >
    > Fix an incorrect suggestion to pass NULL to pci_alloc_consistent
    > for PCI like buses where devices don't have struct pci_dev (like ISA,
    > EISA).
    >
    > Signed-off-by: Matti Linnanvuori


    This one was whitespace damaged too, but I fixed it up by hand and applied it.
    Before sending future patches, please fix up your mailer so that the diff is
    preserved...

    Thanks,
    Jesse
    --
    To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
    the body of a message to majordomo@vger.kernel.org
    More majordomo info at http://vger.kernel.org/majordomo-info.html
    Please read the FAQ at http://www.tux.org/lkml/

+ Reply to Thread