[PATCH] x86: fix early-BUG message - Kernel

This is a discussion on [PATCH] x86: fix early-BUG message - Kernel ; From e7402e1c6b56dfb8d389f1faf04b3f03a9ecad33 Mon Sep 17 00:00:00 2001 From: Vegard Nossum Date: Fri, 25 Apr 2008 20:58:34 +0200 Subject: [PATCH] x86: fix early-BUG message The .asciz directive takes any number of strings, but each one is zero- terminated, and string pasting ...

+ Reply to Thread
Results 1 to 2 of 2

Thread: [PATCH] x86: fix early-BUG message

  1. [PATCH] x86: fix early-BUG message

    From e7402e1c6b56dfb8d389f1faf04b3f03a9ecad33 Mon Sep 17 00:00:00 2001
    From: Vegard Nossum
    Date: Fri, 25 Apr 2008 20:58:34 +0200
    Subject: [PATCH] x86: fix early-BUG message

    The .asciz directive takes any number of strings, but each one is zero-
    terminated, and string pasting is not done as in C. That results in only the
    first line being output.

    Replace .asciz with multiple .ascii directives and terminate with .asciz.

    Signed-off-by: Vegard Nossum
    ---
    arch/x86/kernel/head_32.S | 19 ++++++++++---------
    1 files changed, 10 insertions(+), 9 deletions(-)

    diff --git a/arch/x86/kernel/head_32.S b/arch/x86/kernel/head_32.S
    index 74d87ea..51c973e 100644
    --- a/arch/x86/kernel/head_32.S
    +++ b/arch/x86/kernel/head_32.S
    @@ -657,15 +657,16 @@ int_msg:
    .asciz "Unknown interrupt or fault at EIP %p %p %p\n"

    fault_msg:
    - .asciz \
    -/* fault info: */ "BUG: Int %d: CR2 %p\n" \
    -/* pusha regs: */ " EDI %p ESI %p EBP %p ESP %p\n" \
    - " EBX %p EDX %p ECX %p EAX %p\n" \
    -/* fault frame: */ " err %p EIP %p CS %p flg %p\n" \
    - \
    - "Stack: %p %p %p %p %p %p %p %p\n" \
    - " %p %p %p %p %p %p %p %p\n" \
    - " %p %p %p %p %p %p %p %p\n"
    +/* fault info: */
    + .ascii "BUG: Int %d: CR2 %p\n"
    +/* pusha regs: */
    + .ascii " EDI %p ESI %p EBP %p ESP %p\n"
    + .ascii " EBX %p EDX %p ECX %p EAX %p\n"
    +/* fault frame: */
    + .ascii " err %p EIP %p CS %p flg %p\n"
    + .ascii "Stack: %p %p %p %p %p %p %p %p\n"
    + .ascii " %p %p %p %p %p %p %p %p\n"
    + .asciz " %p %p %p %p %p %p %p %p\n"

    #include "../../x86/xen/xen-head.S"

    --
    1.5.4.1

    --
    To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
    the body of a message to majordomo@vger.kernel.org
    More majordomo info at http://vger.kernel.org/majordomo-info.html
    Please read the FAQ at http://www.tux.org/lkml/

  2. Re: [PATCH] x86: fix early-BUG message


    * Vegard Nossum wrote:

    > The .asciz directive takes any number of strings, but each one is
    > zero- terminated, and string pasting is not done as in C. That results
    > in only the first line being output.
    >
    > Replace .asciz with multiple .ascii directives and terminate with
    > .asciz.


    applied, thanks Vegard.

    Ingo
    --
    To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
    the body of a message to majordomo@vger.kernel.org
    More majordomo info at http://vger.kernel.org/majordomo-info.html
    Please read the FAQ at http://www.tux.org/lkml/

+ Reply to Thread