[PATCH] list_for_each_rcu must die: audit - Kernel

This is a discussion on [PATCH] list_for_each_rcu must die: audit - Kernel ; All uses of list_for_each_rcu() can be profitably replaced by the easier-to-use list_for_each_entry_rcu(). This patch makes this change for the Audit system, in preparation for removing the list_for_each_rcu() API entirely. Signed_off_by: Paul E. McKenney --- audit_tree.c | 5 ++--- 1 file ...

+ Reply to Thread
Results 1 to 2 of 2

Thread: [PATCH] list_for_each_rcu must die: audit

  1. [PATCH] list_for_each_rcu must die: audit

    All uses of list_for_each_rcu() can be profitably replaced by the
    easier-to-use list_for_each_entry_rcu(). This patch makes this change
    for the Audit system, in preparation for removing the list_for_each_rcu()
    API entirely.

    Signed_off_by: Paul E. McKenney
    ---

    audit_tree.c | 5 ++---
    1 file changed, 2 insertions(+), 3 deletions(-)

    diff -urpNa -X dontdiff linux-2.6.25/kernel/audit_tree.c linux-2.6.25-lfer-audit/kernel/audit_tree.c
    --- linux-2.6.25/kernel/audit_tree.c 2008-04-16 19:49:44.000000000 -0700
    +++ linux-2.6.25-lfer-audit/kernel/audit_tree.c 2008-04-23 18:09:16.000000000 -0700
    @@ -172,10 +172,9 @@ static void insert_hash(struct audit_chu
    struct audit_chunk *audit_tree_lookup(const struct inode *inode)
    {
    struct list_head *list = chunk_hash(inode);
    - struct list_head *pos;
    + struct audit_chunk *p;

    - list_for_each_rcu(pos, list) {
    - struct audit_chunk *p = container_of(pos, struct audit_chunk, hash);
    + list_for_each_entry_rcu(p, list, hash) {
    if (p->watch.inode == inode) {
    get_inotify_watch(&p->watch);
    return p;
    --
    To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
    the body of a message to majordomo@vger.kernel.org
    More majordomo info at http://vger.kernel.org/majordomo-info.html
    Please read the FAQ at http://www.tux.org/lkml/

  2. [PATCH] list_for_each_rcu must die: audit

    All uses of list_for_each_rcu() can be profitably replaced by the
    easier-to-use list_for_each_entry_rcu(). This patch makes this change
    for the Audit system, in preparation for removing the list_for_each_rcu()
    API entirely. This time with well-formed SOB.

    Signed-off-by: Paul E. McKenney
    ---

    audit_tree.c | 5 ++---
    1 file changed, 2 insertions(+), 3 deletions(-)

    diff -urpNa -X dontdiff linux-2.6.25/kernel/audit_tree.c linux-2.6.25-lfer-audit/kernel/audit_tree.c
    --- linux-2.6.25/kernel/audit_tree.c 2008-04-16 19:49:44.000000000 -0700
    +++ linux-2.6.25-lfer-audit/kernel/audit_tree.c 2008-04-23 18:09:16.000000000 -0700
    @@ -172,10 +172,9 @@ static void insert_hash(struct audit_chu
    struct audit_chunk *audit_tree_lookup(const struct inode *inode)
    {
    struct list_head *list = chunk_hash(inode);
    - struct list_head *pos;
    + struct audit_chunk *p;

    - list_for_each_rcu(pos, list) {
    - struct audit_chunk *p = container_of(pos, struct audit_chunk, hash);
    + list_for_each_entry_rcu(p, list, hash) {
    if (p->watch.inode == inode) {
    get_inotify_watch(&p->watch);
    return p;
    --
    To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
    the body of a message to majordomo@vger.kernel.org
    More majordomo info at http://vger.kernel.org/majordomo-info.html
    Please read the FAQ at http://www.tux.org/lkml/

+ Reply to Thread