Re: [git pull] scheduler changes for v2.6.26 - Kernel

This is a discussion on Re: [git pull] scheduler changes for v2.6.26 - Kernel ; On 4/19/08, Ingo Molnar wrote: > Guillaume Chazarain (1): > sched: fix rq->clock overflows detection with CONFIG_NO_HZ This one should have been dropped (per http://lkml.org/lkml/2008/1/25/413 ) I don't like rq->clock relying on jiffies, and you already fixed the original manifestation ...

+ Reply to Thread
Results 1 to 3 of 3

Thread: Re: [git pull] scheduler changes for v2.6.26

  1. Re: [git pull] scheduler changes for v2.6.26

    On 4/19/08, Ingo Molnar wrote:
    > Guillaume Chazarain (1):
    > sched: fix rq->clock overflows detection with CONFIG_NO_HZ


    This one should have been dropped (per http://lkml.org/lkml/2008/1/25/413)
    I don't like rq->clock relying on jiffies, and you already fixed the
    original manifestation of the problem in:

    commit 2997c8c4a0b179e8b834a7f30ba4323f2c60ccf4
    Author: Ingo Molnar
    Date: Fri Jan 11 13:35:54 2008 +0100

    block: fix blktrace timestamps

    David Dillow reported broken blktrace timestamps. The reason
    is cpu_clock() which is not a global time source.

    Fix bkltrace timestamps by using ktime_get() like the networking
    code does for packet timestamps. This also removes a whole lot
    of complexity from bkltrace.c and shrinks the code by 500 bytes:

    text data bss dec hex filename
    2888 124 44 3056 bf0 blktrace.o.before
    2390 116 44 2550 9f6 blktrace.o.after

    Signed-off-by: Ingo Molnar
    Signed-off-by: Jens Axboe


    --
    Guillaume
    --
    To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
    the body of a message to majordomo@vger.kernel.org
    More majordomo info at http://vger.kernel.org/majordomo-info.html
    Please read the FAQ at http://www.tux.org/lkml/

  2. Re: [git pull] scheduler changes for v2.6.26


    * Guillaume Chazarain wrote:

    > On 4/19/08, Ingo Molnar wrote:
    > > Guillaume Chazarain (1):
    > > sched: fix rq->clock overflows detection with CONFIG_NO_HZ

    >
    > This one should have been dropped (per
    > http://lkml.org/lkml/2008/1/25/413) I don't like rq->clock relying on
    > jiffies, and you already fixed the original manifestation of the
    > problem in:


    no, it was still needed on a testbox of Peter on nohz.

    Ingo
    --
    To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
    the body of a message to majordomo@vger.kernel.org
    More majordomo info at http://vger.kernel.org/majordomo-info.html
    Please read the FAQ at http://www.tux.org/lkml/

  3. Re: [git pull] scheduler changes for v2.6.26

    On Sat, 2008-04-19 at 20:49 +0200, Ingo Molnar wrote:
    > * Guillaume Chazarain wrote:
    >
    > > On 4/19/08, Ingo Molnar wrote:
    > > > Guillaume Chazarain (1):
    > > > sched: fix rq->clock overflows detection with CONFIG_NO_HZ

    > >
    > > This one should have been dropped (per
    > > http://lkml.org/lkml/2008/1/25/413) I don't like rq->clock relying on
    > > jiffies, and you already fixed the original manifestation of the
    > > problem in:

    >
    > no, it was still needed on a testbox of Peter on nohz.


    Yeah, I got a rq->clock rate of about 500ms every second. With this
    patch I got the full 1000.

    --
    To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
    the body of a message to majordomo@vger.kernel.org
    More majordomo info at http://vger.kernel.org/majordomo-info.html
    Please read the FAQ at http://www.tux.org/lkml/

+ Reply to Thread