[PATCH 1/3] siimage: do clocking register posting earlier in setup_mmio_siimage() - Kernel

This is a discussion on [PATCH 1/3] siimage: do clocking register posting earlier in setup_mmio_siimage() - Kernel ; Do clocking register posting earlier in setup_mmio_siimage() to match code in init_chipset_siimage(). This is a preparation for the next patch which merges PCI and MMIO code paths together. Signed-off-by: Bartlomiej Zolnierkiewicz --- drivers/ide/pci/siimage.c | 6 +++--- 1 file changed, 3 ...

+ Reply to Thread
Results 1 to 2 of 2

Thread: [PATCH 1/3] siimage: do clocking register posting earlier in setup_mmio_siimage()

  1. [PATCH 1/3] siimage: do clocking register posting earlier in setup_mmio_siimage()

    Do clocking register posting earlier in setup_mmio_siimage()
    to match code in init_chipset_siimage().

    This is a preparation for the next patch which merges PCI and MMIO
    code paths together.

    Signed-off-by: Bartlomiej Zolnierkiewicz
    ---
    drivers/ide/pci/siimage.c | 6 +++---
    1 file changed, 3 insertions(+), 3 deletions(-)

    Index: b/drivers/ide/pci/siimage.c
    ================================================== =================
    --- a/drivers/ide/pci/siimage.c
    +++ b/drivers/ide/pci/siimage.c
    @@ -521,7 +521,9 @@ static unsigned int setup_mmio_siimage (
    writeb(tmpbyte & ~0x20, ioaddr + 0x4A);
    break;
    }
    -
    +
    + tmpbyte = readb(ioaddr + 0x4A);
    +
    writeb( 0x72, ioaddr + 0xA1);
    writew( 0x328A, ioaddr + 0xA2);
    writel(0x62DD62DD, ioaddr + 0xA4);
    @@ -540,8 +542,6 @@ static unsigned int setup_mmio_siimage (
    writel(0x00680000, ioaddr + 0x1C8);
    }

    - tmpbyte = readb(ioaddr + 0x4A);
    -
    proc_reports_siimage(dev, (tmpbyte>>4), name);
    return 1;
    }
    --
    To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
    the body of a message to majordomo@vger.kernel.org
    More majordomo info at http://vger.kernel.org/majordomo-info.html
    Please read the FAQ at http://www.tux.org/lkml/

  2. Re: [PATCH 1/3] siimage: do clocking register posting earlier in setup_mmio_siimage()

    Bartlomiej Zolnierkiewicz wrote:

    > Do clocking register posting earlier in setup_mmio_siimage()
    > to match code in init_chipset_siimage().


    > This is a preparation for the next patch which merges PCI and MMIO
    > code paths together.


    > Signed-off-by: Bartlomiej Zolnierkiewicz


    Acked-by: Sergei Shtylyov

    MBR, Sergei
    --
    To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
    the body of a message to majordomo@vger.kernel.org
    More majordomo info at http://vger.kernel.org/majordomo-info.html
    Please read the FAQ at http://www.tux.org/lkml/

+ Reply to Thread