[PATCH] oom_kill: remove unused parameter in badness() - Kernel

This is a discussion on [PATCH] oom_kill: remove unused parameter in badness() - Kernel ; In commit 4c4a22148909e4c003562ea7ffe0a06e26919e3c, we moved the memcontroller-related code from badness() to select_bad_process(), so the parameter 'mem' in badness() is unused now. Signed-off-by: Li Zefan --- mm/oom_kill.c | 5 ++--- 1 files changed, 2 insertions(+), 3 deletions(-) diff --git a/mm/oom_kill.c b/mm/oom_kill.c ...

+ Reply to Thread
Results 1 to 2 of 2

Thread: [PATCH] oom_kill: remove unused parameter in badness()

  1. [PATCH] oom_kill: remove unused parameter in badness()

    In commit 4c4a22148909e4c003562ea7ffe0a06e26919e3c, we moved the
    memcontroller-related code from badness() to select_bad_process(),
    so the parameter 'mem' in badness() is unused now.

    Signed-off-by: Li Zefan
    ---
    mm/oom_kill.c | 5 ++---
    1 files changed, 2 insertions(+), 3 deletions(-)

    diff --git a/mm/oom_kill.c b/mm/oom_kill.c
    index f255eda..8be1baf 100644
    --- a/mm/oom_kill.c
    +++ b/mm/oom_kill.c
    @@ -53,8 +53,7 @@ static DEFINE_SPINLOCK(zone_scan_mutex);
    * of least surprise ... (be careful when you change it)
    */

    -unsigned long badness(struct task_struct *p, unsigned long uptime,
    - struct mem_cgroup *mem)
    +unsigned long badness(struct task_struct *p, unsigned long uptime)
    {
    unsigned long points, cpu_time, run_time, s;
    struct mm_struct *mm;
    @@ -254,7 +253,7 @@ static struct task_struct *select_bad_process(unsigned long *ppoints,
    if (p->oomkilladj == OOM_DISABLE)
    continue;

    - points = badness(p, uptime.tv_sec, mem);
    + points = badness(p, uptime.tv_sec);
    if (points > *ppoints || !chosen) {
    chosen = p;
    *ppoints = points;
    --
    1.5.4.rc3
    --
    To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
    the body of a message to majordomo@vger.kernel.org
    More majordomo info at http://vger.kernel.org/majordomo-info.html
    Please read the FAQ at http://www.tux.org/lkml/

  2. Re: [PATCH] oom_kill: remove unused parameter in badness()

    Li Zefan wrote:
    > In commit 4c4a22148909e4c003562ea7ffe0a06e26919e3c, we moved the
    > memcontroller-related code from badness() to select_bad_process(),
    > so the parameter 'mem' in badness() is unused now.
    >
    > Signed-off-by: Li Zefan
    > ---
    > mm/oom_kill.c | 5 ++---
    > 1 files changed, 2 insertions(+), 3 deletions(-)
    >
    > diff --git a/mm/oom_kill.c b/mm/oom_kill.c
    > index f255eda..8be1baf 100644
    > --- a/mm/oom_kill.c
    > +++ b/mm/oom_kill.c
    > @@ -53,8 +53,7 @@ static DEFINE_SPINLOCK(zone_scan_mutex);
    > * of least surprise ... (be careful when you change it)
    > */
    >
    > -unsigned long badness(struct task_struct *p, unsigned long uptime,
    > - struct mem_cgroup *mem)
    > +unsigned long badness(struct task_struct *p, unsigned long uptime)
    > {
    > unsigned long points, cpu_time, run_time, s;
    > struct mm_struct *mm;
    > @@ -254,7 +253,7 @@ static struct task_struct *select_bad_process(unsigned long *ppoints,
    > if (p->oomkilladj == OOM_DISABLE)
    > continue;
    >
    > - points = badness(p, uptime.tv_sec, mem);
    > + points = badness(p, uptime.tv_sec);
    > if (points > *ppoints || !chosen) {
    > chosen = p;
    > *ppoints = points;


    Looks good to be

    Acked-by: Balbir Singh

    --
    Warm Regards,
    Balbir Singh
    Linux Technology Center
    IBM, ISTL
    --
    To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
    the body of a message to majordomo@vger.kernel.org
    More majordomo info at http://vger.kernel.org/majordomo-info.html
    Please read the FAQ at http://www.tux.org/lkml/

+ Reply to Thread