[PATCH] ACPI: check a return value correctly in acpi_power_get_context() - Kernel

This is a discussion on [PATCH] ACPI: check a return value correctly in acpi_power_get_context() - Kernel ; We should check *resource != NULL rather than resource != NULL, which will be always true. Signed-off-by: Li Zefan --- drivers/acpi/power.c | 2 +- 1 files changed, 1 insertions(+), 1 deletions(-) diff --git a/drivers/acpi/power.c b/drivers/acpi/power.c index 76bf6d9..f2a76ac 100644 --- a/drivers/acpi/power.c ...

+ Reply to Thread
Results 1 to 2 of 2

Thread: [PATCH] ACPI: check a return value correctly in acpi_power_get_context()

  1. [PATCH] ACPI: check a return value correctly in acpi_power_get_context()

    We should check *resource != NULL rather than resource != NULL,
    which will be always true.

    Signed-off-by: Li Zefan
    ---
    drivers/acpi/power.c | 2 +-
    1 files changed, 1 insertions(+), 1 deletions(-)

    diff --git a/drivers/acpi/power.c b/drivers/acpi/power.c
    index 76bf6d9..f2a76ac 100644
    --- a/drivers/acpi/power.c
    +++ b/drivers/acpi/power.c
    @@ -121,7 +121,7 @@ acpi_power_get_context(acpi_handle handle,
    }

    *resource = acpi_driver_data(device);
    - if (!resource)
    + if (!*resource)
    return -ENODEV;

    return 0;
    --
    1.5.4.rc3

    --
    To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
    the body of a message to majordomo@vger.kernel.org
    More majordomo info at http://vger.kernel.org/majordomo-info.html
    Please read the FAQ at http://www.tux.org/lkml/

  2. Re: [PATCH] ACPI: check a return value correctly in acpi_power_get_context()

    On Mon, 2008-04-07 at 16:57 +0800, Li Zefan wrote:
    > We should check *resource != NULL rather than resource != NULL,
    > which will be always true.
    >
    > Signed-off-by: Li Zefan
    > ---
    > drivers/acpi/power.c | 2 +-
    > 1 files changed, 1 insertions(+), 1 deletions(-)
    >
    > diff --git a/drivers/acpi/power.c b/drivers/acpi/power.c
    > index 76bf6d9..f2a76ac 100644
    > --- a/drivers/acpi/power.c
    > +++ b/drivers/acpi/power.c
    > @@ -121,7 +121,7 @@ acpi_power_get_context(acpi_handle handle,
    > }
    >
    > *resource = acpi_driver_data(device);
    > - if (!resource)
    > + if (!*resource)
    > return -ENODEV;
    >
    > return 0;

    agreed.


    --
    To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
    the body of a message to majordomo@vger.kernel.org
    More majordomo info at http://vger.kernel.org/majordomo-info.html
    Please read the FAQ at http://www.tux.org/lkml/

+ Reply to Thread