[PATCH] x86: remove superfluous initialisation in boot code. - Kernel

This is a discussion on [PATCH] x86: remove superfluous initialisation in boot code. - Kernel ; x86: remove superfluous initialisation in boot code. In arch/x86/boot/compressed/misc.c, the variable vidmem is the only variable that ends up in de data segment. It's also superfluous, because the first thing the code does is: if (RM_SCREEN_INFO.orig_video_mode == 7) { vidmem ...

+ Reply to Thread
Results 1 to 4 of 4

Thread: [PATCH] x86: remove superfluous initialisation in boot code.

  1. [PATCH] x86: remove superfluous initialisation in boot code.

    x86: remove superfluous initialisation in boot code.

    In arch/x86/boot/compressed/misc.c, the variable vidmem is
    the only variable that ends up in de data segment. It's also
    superfluous, because the first thing the code does is:

    if (RM_SCREEN_INFO.orig_video_mode == 7) {
    vidmem = (char *) 0xb0000;
    vidport = 0x3b4;
    } else {
    vidmem = (char *) 0xb8000;
    vidport = 0x3d4;
    }

    This patch removes the initialisation.

    ---

    Tested on qemu (i386 and x86_64). The boot messages still
    appear as usual:

    Decompressing Linux... Parsing ELF... done.
    Booting the kernel.

    Greetings,
    Alexander

    arch/x86/boot/compressed/misc.c | 2 +-
    1 files changed, 1 insertions(+), 1 deletions(-)

    diff --git a/arch/x86/boot/compressed/misc.c b/arch/x86/boot/compressed/misc.c
    index 9470a05..dad4e69 100644
    --- a/arch/x86/boot/compressed/misc.c
    +++ b/arch/x86/boot/compressed/misc.c
    @@ -223,7 +223,7 @@ static memptr free_mem_end_ptr;
    #define HEAP_SIZE 0x4000
    #endif

    -static char *vidmem = (char *)0xb8000;
    +static char *vidmem;
    static int vidport;
    static int lines, cols;

    --
    To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
    the body of a message to majordomo@vger.kernel.org
    More majordomo info at http://vger.kernel.org/majordomo-info.html
    Please read the FAQ at http://www.tux.org/lkml/

  2. Re: [PATCH] x86: remove superfluous initialisation in boot code.


    * Alexander van Heukelum wrote:

    > --- a/arch/x86/boot/compressed/misc.c
    > +++ b/arch/x86/boot/compressed/misc.c
    > @@ -223,7 +223,7 @@ static memptr free_mem_end_ptr;
    > #define HEAP_SIZE 0x4000
    > #endif
    >
    > -static char *vidmem = (char *)0xb8000;
    > +static char *vidmem;
    > static int vidport;


    thanks, applied. (Btw., you forgot your signoff line - not a big deal
    for a small fix like this but it's best to always include it for patches
    you'd like to see go upstream.)

    Ingo
    --
    To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
    the body of a message to majordomo@vger.kernel.org
    More majordomo info at http://vger.kernel.org/majordomo-info.html
    Please read the FAQ at http://www.tux.org/lkml/

  3. Re: [PATCH] x86: remove superfluous initialisation in boot code.


    On Mon, 7 Apr 2008 09:46:14 +0200, "Ingo Molnar" said:
    >
    > * Alexander van Heukelum wrote:
    >
    > > --- a/arch/x86/boot/compressed/misc.c
    > > +++ b/arch/x86/boot/compressed/misc.c
    > > @@ -223,7 +223,7 @@ static memptr free_mem_end_ptr;
    > > #define HEAP_SIZE 0x4000
    > > #endif
    > >
    > > -static char *vidmem = (char *)0xb8000;
    > > +static char *vidmem;
    > > static int vidport;

    >
    > thanks, applied. (Btw., you forgot your signoff line - not a big deal
    > for a small fix like this but it's best to always include it for patches
    > you'd like to see go upstream.)


    Hmm... I knew I had forgotten something. So I did another round of tests
    to see if it was working correctly :-/.

    If you like, you can add:
    Signed-off-by: Alexander van Heukelum

    Greetings,
    Alexander

    > Ingo

    --
    Alexander van Heukelum
    heukelum@fastmail.fm

    --
    http://www.fastmail.fm - And now for something completely different…

    --
    To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
    the body of a message to majordomo@vger.kernel.org
    More majordomo info at http://vger.kernel.org/majordomo-info.html
    Please read the FAQ at http://www.tux.org/lkml/

  4. (no subject)

    unsubscribe linux-kernel
    --
    To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
    the body of a message to majordomo@vger.kernel.org
    More majordomo info at http://vger.kernel.org/majordomo-info.html
    Please read the FAQ at http://www.tux.org/lkml/

+ Reply to Thread