Fix "buggy BIOS check" when CPUs are hot removed - Kernel

This is a discussion on Fix "buggy BIOS check" when CPUs are hot removed - Kernel ; Fixes a BUG in ACPI hotplugging. processor_device_array[ pr ->id] needs to be set to NULL when removing a CPU. Else the "buggy BIOS check" in acpi_processor_start mistakenly fires when a CPU is removed from the system and then later re-added. ...

+ Reply to Thread
Results 1 to 2 of 2

Thread: Fix "buggy BIOS check" when CPUs are hot removed

  1. Fix "buggy BIOS check" when CPUs are hot removed

    Fixes a BUG in ACPI hotplugging.

    processor_device_array[pr->id] needs to be set to NULL when removing a
    CPU. Else the "buggy BIOS check" in acpi_processor_start mistakenly
    fires when a CPU is removed from the system and then later re-added.

    Signed-off-by: Alok N Kataria
    Signed-off-by: Dan Arai

    ---
    drivers/acpi/processor_core.c | 1 +
    1 files changed, 1 insertions(+), 0 deletions(-)

    diff --git a/drivers/acpi/processor_core.c
    b/drivers/acpi/processor_core.c
    index 61450f4..0f95f26 100644
    --- a/drivers/acpi/processor_core.c
    +++ b/drivers/acpi/processor_core.c
    @@ -828,6 +828,7 @@ static int acpi_processor_remove(struct acpi_device
    *device, int type)
    }

    processors[pr->id] = NULL;
    + processor_device_array[pr->id] = NULL;

    kfree(pr);

    --
    1.5.4


    --
    To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
    the body of a message to majordomo@vger.kernel.org
    More majordomo info at http://vger.kernel.org/majordomo-info.html
    Please read the FAQ at http://www.tux.org/lkml/

  2. Re: Fix "buggy BIOS check" when CPUs are hot removed

    On Fri, 04 Apr 2008 16:48:44 -0700 Alok Kataria wrote:

    > Fixes a BUG in ACPI hotplugging.
    >
    > processor_device_array[pr->id] needs to be set to NULL when removing a
    > CPU. Else the "buggy BIOS check" in acpi_processor_start mistakenly
    > fires when a CPU is removed from the system and then later re-added.
    >
    > Signed-off-by: Alok N Kataria
    > Signed-off-by: Dan Arai


    I assume this is also needed in 2.6.24.x?

    > diff --git a/drivers/acpi/processor_core.c
    > b/drivers/acpi/processor_core.c
    > index 61450f4..0f95f26 100644
    > --- a/drivers/acpi/processor_core.c
    > +++ b/drivers/acpi/processor_core.c
    > @@ -828,6 +828,7 @@ static int acpi_processor_remove(struct acpi_device
    > *device, int type)
    > }
    >
    > processors[pr->id] = NULL;
    > + processor_device_array[pr->id] = NULL;
    >
    > kfree(pr);
    >


    That set a new record for patch-manglement.
    --
    To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
    the body of a message to majordomo@vger.kernel.org
    More majordomo info at http://vger.kernel.org/majordomo-info.html
    Please read the FAQ at http://www.tux.org/lkml/

+ Reply to Thread