[PATCH] x86: fix miscompile - Kernel

This is a discussion on [PATCH] x86: fix miscompile - Kernel ; This patch local to the x86 tree introduced a fairly obvious compile fault: commit f22fc9998497af6c271385e2025e2fe71c6f15b0 Author: Ingo Molnar Date: Wed Apr 2 12:20:18 2008 +0200 x86: allocate FPU context to init task I've attached the fix below (INIT_THREAD is a ...

+ Reply to Thread
Results 1 to 2 of 2

Thread: [PATCH] x86: fix miscompile

  1. [PATCH] x86: fix miscompile

    This patch local to the x86 tree introduced a fairly obvious compile
    fault:

    commit f22fc9998497af6c271385e2025e2fe71c6f15b0
    Author: Ingo Molnar
    Date: Wed Apr 2 12:20:18 2008 +0200

    x86: allocate FPU context to init task

    I've attached the fix below (INIT_THREAD is a #defined initializer, not
    an actual structure). However, if you get this tree into linux-next,
    they'll do a much better job of shaking out bugs like this than I could.

    James

    ---

    diff --git a/include/asm-x86/processor.h b/include/asm-x86/processor.h
    index d4686cf..2fad98d 100644
    --- a/include/asm-x86/processor.h
    +++ b/include/asm-x86/processor.h
    @@ -828,7 +828,7 @@ extern union thread_xstate init_xstate;
    .sysenter_cs = __KERNEL_CS, \
    .io_bitmap_ptr = NULL, \
    .fs = __KERNEL_PERCPU, \
    - .xstate = &init_xstate;
    + .xstate = &init_xstate, \
    }

    /*


    --
    To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
    the body of a message to majordomo@vger.kernel.org
    More majordomo info at http://vger.kernel.org/majordomo-info.html
    Please read the FAQ at http://www.tux.org/lkml/

  2. Re: [PATCH] x86: fix miscompile


    * James Bottomley wrote:

    > This patch local to the x86 tree introduced a fairly obvious compile
    > fault:


    thanks - i already pulled the original change.

    Ingo
    --
    To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
    the body of a message to majordomo@vger.kernel.org
    More majordomo info at http://vger.kernel.org/majordomo-info.html
    Please read the FAQ at http://www.tux.org/lkml/

+ Reply to Thread