[PATCH 1/7] virtio: fix sparse return void-valued expression warnings - Kernel

This is a discussion on [PATCH 1/7] virtio: fix sparse return void-valued expression warnings - Kernel ; drivers/virtio/virtio_pci.c:148:2: warning: returning void-valued expression drivers/virtio/virtio_pci.c:155:2: warning: returning void-valued expression Signed-off-by: Harvey Harrison --- drivers/virtio/virtio_pci.c | 4 ++-- 1 files changed, 2 insertions(+), 2 deletions(-) diff --git a/drivers/virtio/virtio_pci.c b/drivers/virtio/virtio_pci.c index c0df924..de102a6 100644 --- a/drivers/virtio/virtio_pci.c +++ b/drivers/virtio/virtio_pci.c @@ -145,14 +145,14 @@ ...

+ Reply to Thread
Results 1 to 2 of 2

Thread: [PATCH 1/7] virtio: fix sparse return void-valued expression warnings

  1. [PATCH 1/7] virtio: fix sparse return void-valued expression warnings

    drivers/virtio/virtio_pci.c:148:2: warning: returning void-valued expression
    drivers/virtio/virtio_pci.c:155:2: warning: returning void-valued expression

    Signed-off-by: Harvey Harrison
    ---
    drivers/virtio/virtio_pci.c | 4 ++--
    1 files changed, 2 insertions(+), 2 deletions(-)

    diff --git a/drivers/virtio/virtio_pci.c b/drivers/virtio/virtio_pci.c
    index c0df924..de102a6 100644
    --- a/drivers/virtio/virtio_pci.c
    +++ b/drivers/virtio/virtio_pci.c
    @@ -145,14 +145,14 @@ static void vp_set_status(struct virtio_device *vdev, u8 status)
    struct virtio_pci_device *vp_dev = to_vp_device(vdev);
    /* We should never be setting status to 0. */
    BUG_ON(status == 0);
    - return iowrite8(status, vp_dev->ioaddr + VIRTIO_PCI_STATUS);
    + iowrite8(status, vp_dev->ioaddr + VIRTIO_PCI_STATUS);
    }

    static void vp_reset(struct virtio_device *vdev)
    {
    struct virtio_pci_device *vp_dev = to_vp_device(vdev);
    /* 0 status means a reset. */
    - return iowrite8(0, vp_dev->ioaddr + VIRTIO_PCI_STATUS);
    + iowrite8(0, vp_dev->ioaddr + VIRTIO_PCI_STATUS);
    }

    /* the notify function used when creating a virt queue */
    --
    1.5.5.rc1.135.g8527


    --
    To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
    the body of a message to majordomo@vger.kernel.org
    More majordomo info at http://vger.kernel.org/majordomo-info.html
    Please read the FAQ at http://www.tux.org/lkml/

  2. Re: [PATCH 1/7] virtio: fix sparse return void-valued expression warnings

    On Thursday 03 April 2008 10:33:34 Harvey Harrison wrote:
    > drivers/virtio/virtio_pci.c:148:2: warning: returning void-valued
    > expression drivers/virtio/virtio_pci.c:155:2: warning: returning
    > void-valued expression


    Hi Harvey,

    This patch is in my tree, thanks.

    Rusty.
    --
    To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
    the body of a message to majordomo@vger.kernel.org
    More majordomo info at http://vger.kernel.org/majordomo-info.html
    Please read the FAQ at http://www.tux.org/lkml/

+ Reply to Thread