[PATCH] drivers/atm/ambassador.c: stop inlining largish static functions - Kernel

This is a discussion on [PATCH] drivers/atm/ambassador.c: stop inlining largish static functions - Kernel ; Hi John, Can you please take a look at this patch? drivers/atm/ambassador.c has unusually large number of static inline functions - 22. I looked through them and half of them seem to be too big to warrant inlining. This patch ...

+ Reply to Thread
Results 1 to 2 of 2

Thread: [PATCH] drivers/atm/ambassador.c: stop inlining largish static functions

  1. [PATCH] drivers/atm/ambassador.c: stop inlining largish static functions

    Hi John,

    Can you please take a look at this patch?

    drivers/atm/ambassador.c has unusually large number
    of static inline functions - 22.

    I looked through them and half of them seem to be too big
    to warrant inlining.

    This patch removes "inline" from these static functions
    (regardless of number of callsites - gcc nowadays auto-inlines
    statics with one callsite).

    Size difference for 32bit x86:
    text data bss dec hex filename
    10209 8488 4 18701 490d linux-2.6-ALLYES/drivers/atm/ambassador.o
    9462 8488 4 17954 4622 linux-2.6.inline-ALLYES/drivers/atm/ambassador.o

    Signed-off-by: Denys Vlasenko
    --
    vda


  2. Re: [PATCH] drivers/atm/ambassador.c: stop inlining largish static functions

    From: Denys Vlasenko
    Date: Tue, 1 Apr 2008 03:14:58 +0200

    > This patch removes "inline" from these static functions
    > (regardless of number of callsites - gcc nowadays auto-inlines
    > statics with one callsite).
    >
    > Size difference for 32bit x86:
    > text data bss dec hex filename
    > 10209 8488 4 18701 490d linux-2.6-ALLYES/drivers/atm/ambassador.o
    > 9462 8488 4 17954 4622 linux-2.6.inline-ALLYES/drivers/atm/ambassador.o
    >
    > Signed-off-by: Denys Vlasenko


    I've applied this to net-2.6.26, if John doesn't like it we
    can fix it or revert.
    --
    To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
    the body of a message to majordomo@vger.kernel.org
    More majordomo info at http://vger.kernel.org/majordomo-info.html
    Please read the FAQ at http://www.tux.org/lkml/

+ Reply to Thread