[PATCH] x86 floppy: kill off the 'register' keyword from header - Kernel

This is a discussion on [PATCH] x86 floppy: kill off the 'register' keyword from header - Kernel ; When compilers became generally better at optimizing code than humans, the register keyword became mostly useless. For the floppy driver it certainly is since it's so slow compared to the rest of the system that optimizing access to a single ...

+ Reply to Thread
Results 1 to 2 of 2

Thread: [PATCH] x86 floppy: kill off the 'register' keyword from header

  1. [PATCH] x86 floppy: kill off the 'register' keyword from header


    When compilers became generally better at optimizing code than humans, the
    register keyword became mostly useless. For the floppy driver it certainly
    is since it's so slow compared to the rest of the system that optimizing
    access to a single variable or two isn't going to make any real
    difference
    So let's just leave it to the compiler - it'll do a better job anyway.

    This patch does away with a few register keywords in the x86 floppy driver.


    Signed-off-by: Jesper Juhl
    ---

    floppy.h | 6 +++---
    1 file changed, 3 insertions(+), 3 deletions(-)

    diff --git a/include/asm-x86/floppy.h b/include/asm-x86/floppy.h
    index a48d715..31b0d80 100644
    --- a/include/asm-x86/floppy.h
    +++ b/include/asm-x86/floppy.h
    @@ -52,7 +52,7 @@ static int doing_pdma;

    static irqreturn_t floppy_hardint(int irq, void *dev_id)
    {
    - register unsigned char st;
    + unsigned char st;

    #undef TRACE_FLPY_INT

    @@ -70,8 +70,8 @@ static irqreturn_t floppy_hardint(int irq, void *dev_id)
    #endif

    {
    - register int lcount;
    - register char *lptr;
    + int lcount;
    + char *lptr;

    st = 1;
    for(lcount=virtual_dma_count, lptr=virtual_dma_addr;

    --
    To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
    the body of a message to majordomo@vger.kernel.org
    More majordomo info at http://vger.kernel.org/majordomo-info.html
    Please read the FAQ at http://www.tux.org/lkml/

  2. Re: [PATCH] x86 floppy: kill off the 'register' keyword from header


    * Jesper Juhl wrote:

    > - register unsigned char st;
    > + unsigned char st;


    > - register int lcount;
    > - register char *lptr;
    > + int lcount;
    > + char *lptr;


    thanks, applied.

    Ingo
    --
    To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
    the body of a message to majordomo@vger.kernel.org
    More majordomo info at http://vger.kernel.org/majordomo-info.html
    Please read the FAQ at http://www.tux.org/lkml/

+ Reply to Thread